Bug 534638 – x11-themes/kvantum-0.8.10 - Kvantum is an SVG-based theme engine for Qt4/Qt5 and KDE

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description RedEyedMan 2015-01-04 15:08:56 UTC]

Created attachment 393150 [details]
kvantum-0.8.10.ebuild

Kvantum is an SVG-based theme engine for Qt4/Qt5 and KDE

Homepage: http://kde-look.org/content/show.php/Kvantum?content=166241

Sources: https://github.com/tsujan/Kvantum.git

[Comment 1 Jeroen Roovers (RETIRED) 2015-01-04 22:26:37 UTC]

Comment on attachment 393150 [details]
kvantum-0.8.10.ebuild

># $Header: Galym Kerimbekov [e-mail]

That CVS header is invalid.

>EAPI=5
>inherit eutils git-r3 qmake-utils 

You cannot have a properly versioned ebuild that uses "live" sources.

>DESCRIPTION="Kvantum is an SVG-based theme engine for Qt4/Qt5 and KDE"
>HOMEPAGE="http://kde-look.org/content/show.php/Kvantum?content=166241"
>EGIT_REPO_URI="https://github.com/tsujan/Kvantum.git"

>KEYWORDS="amd64 x86 ~x86-fbsd ~x86-freebsd ~x86-interix ~amd64-linux ~x86-linux"

You tested all those?

>IUSE="+qt4 qt5"

Why the USE default?

>RDEPEND="qt4? ( >=dev-qt/qtcore-4.8.5-r2 )
>	qt5? ( >=dev-qt/qtcore-5.4.0 )
>	qt4? ( >=dev-qt/qtsvg-4.8.5 )
>	qt5? ( >=dev-qt/qtsvg-5.4.0 )
>	>=x11-libs/libX11-1.6.2" 

You should use SLOTs there instead of versions.

>src_install() {
>    emake INSTALL_ROOT="${D}" DESTDIR="${D}" install || die "emake install failed"

emake die()s on its own these days.

>    # Cleaning
>    emake distclean
>}

Why would you do that there? The build directory is about to be destroyed anyway.

[Comment 2 Jeroen Roovers (RETIRED) 2015-01-04 22:29:45 UTC]

Comment on attachment 393150 [details]
kvantum-0.8.10.ebuild

>RDEPEND="qt4? ( >=dev-qt/qtcore-4.8.5-r2 )
>	qt5? ( >=dev-qt/qtcore-5.4.0 )
>	qt4? ( >=dev-qt/qtsvg-4.8.5 )
>	qt5? ( >=dev-qt/qtsvg-5.4.0 )

Additionally, you should do

qt4? ( dev-qt/qtcore:4
       dev-qt/qtsvg:4 )
qt5? ( dev-qt/qtcore:5
       dev-qt/qtsvg:5 )

so that you keep dependencies for each conditional separate. It looks a lot more organised and is less error prone.

[Comment 3 RedEyedMan 2015-01-06 10:09:19 UTC]

Created attachment 393306 [details]
x11-themes/kvantum-9999.ebuild

x11-themes/kvantum-9999.ebuild

CVS header is empty now
USE qt4 is not default, so it is good to choose qt5
SLOTs are uses now
untested KEYWORDS removed

Thanks for recommendations

I wish to be an maintainer of that package. I'm use it often.

[Comment 4 Coacher 2016-02-02 05:40:54 UTC]

(In reply to RedEyedMan from comment #3)
> I wish to be an maintainer of that package. I'm use it often.

If you are still interested, then you can proxy-maintain it.

I understand that you are already a proxy-maintainer, so you know how to reach proxy-maint devs. As a reminder here's a wiki page: https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers