Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53462 - lilo 22.5.9 addes dolilo that by default will overwrite completely accurate lilo.conf and /boot/bzImage with crap
Summary: lilo 22.5.9 addes dolilo that by default will overwrite completely accurate l...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-09 15:41 UTC by Matti Rendahl
Modified: 2009-12-12 18:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Added if [ `use dolilo` ] to disable it (lilo-23.5.9.ebuild.diff,1.90 KB, patch)
2004-06-09 15:55 UTC, Matti Rendahl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matti Rendahl 2004-06-09 15:41:35 UTC
I had a handtailored /etc/lilo.conf and after emerge -u lilo I suddenly had some sort of probably good default file for booting either a new (bzImage) or an old (bzImage.old) and running memtest86. And /boot/bzImage that wasn't there before...

The default in /etc/conf.d/dolilo should be not to overwrite!

Reproducible: Always
Steps to Reproduce:
1. emerge [-u] lilo


Actual Results:  
My /etc/lilo.conf get overwritten med default nonsens. Also if I had a
/boot/bzImage this will be replace with the bzImage dolilo calculates that I
should have... 

Expected Results:  
My old /etc/lilo.con and /boot/bzImage as they where as I didn't ask for
overwrite, and didn't have a chance to alter /etc/conf.d/dolilo as it was
installed and run before I had a change to do anything. An option in
conf.d/dolilo  not to run lilo for me after an update would probably be a good
ide as well.

Best of all I think would be a local USE flag -dolilo so I can disable it
altoghether...

Portage 2.0.50-r8 (default-x86-2004.0, gcc-3.3.3, glibc-2.3.3.20040420-r0,
2.6.7-rc1-mm1)
=================================================================
System uname: 2.6.7-rc1-mm1 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Gentoo Base System version 1.4.16
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config
/usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://trumpetti.atm.tut.fi/gentoo/
http://ds.thn.htu.se/linux/gentoo http://ftp.du.se/pub/os/gentoo
http://mirror.pudas.net/gentoo
http://mirrors.sec.informatik.tu-darmstadt.de/gentoo/"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib alsa apache2 apm arts avi berkdb bonobo cdr crypt cups dvdr emacs
encode esd foomaticdb gdbm gif gnome gnome2 gphoto2 gpm gtk gtk2 guile imlib
java jpeg kde ldap libg++ libwww mad mikmod motif mozilla moznocompose moznoirc
moznomail mpeg mysql ncurses nls nptl oggvorbis opengl oss pam pdflib perl png
python qt quicktime readline sdl slang spell ssl svga tcltk tcpd tetex truetype
x86 xemacs xml xml2 xmms xv zlib"
Comment 1 Matti Rendahl 2004-06-09 15:55:33 UTC
Created attachment 32998 [details, diff]
Added if [ `use dolilo` ] to disable it

Suggestion for USE [-]dolilo to get or not get it installed/used. Still think
the default conf.d/dolilo should be set up so that dolilo does no overwrite
lilo.conf, and leaves /boot/bzImage be if already there. At least without flags
telling in to find the correct kernel to configure for boot...
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2004-06-09 22:38:10 UTC
That should be the default, dolilo should not touch /etc/lilo.conf if it exists as /etc/conf.d/dolilo has #OVERWRITE instead of OVERWRITE. I'll look into this rightaway.
Could you try deleting /etc/conf.d/dolilo, then running dolilo again? It should force the default of OVERWRITE being disabled. If that's the case I'll stop the ebuild from installing the config file for now.
Comment 3 Guillaume Castagnino 2004-06-09 22:46:35 UTC
Same problem.
When removing /etc/conf.d/dolilo, dolilo doesn't recrate the file, and lilo.conf seems no more to be overwriten (wich is the right behaviour)
Comment 4 Matti Rendahl 2004-06-09 23:04:03 UTC
There is no #OVERWRITE in /etc/conf.d/dolilo, but a REWRITE (not commented out)

As dolilo is installed with lilo, there is no way to fix this (remove/edit conf.d/dolilo initially.

Removing /etc/conf.d/dolilo and then running dolilo will always reslut in:

matti portage # dolilo
Bootsector updated succesfully.

and even this I would hate to see happen when *merging lilo*... espec. when an error when running dolilo in the ebuild only results in a warning "please check before your next reboot" which easily could be overlooked (well, we're all only humans, right).

Comment 5 Matti Rendahl 2004-06-09 23:06:30 UTC
> As dolilo is installed with lilo, there is no way to fix this (remove/edit conf.d/dolilo initially.

Well, ofcourse in the dist, I meant as a user doing emerge [-u] lilo :-)
Comment 6 Tony Vroon (RETIRED) gentoo-dev 2004-06-09 23:15:00 UTC
I will upload a configuration file with REWRITE properly commented out, that will fix the issue.
In the meantime, changing REWRITE to #REWRITE yourself, in /etc/conf.d/dolilo, will fix it.

Note that dolilo will only hide LILO's messages if no error occured (exitcode 0). In any other situation, it will say; LILO error:
<full details here>
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2004-06-10 11:00:50 UTC
lilo-22.5.9-r1 was just added to CVS. It should appear in the tree soon.
It installs /etc/conf.d/dolilo.example, to make sure dolilo uses the safe default of "don't touch existing config". It also has the updated devmapper support patch by Christophe Saout.
This should be a lot better. Thanks for your bugreport, and sorry for your bumpy ride (even though that's part of the enjoyment of running ~x86).