Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 534148 - app-emulation/libguestfs app-emulation/libguestfs-appliance should install /usr/share/guestfs/appliance/README.fixed
Summary: app-emulation/libguestfs app-emulation/libguestfs-appliance should install /u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreis Vinogradovs ( slepnoga )
URL:
Whiteboard:
Keywords: PATCH
: 537082 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-31 20:11 UTC by Tom Prince
Modified: 2015-05-27 20:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix. (diff,337 bytes, patch)
2015-01-05 14:42 UTC, Tom Prince
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Prince 2014-12-31 20:11:45 UTC
libguestfs looks for README.fixed 
https://github.com/libguestfs/libguestfs/blob/8e0ae6560e6629f6e435147557f8e0e42ec7986c/src/appliance.c#L196-202
to determine if an appliance is a fixed one.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-02 18:50:32 UTC
1) Please post your `emerge --info app-emulation/libguestfs-appliance' output in a comment.
2) Please explain the problem, along with command output and anything else particular to this bug report.
Comment 2 Tom Prince 2015-01-05 14:42:35 UTC
Created attachment 393248 [details, diff]
Fix.

% echo $LIBGUESTFS_PATH
/usr/share/guestfs/appliance/
% virt-list-filesystems -a /dev/null
cannot find any suitable libguestfs supermin, fixed or old-style appliance on LIBGUESTFS_PATH (search path: /usr/share/guestfs/appliance/) at /usr/bin/virt-list-filesystems line 163.
% sudo touch $LIBGUESTFS_PATH/README.fixed                                
% virt-list-filesystems -a /dev/null       
/dev/sda
% eix libguestfs
[I] app-emulation/libguestfs
     Available versions:  (~)1.26.1(0/1.26) (~)1.28.3(0/1.28) (~)1.28.5(0/1.28) {bash-completion debug doc erlang +fuse inspect-icons introspection lua (+)ocaml +perl ruby selinux static-libs systemtap test}
     Installed versions:  1.28.5(16:09:33 12/31/14)(bash-completion fuse lua ocaml perl -debug -doc -erlang -inspect-icons -introspection -ruby -selinux -static-libs -systemtap -test)
     Homepage:            http://libguestfs.org/
     Description:         Tools for accessing, inspect and modifying virtual machine (VM) disk images

[I] app-emulation/libguestfs-appliance
     Available versions:  (~)1.26.0-r1 (~)1.28.1
     Installed versions:  1.28.1(11:43:13 12/31/14)
     Homepage:            http://libguestfs.org/
     Description:         VM appliance disk image used in libguestfs package

Found 2 matches.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-06 09:47:50 UTC
(In reply to Jeroen Roovers from comment #1)
> 1) Please post your `emerge --info app-emulation/libguestfs-appliance'
> output in a comment.
Comment 4 Tom Prince 2015-01-09 18:16:20 UTC
> 1) Please post your `emerge --info app-emulation/libguestfs-appliance'
> output in a comment.

I'm not sure of the point of this. There is already
- reproduction instructions
- a link to the upstream code that is relevant to the bug.
- a patch.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-09 19:30:57 UTC
I'm sure of it.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2015-01-19 21:00:56 UTC
*** Bug 537082 has been marked as a duplicate of this bug. ***
Comment 7 Daniel Augustin 2015-01-19 21:10:23 UTC
Rather than what is suggested here I recommend this patch:

https://bugs.gentoo.org/attachment.cgi?id=394356 that makes libguestfs ignore the README.fixed requirement.

Also see https://bugzilla.redhat.com/show_bug.cgi?id=1183780 for the redhat bug for this.

Additional details are in the resolved duplicated bug #537082
Comment 8 Tom Prince 2015-01-19 23:13:40 UTC
Is there any point in diverging from upstream? If a user builds their own appliance, it seems like the changed the detection logic will mis-detect the type of appliance.

If the point is not having duplicate documentation or something, the README.fixed in the appliance directory could just be a file explaning that it needs to be there for proper detection, or a symlink, or a empty file.
Comment 9 Tom Prince 2015-01-19 23:15:51 UTC
Another option would be to have some file that explicitly describes the appliance, but that seems like something that is best done upstream, and it seems like upstream is reluctant to add another appliance format (they already have 3).

From  Richard W.M. Jones (https://bugzilla.redhat.com/show_bug.cgi?id=1183780#c4)
> Or we could work on something upstream (not sure exactly what -- I
> don't want to introduce yet another "type" of appliance, we have
> too many of them already).
Comment 10 Maxim Koltsov (RETIRED) gentoo-dev 2015-05-27 20:08:14 UTC
Well, sorry for the delay. I was poked by user today and finally fixed it. Now README.fixed is installed.

Enjoy!