Bug 53413 – sys-boot/lilo-22.5.9 fails

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Carsten Lohrke (RETIRED) 2004-06-09 07:29:16 UTC]

Changes from version 22.5.8 to 22.5.9 (08-Apr-2004) John Coffman

  Boot Installer
  --------------
    - Alter NT check for invalid volume ID -- no change on single disk
      systems.  (device.c)
    - Make 'prompt' a word.  (common.h, first.S)
    - Add 'bmp-retain' local & global option.  (bsect.c, cfg.c, second.S)
      Retains bitmap after booting.
    - Add Makefile option "lilo-static:"  -- must specifically make it.
    - Fix setting of "map==boot" for RAID installs.  (bsect.c, raid.c)

  Boot Loader
  -----------
    - Skip duplicate VolumeIDs in second stage, in case a disk has been
      added to the system.  (volume.S)

  Utilities
  ---------
    - Update QuickInst to reflect absence of 'activate', using lilo -A

[Comment 1 Tony Vroon (RETIRED) 2004-06-09 09:57:06 UTC]

The lilo 22.5.9 ebuild is in CVS, and should appear in the tree soon. Thanks for your bump request :)

[Comment 2 Carsten Lohrke (RETIRED) 2004-06-09 13:11:59 UTC]

sorry, but 

 * Failed Patch: lilo-22.5.9-devmapper_gentoo.patch

[Comment 3 Carsten Lohrke (RETIRED) 2004-06-09 13:12:57 UTC]

Created attachment 32994 [details]
lilo-22.5.9-devmapper_gentoo.patch-23052.out

[Comment 4 Tony Vroon (RETIRED) 2004-06-09 15:00:40 UTC]

Okay, bad thing.
Rediffed lilo-22.5.9-devmapper_gentoo.patch is now made.
I'll be committing it to CVS soon. Not bumping revision.

[Comment 5 Tony Vroon (RETIRED) 2004-06-09 15:15:45 UTC]

Created attachment 32995 [details, diff]
lilo-22.5.8-devmapper_gentoo.patch

This is the correct patch. Unfortunately CVS access is too slow from here over
GPRS so I can't commit this until tomorrow. (Feel free to commit this new patch
if you have the chance).

[Comment 6 Tony Vroon (RETIRED) 2004-06-09 15:30:36 UTC]

Comment on attachment 32995 [details, diff]
lilo-22.5.8-devmapper_gentoo.patch

Okay. Correct patch (not this one, no) committed to CVS, should reach you soon.
Sorry for the trouble.

[Comment 7 Tony Vroon (RETIRED) 2004-06-09 15:31:40 UTC]

Rediffed patch should fix the devmapper issue. Re-closing.

[Comment 8 Christophe Saout 2004-06-10 04:24:57 UTC]

Created attachment 33021 [details, diff]
Fixed devmapper patch.

Ooops.

With lilo 22.5.9 a bug showed up. There's a bug that was in that patch all the
time. I had overlooked these crappy readlink semantics... we need to clear buf
with zeroes before calling readlink (and can drop the buf[PATH_MAX] = 0;
afterwards)

I've attached the fixed gentoo patch with these two lines modified.

(in my case lilo was complaining that realpath("/dev/mapper/vg-boot	   ?")
failed... in case someone is seeing the same problem)

I apologize.

[Comment 9 Tony Vroon (RETIRED) 2004-06-10 09:55:25 UTC]

Right, thank you Christophe. I'll get that in CVS rightaway.
I'll release a lilo-22.5.9-r1 now with an updated devmapper patch. (I have another  fix to do, good opportunity).