Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 534008 - games-action/minetest-0.4.11 games-action/minetest_game-0.4.11 version bump
Summary: games-action/minetest-0.4.11 games-action/minetest_game-0.4.11 version bump
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All All
: Normal normal with 1 vote (vote)
Assignee: Account Disabled (uid 86422)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-30 10:49 UTC by Jaak Ristioja
Modified: 2015-08-29 14:53 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
minetest-0.4.11.ebuild (minetest-0.4.11-r1.ebuild,3.46 KB, text/plain)
2015-01-16 22:22 UTC, Julian Ospald
Details
minetest_game-0.4.11.ebuild (minetest_game-0.4.11-r1.ebuild,665 bytes, text/plain)
2015-01-16 22:23 UTC, Julian Ospald
Details
ebuild for minetest-0.4.11 including the fix for bug #541122 (minetest-0.4.11.ebuild,3.46 KB, text/plain)
2015-02-24 12:32 UTC, Account Disabled (uid 86422)
Details
Required patch for 0.4.11 (minetest-0.4.11-as-needed.patch,871 bytes, patch)
2015-02-24 12:33 UTC, Account Disabled (uid 86422)
Details | Diff
Another reuqired patch for 0.4.11 (minetest-0.4.11-shared-irrlicht.patch,614 bytes, patch)
2015-02-24 12:33 UTC, Account Disabled (uid 86422)
Details | Diff
New patch for the version bump (minetest-0.4.11.patch,1.72 KB, patch)
2015-03-10 15:00 UTC, Account Disabled (uid 86422)
Details | Diff
0.4.12 bump and changes (minetest-0.4.12.patch,1.79 KB, patch)
2015-03-24 18:45 UTC, myoung008
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaak Ristioja 2014-12-30 10:49:12 UTC
Minetest 0.4.11 was released on Dec 26, 2014.

  https://github.com/minetest/minetest/releases/tag/0.4.11

Minetest_game-0.4.11 was released on Dec 21, 2014

  https://github.com/minetest/minetest_game/releases/tag/0.4.11
Comment 1 Account Disabled (uid 86422) 2015-01-07 16:00:29 UTC
(In reply to Jaak Ristioja from comment #0)
> Minetest 0.4.11 was released on Dec 26, 2014.
> 
>   https://github.com/minetest/minetest/releases/tag/0.4.11
> 
> Minetest_game-0.4.11 was released on Dec 21, 2014
> 
>   https://github.com/minetest/minetest_game/releases/tag/0.4.11

Thank you for the reminder, i am currently working on the ebuilds for version 0.4.11. The ebuilds are so far ready and i tested them succesfully on my machine, i am right now just waiting for review of my ebuilds from the proxy-maintainer team and the following submission to the portage tree by them.
Comment 2 Julian Ospald 2015-01-16 22:22:05 UTC
Created attachment 394112 [details]
minetest-0.4.11.ebuild
Comment 3 Julian Ospald 2015-01-16 22:23:29 UTC
Created attachment 394114 [details]
minetest_game-0.4.11.ebuild
Comment 4 Account Disabled (uid 86422) 2015-01-16 23:06:28 UTC
(In reply to Julian Ospald (hasufell) from comment #3)
> Created attachment 394114 [details]
> minetest_game-0.4.11.ebuild

I tested both ebuilds in my local overlay, the one for minetest_game seems fine so far but i have a question related to the other ebuild. Shouldnt the patches that get applied at lines 58 and 59 be renamed to the appropriate version number so that 

${FILESDIR}"/${PN}-0.4.10-shared-irrlicht.patch -> ${FILESDIR}"/${PN}-0.4.11-shared-irrlicht.patch

and

${FILESDIR}"/${PN}-0.4.10-as-needed.patch -> ${FILESDIR}"/${PN}-0.4.11-as-needed.patch ?

I mean we have the patches for version 0.4.9 and the patches for 0.4.10, so having the patches for 0.4.11 would be just consistent.
Comment 6 Account Disabled (uid 86422) 2015-01-16 23:29:10 UTC
(In reply to Julian Ospald (hasufell) from comment #5)
> https://github.com/hasufell/gentoo-portage/commit/
> c73f368688c1938fd5e0b261d4da902cf25ae661
> https://github.com/hasufell/gentoo-portage/commit/
> b7db016c4f23f2a2c1d3292e65d68d2a70146652

Everything is okay from my side then.
Comment 8 Account Disabled (uid 86422) 2015-02-24 12:32:00 UTC
Created attachment 397388 [details]
ebuild for minetest-0.4.11 including the fix for bug #541122
Comment 9 Account Disabled (uid 86422) 2015-02-24 12:33:01 UTC
Created attachment 397390 [details, diff]
Required patch for 0.4.11
Comment 10 Account Disabled (uid 86422) 2015-02-24 12:33:34 UTC
Created attachment 397392 [details, diff]
Another reuqired patch for 0.4.11
Comment 11 Account Disabled (uid 86422) 2015-02-24 12:38:49 UTC
(In reply to Martin-Kevin Neumann from comment #8)
> Created attachment 397388 [details]
> ebuild for minetest-0.4.11 including the fix for bug #541122

Attachment #394112 [details] is obsolet now. Attachment #394114 [details], #397388, #397390, #397392
are all the required files to bump minetest to 0.4.11
Comment 12 neko259 2015-03-07 13:17:14 UTC
0.4.12 is out a long time ago, please make a ebuild for it instead of 0.4.11
Comment 13 Account Disabled (uid 86422) 2015-03-07 17:17:49 UTC
(In reply to neko259 from comment #12)
> 0.4.12 is out a long time ago, please make a ebuild for it instead of 0.4.11

I will look into it, but i am just wondering why it takes so long to bump that package, the work was already done it just needed someone to look at the provided files and check if everything is alright and then commit it to cvs.

If there are issues with the files, why do i get no feedback at all about it?
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2015-03-09 15:41:32 UTC
(In reply to Martin-Kevin Neumann from comment #13)
> (In reply to neko259 from comment #12)
> > 0.4.12 is out a long time ago, please make a ebuild for it instead of 0.4.11
> 
> I will look into it, but i am just wondering why it takes so long to bump
> that package, the work was already done it just needed someone to look at
> the provided files and check if everything is alright and then commit it to
> cvs.
> 
> If there are issues with the files, why do i get no feedback at all about it?

I don't know if there's a good answer to that.  I'll look tomorrow to committing what's here, late here. Work on the bump
Comment 15 Adam Feldman gentoo-dev 2015-03-10 01:43:06 UTC
In the latest version of your ebuild, you have
enewuser ${PN} -1 -1 /var/lib/${PN} ${PN}
In the previous version, it was
enewuser ${PN} -1 -1 /var/lib/${PN} ${GAMES_GROUP}

Two comments, 1) as is, the group ${PN} doesn't exist so this fails.  You'll need to create it, or, see the next comment. 2) Generally speaking, games should use the ${GAMES_GROUP}.  You might want to get an opinion from someone more intimately involved with the games herd, but I think you probably keep to the GAMES_GROUP unless you really need your own group for another reason.
Comment 16 Ian Delaney (RETIRED) gentoo-dev 2015-03-10 02:01:33 UTC
MN

1.  It took me a long time to decipher Comment 11, mainly due to simply syntax and style.  The reading of all this info would be made easier by having given these a name at the time of attachment. (Don't have us guessing)

2. When I did, I found that they were in fact duplicates of files/{minetest-0.4.10-as-needed.patch,minetest-0.4.10-shared-irrlicht.patch}.  We do NOT care to fill FILESDIR with duplicates of the same patch; 

"${FILESDIR}"/${PN}-0.4.10-shared-irrlicht.patch \
"${FILESDIR}"/${PN}-0.4.10-as-needed.patch

relieves us of this.

3.  While a whole ebuild is perfectly fine, it's preferred to make a diff -u patch of a bumped ebuild and the prior version. In this case the adjustment in 2. is trivial, it can be simply edited after the patch is used to edit a copy paste of the prior ebuild.

diff -u minetest-0.4.10-r2.ebuild minetest-0.4.11.ebuild > /path/to/somewhere/nice/minetest.patch

attach patch and then we can
/correct/path/patch <  /path/from/somewhere/nice/minetest.patch

 minetest_game-0.4.11.ebuild is as yet untested.  NP-Hardass has installed all deps and the ebuild completes to install once the group was edited to ${PN}.

Still, good work.  Keep it up.
Comment 17 Ian Delaney (RETIRED) gentoo-dev 2015-03-10 02:43:42 UTC
rather, once the group was edited to ${GAMES_GROUP}.
Comment 18 Julian Ospald 2015-03-10 11:12:38 UTC
(In reply to Ian Delaney from comment #16)
> 
> We do NOT care to fill FILESDIR with duplicates of the same patch; 
> 

That is up to the maintainer.
Comment 19 Ian Delaney (RETIRED) gentoo-dev 2015-03-10 13:19:54 UTC
It's also poor form and a waste of space
Comment 20 Account Disabled (uid 86422) 2015-03-10 15:00:54 UTC
Created attachment 398614 [details, diff]
New patch for the version bump

I cleaned up the ebuild for 0.4.11 and created a patch of it now.

Thanks for the feedback so far. Having the same patches for different versions wasnt my idea, i just followed the pattern for the beginning.

I am thinking about changing that but i'll need some more time to make that decision so for now i want stay with having multiple patches.
Comment 21 Julian Ospald 2015-03-11 12:07:47 UTC
(In reply to Ian Delaney from comment #19)
> It's also poor form and a waste of space

your opinion on this doesn't matter when the games herd explicitly asked the maintainer to do it that way
Comment 22 myoung008 2015-03-24 18:45:00 UTC
Created attachment 399638 [details, diff]
0.4.12 bump and changes

applies to 0.4.10-r2
Comment 23 myoung008 2015-03-24 18:55:23 UTC
Sorry for the double message...

The patch I just attached:
 includes the doc patch from this bug
 uses files/0.4.10* patches instead of creating new ones for 0.4.12
 remove "rm -r src/sqlite || die" from ebuild as it no longer exists in 0.4.12 source

Builds with and without doc on x86-64; minor testing -- loaded world and saw it come up

Builds with crossdev for armv7 - no testing

minetest_game just needs a version bump
Comment 24 Jesse Walter Blaise Going 2015-06-06 21:05:43 UTC
(In reply to myoung008 from comment #23)
> Sorry for the double message...
> 
> The patch I just attached:
>  includes the doc patch from this bug
>  uses files/0.4.10* patches instead of creating new ones for 0.4.12
>  remove "rm -r src/sqlite || die" from ebuild as it no longer exists in
> 0.4.12 source
> 
> Builds with and without doc on x86-64; minor testing -- loaded world and saw
> it come up
> 
> Builds with crossdev for armv7 - no testing
> 
> minetest_game just needs a version bump

Just tested the ebuild on both an AMD64 and an Intel Pentium M 1.73GHz i686-32

Everything seems fine, clean compile... :)
Comment 25 Ian Delaney (RETIRED) gentoo-dev 2015-06-09 04:06:55 UTC
(In reply to Julian Ospald (hasufell) from comment #21)
> (In reply to Ian Delaney from comment #19)
> > It's also poor form and a waste of space
> 
> your opinion on this doesn't matter when the games herd explicitly asked the
> maintainer to do it that way

Then I do not wish to play this game and support such an approach. A case here for the games authors or someone else in the proxy herd to see this committed.
Comment 26 Julian Ospald 2015-06-10 10:24:05 UTC
(In reply to Ian Delaney from comment #25)
> (In reply to Julian Ospald (hasufell) from comment #21)
> > (In reply to Ian Delaney from comment #19)
> > > It's also poor form and a waste of space
> > 
> > your opinion on this doesn't matter when the games herd explicitly asked the
> > maintainer to do it that way
> 
> Then I do not wish to play this game and support such an approach. A case
> here for the games authors or someone else in the proxy herd to see this
> committed.

It's called respect for the herd/project involved in maintenance... following their style recommendations.

Would you like people to ignore python project policies?
Comment 27 Account Disabled (uid 86422) 2015-08-29 14:53:26 UTC
https://bugs.gentoo.org/show_bug.cgi?id=558978

As you can see, work started on bumping to 0.4.13 so i close the bug as 0.4.11 will be skipped.