Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 533338 - lxde-base/lxdm should create Gentoo specific PAM files
Summary: lxde-base/lxdm should create Gentoo specific PAM files
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-22 20:04 UTC by Joakim Tjernlund
Modified: 2023-06-25 13:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lxdm ebuild (lxdm-0.5.0-r3.ebuild,1.66 KB, text/plain)
2015-01-17 17:39 UTC, Joakim Tjernlund
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2014-12-22 20:04:35 UTC
PAM config files (/etc/pam.d/*) are distribtion specific and Gentoo
should create its own instead of using upstream files.

See this bug for lxdm PAM files:
https://bugs.gentoo.org/show_bug.cgi?id=524792
Comment 1 Joakim Tjernlund 2014-12-22 20:07:17 UTC
Gaaah, that should be lxdm
Comment 2 Joakim Tjernlund 2015-01-17 17:39:27 UTC
Created attachment 394180 [details]
lxdm ebuild

Here is a working lxdm ebuild.

You will need Xsession from bug
https://bugs.gentoo.org/show_bug.cgi?id=532032

BTW, this is moving along too slow
Comment 3 Brian Evans (RETIRED) gentoo-dev 2016-08-14 18:06:14 UTC
(In reply to Joakim Tjernlund from comment #2)
> Created attachment 394180 [details]
> lxdm ebuild
> 
> Here is a working lxdm ebuild.
> 
> You will need Xsession from bug
> https://bugs.gentoo.org/show_bug.cgi?id=532032
> 
> BTW, this is moving along too slow

These changes break consolekit support on lxdm.

I don't see problems with the upstream supplied file once pam_console is removed.
Comment 4 Joakim Tjernlund 2016-08-14 18:43:51 UTC
(In reply to Brian Evans from comment #3)
> (In reply to Joakim Tjernlund from comment #2)
> > Created attachment 394180 [details]
> > lxdm ebuild
> > 
> > Here is a working lxdm ebuild.
> > 
> > You will need Xsession from bug
> > https://bugs.gentoo.org/show_bug.cgi?id=532032
> > 
> > BTW, this is moving along too slow
> 
> These changes break consolekit support on lxdm.

oh, how?
Maybe it can be can be fixed using the pam eclass ?
> 
> I don't see problems with the upstream supplied file once pam_console is
> removed.

It is just plain luck, the PAM conf is dist. specific.
Comment 5 Brian Evans (RETIRED) gentoo-dev 2016-08-15 00:02:13 UTC
(In reply to Joakim Tjernlund from comment #4)
> (In reply to Brian Evans from comment #3)
> > (In reply to Joakim Tjernlund from comment #2)
> > > Created attachment 394180 [details]
> > > lxdm ebuild
> > > 
> > > Here is a working lxdm ebuild.
> > > 
> > > You will need Xsession from bug
> > > https://bugs.gentoo.org/show_bug.cgi?id=532032
> > > 
> > > BTW, this is moving along too slow
> > 
> > These changes break consolekit support on lxdm.
> 
> oh, how?
> Maybe it can be can be fixed using the pam eclass ?

When I signed into XFCE from lxdm, none of the consolekit features like Reboot, Shutdown or Suspend were available.

Reverting the change had it working again.

I'm not sure of the exact cause at this time.
Comment 6 Joakim Tjernlund 2016-08-16 07:51:31 UTC
(In reply to Brian Evans from comment #5)
> (In reply to Joakim Tjernlund from comment #4)
> > (In reply to Brian Evans from comment #3)
> > > (In reply to Joakim Tjernlund from comment #2)
> > > > Created attachment 394180 [details]
> > > > lxdm ebuild
> > > > 
> > > > Here is a working lxdm ebuild.
> > > > 
> > > > You will need Xsession from bug
> > > > https://bugs.gentoo.org/show_bug.cgi?id=532032
> > > > 
> > > > BTW, this is moving along too slow
> > > 
> > > These changes break consolekit support on lxdm.
> > 
> > oh, how?
> > Maybe it can be can be fixed using the pam eclass ?
> 
> When I signed into XFCE from lxdm, none of the consolekit features like
> Reboot, Shutdown or Suspend were available.
> 
> Reverting the change had it working again.
> 
> I'm not sure of the exact cause at this time.

Would you mind bisecting the exact change causing this?
Comment 7 Brian Evans (RETIRED) gentoo-dev 2016-08-16 13:35:14 UTC
(In reply to Joakim Tjernlund from comment #6)
> (In reply to Brian Evans from comment #5)
> > (In reply to Joakim Tjernlund from comment #4)
> > > (In reply to Brian Evans from comment #3)
> > > > (In reply to Joakim Tjernlund from comment #2)
> > > > > Created attachment 394180 [details]
> > > > > lxdm ebuild
> > > > > 
> > > > > Here is a working lxdm ebuild.
> > > > > 
> > > > > You will need Xsession from bug
> > > > > https://bugs.gentoo.org/show_bug.cgi?id=532032
> > > > > 
> > > > > BTW, this is moving along too slow
> > > > 
> > > > These changes break consolekit support on lxdm.
> > > 
> > > oh, how?
> > > Maybe it can be can be fixed using the pam eclass ?
> > 
> > When I signed into XFCE from lxdm, none of the consolekit features like
> > Reboot, Shutdown or Suspend were available.
> > 
> > Reverting the change had it working again.
> > 
> > I'm not sure of the exact cause at this time.
> 
> Would you mind bisecting the exact change causing this?

Bisect? I don't understand what you wish to do.

I added:
	# Remove existing pam file. We will build a new one. Bug #533338
	rm -rf "${ED}"/etc/pam.d/${PN}
	pamd_mimic system-local-login ${PN} auth account password session #37222

locally and it broke, so i removed it before publishing.
Comment 8 Joakim Tjernlund 2016-08-17 21:02:14 UTC
(In reply to Brian Evans from comment #7)
> (In reply to Joakim Tjernlund from comment #6)
> > (In reply to Brian Evans from comment #5)
> > > (In reply to Joakim Tjernlund from comment #4)
> > > > (In reply to Brian Evans from comment #3)
> > > > > (In reply to Joakim Tjernlund from comment #2)
> > > > > > Created attachment 394180 [details]
> > > > > > lxdm ebuild
> > > > > > 
> > > > > > Here is a working lxdm ebuild.
> > > > > > 
> > > > > > You will need Xsession from bug
> > > > > > https://bugs.gentoo.org/show_bug.cgi?id=532032
> > > > > > 
> > > > > > BTW, this is moving along too slow
> > > > > 
> > > > > These changes break consolekit support on lxdm.
> > > > 
> > > > oh, how?
> > > > Maybe it can be can be fixed using the pam eclass ?
> > > 
> > > When I signed into XFCE from lxdm, none of the consolekit features like
> > > Reboot, Shutdown or Suspend were available.
> > > 
> > > Reverting the change had it working again.
> > > 
> > > I'm not sure of the exact cause at this time.
> > 
> > Would you mind bisecting the exact change causing this?
> 
> Bisect? I don't understand what you wish to do.
> 
> I added:
> 	# Remove existing pam file. We will build a new one. Bug #533338
> 	rm -rf "${ED}"/etc/pam.d/${PN}
> 	pamd_mimic system-local-login ${PN} auth account password session #37222
> 
> locally and it broke, so i removed it before publishing.

I meant trying to find out what wrong by slowly moving your /etc/pam.d/lxdm from
#%PAM-1.0
auth       substack	system-auth
auth       optional	pam_gnome_keyring.so
account    include	system-auth
session    optional	pam_keyinit.so force revoke
session    include	system-auth
#session    optional	pam_console.so
session    optional	pam_gnome_keyring.so auto_start
session    optional	pam_selinux.so

to

# File autogenerated by pamd_mimic in pam eclass
auth	include		system-local-login
account	include		system-local-login
password	include		system-local-login
session	include		system-local-login

I would guess something in the session part, maybe pam_keyinit.so?
Comment 9 Brian Evans (RETIRED) gentoo-dev 2016-08-18 22:46:52 UTC
(In reply to Joakim Tjernlund from comment #8)
> I meant trying to find out what wrong by slowly moving your /etc/pam.d/lxdm
> from
> #%PAM-1.0
> auth       substack	system-auth
> auth       optional	pam_gnome_keyring.so
> account    include	system-auth
> session    optional	pam_keyinit.so force revoke
> session    include	system-auth
> #session    optional	pam_console.so
> session    optional	pam_gnome_keyring.so auto_start
> session    optional	pam_selinux.so
> 
> to
> 
> # File autogenerated by pamd_mimic in pam eclass
> auth	include		system-local-login
> account	include		system-local-login
> password	include		system-local-login
> session	include		system-local-login
> 
> I would guess something in the session part, maybe pam_keyinit.so?

The problem occurs when I change the session option to system-local-login.

I'm not sure if this line from /etc/pam.d/system-login is related
session		optional	pam_ck_connector.so nox11
Comment 10 Joakim Tjernlund 2016-08-22 11:06:19 UTC
(In reply to Brian Evans from comment #9)
> (In reply to Joakim Tjernlund from comment #8)
> > I meant trying to find out what wrong by slowly moving your /etc/pam.d/lxdm
> > from
> > #%PAM-1.0
> > auth       substack	system-auth
> > auth       optional	pam_gnome_keyring.so
> > account    include	system-auth
> > session    optional	pam_keyinit.so force revoke
> > session    include	system-auth
> > #session    optional	pam_console.so
> > session    optional	pam_gnome_keyring.so auto_start
> > session    optional	pam_selinux.so
> > 
> > to
> > 
> > # File autogenerated by pamd_mimic in pam eclass
> > auth	include		system-local-login
> > account	include		system-local-login
> > password	include		system-local-login
> > session	include		system-local-login
> > 
> > I would guess something in the session part, maybe pam_keyinit.so?
> 
> The problem occurs when I change the session option to system-local-login.
> 
> I'm not sure if this line from /etc/pam.d/system-login is related
> session		optional	pam_ck_connector.so nox11

Ahh, now I see it too. Googling says that one should not use pam_ck_connector.so
with lxdm.
I don't that the pam eclass supports partial pam config file generation.
I guess we can do ATM is:
auth	include		system-local-login
account	include		system-local-login
password	include		system-local-login
auth	include		system-local-login
session    optional	pam_keyinit.so force revoke
session    include	system-auth
session    optional	pam_gnome_keyring.so auto_start
session    optional	pam_selinux.so
Comment 11 Joakim Tjernlund 2016-08-22 11:24:40 UTC
Possibly one could disable consolekit in LXDM and use pam_ck_connector.so
in PAM conf.
I have not tested that though.