Bug 531958 – sys-apps/most: build system fix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benda Xu 2014-12-08 03:48:32 UTC]

Here I attach two minor patches for review.  The patches have been forwarded to the upstream author John E. Davis.

"most" completely replies on slang to access terminfo/termcap, by
SLtt_get_terminfo() and friends.

Nothing should be considered by most but to find slang. Therefore it
should not link against libtermcap in any case.

        * configure.ac: remove JD_TERMCAP
        * configure: regenerate with autoconf-2.61
        * src/Makefile.in: remove libtermcap linking


cp or rm does not necessarily reside in /bin.  If it does, /bin is 
in $PATH by convention.  In either case, hardcoding /bin/cp or /bin/rm 
is not a good idea.

Reproducible: Always

[Comment 1 Benda Xu 2014-12-08 03:49:26 UTC]

Created attachment 391196 [details, diff]
most-5.0.0a-donot-hardcode-path.patch

[Comment 2 Benda Xu 2014-12-08 03:49:47 UTC]

Created attachment 391198 [details, diff]
most-5.0.0a-no-explicit-termcap.patch

[Comment 3 Benda Xu 2014-12-08 03:53:14 UTC]

These two patches fix the build error on Prefix, where /bin/cp and /usr/share/terminfo may not exist on host.

[Comment 4 Justin Lecher (RETIRED) 2014-12-08 07:32:17 UTC]

Why are you patching Makefile.in instead of am?

[Comment 5 Benda Xu 2014-12-08 07:58:01 UTC]

Hello Justin,

(In reply to Justin Lecher from comment #4)
> Why are you patching Makefile.in instead of am?

There is no Makefile.am in src/

work/most-5.0.0a/src $ ls Makefile*
Makefile  Makefile.in  Makefile.w32

[Comment 6 Justin Lecher (RETIRED) 2014-12-08 08:07:32 UTC]

(In reply to Benda Xu from comment #5)
> Hello Justin,
> 
> (In reply to Justin Lecher from comment #4)
> > Why are you patching Makefile.in instead of am?
> 
> There is no Makefile.am in src/


Nice :/.

Anyways, do what ever you want to do. Just keep things working afterwards. And thanks for bringing that upstream as well.

[Comment 7 Benda Xu 2014-12-08 11:12:14 UTC]

(In reply to Justin Lecher from comment #6)
> Nice :/.
> 
> Anyways, do what ever you want to do. Just keep things working afterwards.
> And thanks for bringing that upstream as well.

Thanks Justin.  I have added myself to the shell-tools herd.

+  08 Dec 2014; Benda Xu <[e-mail]>
+  +files/most-5.0.0a-donot-hardcode-path.patch,
+  +files/most-5.0.0a-no-explicit-termcap.patch, most-5.0.0a.ebuild:
+  Fix build system regarding terminfo and cp/rm locations. Bug #531958