Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 531780 - dev-libs/libuv-1.0.1 version bump
Summary: dev-libs/libuv-1.0.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-06 08:17 UTC by Franz Trischberger
Modified: 2014-12-30 15:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Franz Trischberger 2014-12-06 08:17:02 UTC
libuv moved its github repo to libuv/libuv. Also API (VERSION_MAJOR updated from 0 to 1) changed, so  new SLOT  is needed.
I used the ebuild from libuv-0.11.29, applied the changes and it merged fine. But 1 test is failing: https://github.com/libuv/libuv/issues/40

Here is the ebuild diff:


--- /var/repositories/gentoo/dev-libs/libuv/libuv-0.11.29.ebuild        2014-08-29 04:01:06.000000000 +0200
+++ /var/repositories/ff2000/dev-libs/libuv/libuv-1.0.1.ebuild  2014-12-06 09:10:58.146080093 +0100
@@ -7,11 +7,11 @@
 inherit eutils autotools multilib-minimal
 
 DESCRIPTION="A new platform layer for Node"
-HOMEPAGE="https://github.com/joyent/libuv"
-SRC_URI="https://github.com/joyent/libuv/archive/v${PV}.tar.gz -> ${P}.tar.gz"
+HOMEPAGE="https://github.com/libuv/libuv"
+SRC_URI="https://github.com/libuv/libuv/archive/v${PV}.tar.gz -> ${P}.tar.gz"
 
 LICENSE="BSD BSD-2 ISC MIT"
-SLOT="0/11"
+SLOT="1/0"
 KEYWORDS="~amd64 ~arm ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux"
 IUSE="static-libs"
Comment 1 Franz Trischberger 2014-12-06 09:01:04 UTC
A little  analyzation of the test failure:
https://github.com/joyent/libuv/issues/1539#issuecomment-65890448
SHORT: also 0.11.29 fails that test, so no regression. Something breaks if libuv is not available as system library, so tests need to use libuv from current build.
Comment 2 Julian Ospald 2014-12-30 15:14:57 UTC
(In reply to Franz Fellner from comment #0)
> libuv moved its github repo to libuv/libuv. Also API (VERSION_MAJOR updated
> from 0 to 1) changed, so  new SLOT  is needed.
> I used the ebuild from libuv-0.11.29, applied the changes and it merged
> fine. But 1 test is failing: https://github.com/libuv/libuv/issues/40
> 
> Here is the ebuild diff:
> 
> 
> --- /var/repositories/gentoo/dev-libs/libuv/libuv-0.11.29.ebuild       
> 2014-08-29 04:01:06.000000000 +0200
> +++ /var/repositories/ff2000/dev-libs/libuv/libuv-1.0.1.ebuild  2014-12-06
> 09:10:58.146080093 +0100
> @@ -7,11 +7,11 @@
>  inherit eutils autotools multilib-minimal
>  
>  DESCRIPTION="A new platform layer for Node"
> -HOMEPAGE="https://github.com/joyent/libuv"
> -SRC_URI="https://github.com/joyent/libuv/archive/v${PV}.tar.gz ->
> ${P}.tar.gz"
> +HOMEPAGE="https://github.com/libuv/libuv"
> +SRC_URI="https://github.com/libuv/libuv/archive/v${PV}.tar.gz ->
> ${P}.tar.gz"
>  
>  LICENSE="BSD BSD-2 ISC MIT"
> -SLOT="0/11"
> +SLOT="1/0"
>  KEYWORDS="~amd64 ~arm ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux"
>  IUSE="static-libs"

That will cause horrible file collisions. SLOTs are meant for stuff that can be installed at the same time without file collisions or blockers.