It doesn't appear there has been any upstream updates in a while for libfprint but someone has taken commits by upstream after 0.5.1 and added support for VFS 0050 fingerprint reader in their own github repo. I will attach the patch for this. I would suggest the other patch that was added to this ebuild for VFS 5011 be integrated with this patch since it does not coincide with the latest commits from upstream. Reproducible: Always
Created attachment 390940 [details, diff] libfprint-0.5.1-add-new-drivers.patch
Created attachment 390944 [details] libfprint-0.5.1-r2.ebuild I removed the vfs5011 patch since it doesn't reconcile with upstream. I would suggest that you reconcile it and perhaps commit it to upstream and maybe also https://github.com/payden/libfprint.
0.5.1 and now 0.6.0 have been out for a while. Can we get a version bump for both sys-auth/libfprint and sys-auth/fprintd?
I'd skip this in favor of bug 553242.
Alas, a version bump does not help. Can't you just update this patch so it works with 0.6.0 too?
Better yet, why not use the fork that tracks upstream with this patch already built in? https://github.com/zemen/libfprint/commits/master Arch appears to do what I'm suggesting: https://aur4.archlinux.org/packages/libfprint-vfs0050/
Here's the patch for 0.6.0: https://github.com/zemen/libfprint/commit/23f1ef96dc612f80e5d7c9277b18d5973fc65cf6 Not sure why upstream still doesn't provide support for this fingerprint scanner.
(In reply to Matthew Schultz from comment #6) > Better yet, why not use the fork that tracks upstream with this patch > already built in? I don't like switching upstream while keeping the package name. I'm gonna the patch via USE=vanilla. Regarding the patch, the last Hunk inside libfprint/fprint-list-udev-rules.c also need previous one [1] [1] https://github.com/zemen/libfprint/commit/f1fdd71613a483e054cd11e19bdcfb49c95fa2cb
There's a nested comment in libfprint/drivers/vfs0050.h from line 341 to 381??
(In reply to Michael Weber from comment #9) > There's a nested comment in libfprint/drivers/vfs0050.h from line 341 to > 381?? Yeah I see that. If you look at the latest version of that file, it looks like it was removed.
(In reply to Matthew Schultz from comment #10) > (In reply to Michael Weber from comment #9) > > There's a nested comment in libfprint/drivers/vfs0050.h from line 341 to > > 381?? > > Yeah I see that. If you look at the latest version of that file, it looks > like it was removed. commit bc485e300f416a29765fc1a5bba0434027a4e6f7 Author: Michael Weber <xmw@gentoo.org> Date: Mon Aug 10 22:41:48 2015 +0200 sys-auth/libfprint: add support for vfs0050 scanner (bug 531698). Can you contact the original upstream and ask for them to include the scanners? It would be much simpler to have them maintain it instead of patching every next version bump. Please report back, if the new version works for you.
I can't seem to get github to cooperate with its compare function but if you clone the repo and run this, you get a better patch that works (includes all the latest changes and bug fixes for that driver and not just that one commit that added the driver): git diff bb66780cb58daf33d55524a9b434e218a991507c 62bb0228d655a80a3d39a2e1acf596ae166a5d7b > libfprint-0.6.0_vfs0050.patch
Created attachment 408804 [details, diff] libfprint-0.6.0_vfs0050.patch
Created attachment 408806 [details] libfprint-0.6.0.ebuild
Just to note, the original addition of the driver with that one patch did not work but I have tested the patch I just attached and verified that it works with my fingerprint reader.
I put the patch into my devspace due ~42kb size. Thanks for testing commit a70a2055a8dcfdfde4e69457f7b2192d50e64451 Author: Michael Weber <xmw@gentoo.org> Date: Tue Aug 11 22:17:48 2015 +0200 sys-auth/libfprint: revbump for new vfs0050 patch (bug 531698). Package-Manager: portage-2.2.20 sys-auth/libfprint/Manifest sys-auth/libfprint/libfprint-0.6.0-r1.ebuild sys-auth/libfprint/libfprint-0.6.0.ebuild
(In reply to Michael Weber from comment #16) > I put the patch into my devspace due ~42kb size. > Thanks for testing > > commit a70a2055a8dcfdfde4e69457f7b2192d50e64451 > Author: Michael Weber <xmw@gentoo.org> > Date: Tue Aug 11 22:17:48 2015 +0200 > > sys-auth/libfprint: revbump for new vfs0050 patch (bug 531698). > > Package-Manager: portage-2.2.20 > > sys-auth/libfprint/Manifest > sys-auth/libfprint/libfprint-0.6.0-r1.ebuild > sys-auth/libfprint/libfprint-0.6.0.ebuild I verified that -r1 works but why hasn't the ChangeLog been updated?
I have opened a bug to the main upstream to add support for this reader as well: https://bugs.freedesktop.org/show_bug.cgi?id=91616
(In reply to Matthew Schultz from comment #17) > I verified that -r1 works but why hasn't the ChangeLog been updated? 01:42:00 <@jmbsvicetto> chutzpah: we're currently just pushing the old changelogs into the rsync tree. AFAIK, we haven't created any script to push the git history into the changelogs (In reply to Matthew Schultz from comment #18) > I have opened a bug to the main upstream to add support for this reader as > well: Thanks
