Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 531266 - virtual/postgresql use deps are too strict
Summary: virtual/postgresql use deps are too strict
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 20:16 UTC by Mike Gilbert
Modified: 2014-12-01 12:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2014-11-30 20:16:55 UTC
virtual/postgresql currently forces the use flags on dev-db/postgresql to be set identically to the virtual. I do not believe this is necessary, and may cause some confusion.

For example, if the user has just "dev-db/postgresql server" in package.use and has installed dev-db/postgresql, the virtual will still try to pull in dev-db/postgresql-server because the server use flag has not been set on virtual/postgresql.

Please consider making the change below.

One possible problem would be if any packages depend on negated use flags (like virtual/postgresql[-threads]). If that is the case, consider making the change only for the "server" use flag.

Index: postgresql-9.4.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/virtual/postgresql/postgresql-9.4.ebuild,v
retrieving revision 1.1
diff -u -r1.1 postgresql-9.4.ebuild
--- postgresql-9.4.ebuild       2 Nov 2014 12:42:31 -0000       1.1
+++ postgresql-9.4.ebuild       30 Nov 2014 20:12:01 -0000
@@ -16,10 +16,10 @@
 DEPEND="
        || (
                (
-                       dev-db/postgresql-base:${SLOT}[kerberos=,ldap=,threads=]
+                       dev-db/postgresql-base:${SLOT}[kerberos?,ldap?,threads?]
                        server? ( dev-db/postgresql-server:${SLOT} )
                )
-               dev-db/postgresql:${SLOT}[kerberos=,ldap=,server=,threads=]
+               dev-db/postgresql:${SLOT}[kerberos?,ldap?,server?,threads?]
        )
 "
Comment 1 Aaron W. Swenson gentoo-dev 2014-12-01 12:32:07 UTC
We'll be starting the stabilization process in a few days for dev-db/postgresql. Once that's done, the virtuals will go away.

I agree that it's slightly inconvenient, but I don't want to do a revbump only to remove it a short time later.