Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53125 - xmmsctrl.h is not gcc 3.4 freindly when included in a C++ style...
Summary: xmmsctrl.h is not gcc 3.4 freindly when included in a C++ style...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 52215
  Show dependency tree
 
Reported: 2004-06-06 03:46 UTC by Malcolm Lashley (RETIRED)
Modified: 2004-06-15 20:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Gcc 3.4 patch to xmmsctrl.h header file (gcc-3.4.patch,306 bytes, patch)
2004-06-06 03:48 UTC, Malcolm Lashley (RETIRED)
Details | Diff
Patch for xmms ebuild to include gcc 3.4 fix. (xmms-1.2.10-r3.ebuild.patch,519 bytes, patch)
2004-06-06 03:53 UTC, Malcolm Lashley (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Malcolm Lashley (RETIRED) gentoo-dev 2004-06-06 03:46:35 UTC
Extra semicolon in xmmsctrl.h causes gcc 3.4 to choke when the header is included in a C++ compilation (for example superkaramba (Bug #52215)

Reproducible: Always
Steps to Reproduce:
1. emerge superkaramba
2.
3.

Actual Results:  
Build fails 

Expected Results:  
Applied attached patch ;-)
Comment 1 Malcolm Lashley (RETIRED) gentoo-dev 2004-06-06 03:48:54 UTC
Created attachment 32771 [details, diff]
Gcc 3.4 patch to xmmsctrl.h header file
Comment 2 Malcolm Lashley (RETIRED) gentoo-dev 2004-06-06 03:53:20 UTC
Created attachment 32772 [details, diff]
Patch for xmms ebuild to include gcc 3.4 fix.

The gcc 3.4 patch should presumably be rolled up into the gentoo xmms patches
tarball and the ebuild modified appropriately.
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2004-06-15 02:10:17 UTC
I'll get this in a revbump tomorrow
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-06-15 20:30:02 UTC
xmms-1.2.10-r4 includes the patch.