Bug 530430 – app-text/ebook-tools: make app-text/convertlit optional

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Nikoli 2014-11-24 16:47:55 UTC]

convertlit is used only in /usr/bin/lit2epub shell script. Both clit and lit2epub are not used in libepub.so. Please make lit2epub and app-text/convertlit dep optional.

P.S. Debian has both einfo and lit2epub in separate package:
https://packages.debian.org/sid/epub-utils

[Comment 1 Michael Palimaka (kensington) 2014-11-24 17:53:10 UTC]

How about converlit USE flag?

[Comment 2 Nikoli 2014-11-24 17:58:06 UTC]

Yes, adding USE flag seems best. But may be call it lit2epub?

[Comment 3 Nikoli 2015-04-27 09:22:06 UTC]

Created attachment 402102 [details, diff]
ebook-tools-0.2.2.ebuild.patch

[Comment 4 Nikoli 2015-04-27 09:48:57 UTC]

Description for USE flag:
"Enable support for converting LIT files to EPUB (using convlit and zip)."

[Comment 5 Karol Herbst 2015-04-27 10:17:48 UTC]

The question is: what happens if this dependency isn't installed. Will /usr/bin/lit2epub print errors or will it just fail?
It would make sense to not install this shell script if the USE flag is disabled, because we should not have a situation, where software fails and the user don't know why (in that case installing the dep is better than having such an optional dep)

[Comment 6 Nikoli 2015-04-27 10:28:33 UTC]

It is not installed in my system:
$ /usr/bin/lit2epub
Cannot find clit, please make sure it is in your PATH

lit2epub tool is not used anywhere in sources:
ebook-tools-0.2.2 $ grep -R lit2epub *
debian/control:  - lit2epub        : converts a LIT file to EPub (using clit).
INSTALL:To use the lit2epub script you also need to have:
src/tools/CMakeLists.txt:  install ( PROGRAMS lit2epub DESTINATION bin )

[Comment 7 . 2016-02-18 12:46:23 UTC]

I've solved it by creating a lit2epub USE flag, which prevents lit2epub from being installed when disabled. A sample ebuild can be found in my overlay: https://github.com/rindeal/gentoo-overlay/blob/master/app-text/ebook-tools/ebook-tools-0.2.2-r1.ebuild

[Comment 8 Johannes Huber (RETIRED) 2016-03-15 21:15:31 UTC]

I tested the bin lit2ebup without converlit installed, which makes it unusable. That makes no sense to make it optional. No thanks.

[Comment 9 . 2016-03-16 17:53:07 UTC]

Just apply the solution from comment #7. You're welcome.

[Comment 10 Johannes Huber (RETIRED) 2016-03-21 10:49:53 UTC]

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a926c800bfbb951cc31c691fb2ee30eb2bf1885

[Comment 11 . 2016-03-21 12:07:24 UTC]

And https://github.com/gentoo/gentoo/pull/1089 for completeness.