Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 530112 - =net-analyzer/goaccess-{0.8.5,0.9} version bump
Summary: =net-analyzer/goaccess-{0.8.5,0.9} version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vladimir Pavljuchenkov (SpiderX)
URL: http://goaccess.io/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-22 12:55 UTC by Jeroen Roovers (RETIRED)
Modified: 2016-08-06 09:43 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
goaccess-0.8.5.ebuild (goaccess-0.8.5.ebuild,1.05 KB, text/plain)
2015-02-17 12:01 UTC, Vladimir Pavljuchenkov (SpiderX)
Details
metadata for goaccess-0.8.5.ebuild (metadata.xml,1.00 KB, text/xml)
2015-02-17 12:01 UTC, Vladimir Pavljuchenkov (SpiderX)
Details
patch for goaccess-0.8.5.ebuild (goaccess-0.8.5-geoip-config.patch,476 bytes, patch)
2015-02-17 12:02 UTC, Vladimir Pavljuchenkov (SpiderX)
Details | Diff
goaccess-0.9.ebuild (goaccess-0.9.ebuild,1.06 KB, text/plain)
2015-04-17 16:19 UTC, Vladimir Pavljuchenkov (SpiderX)
Details
goaccess-0.9.ebuild (goaccess-0.9.ebuild,1.07 KB, text/plain)
2015-04-18 12:11 UTC, Nikoli
Details
go (goaccess-0.9.ebuild,1.07 KB, text/plain)
2015-04-26 17:45 UTC, Vladimir Pavljuchenkov (SpiderX)
Details
metadata for goaccess-0.9 (metadata.xml,990 bytes, text/xml)
2015-04-26 17:49 UTC, Vladimir Pavljuchenkov (SpiderX)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2014-11-22 12:55:39 UTC
New HOMEPAGE too.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-11-22 13:03:12 UTC
Also adds configure switches for tokyocabinet, zlib and bzip2 support.
Comment 2 Sebastian Pipping gentoo-dev 2015-02-15 22:17:38 UTC
Nikoli, any news?
Comment 3 Vladimir Pavljuchenkov (SpiderX) 2015-02-17 12:01:24 UTC
Created attachment 396698 [details]
goaccess-0.8.5.ebuild

For anyone who still waiting for maintainer :)
Comment 4 Vladimir Pavljuchenkov (SpiderX) 2015-02-17 12:01:52 UTC
Created attachment 396700 [details]
metadata for goaccess-0.8.5.ebuild
Comment 5 Vladimir Pavljuchenkov (SpiderX) 2015-02-17 12:02:09 UTC
Created attachment 396702 [details, diff]
patch for goaccess-0.8.5.ebuild
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2015-04-06 07:34:25 UTC
(In reply to SpiderX from comment #5)
> Created attachment 396702 [details, diff] [details, diff]
> patch for goaccess-0.8.5.ebuild

My guess is you're offering an ebuild to bump with -0.8.5 and you have made yourself out to be a substitute maintainer.  I suggest you email the lead of the proxy-maintainers herd on the basis of inaction on the part of the designated proxy maintainer.  However you have made an ebuild and all that goes with it for 0.8.5.  The bug was prompting for =net-analyzer/goaccess-0.9 version bump.  There is nothing I can commit for this package in this state.
Comment 7 Sebastian Pipping gentoo-dev 2015-04-06 13:00:41 UTC
(In reply to Ian Delaney from comment #6)
> The bug was prompting for
> =net-analyzer/goaccess-0.9 version bump.  There is nothing I can commit for
> this package in this state.

I bumped the title to 0.9 just yesterday.  If 0.8.5 is committable as is, please go ahead.  We can still bump to 0.9 after that.  Thanks!
Comment 8 Vladimir Pavljuchenkov (SpiderX) 2015-04-06 21:22:32 UTC
Ian Delaney

Yes, you are right.
I agree to be a proxy-maintainers for this ebuild.
If you could commit it, it would be great.

I will bump it to 0.9 soon.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2015-04-07 06:56:20 UTC
(In reply to SpiderX from comment #8)
> Ian Delaney
> 
> Yes, you are right.
> I agree to be a proxy-maintainers for this ebuild.
> If you could commit it, it would be great.
> 
> I will bump it to 0.9 soon.

Vlad with the unpronounceable sir name;

The patch you made is a 1 liner. In summary, use of a patch is advised but in the case of a 1 liner, a sed statement is 'lighter weight'.

sed -e s':/usr/local:/usr:' -i config/goaccess.conf || die

does the same

~/cvsPortage/gentoo-x86/net-analyzer/goaccess $ USE="btree debug geoip bzip2 unicode zlib" ebuild goaccess-0.8.5.ebuild clean install

>>> Completed installing goaccess-0.8.5 into /mnt/gen2/TmpDir/portage/net-analyzer/goaccess-0.8.5/image/

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   usr/bin/goaccess
ecompressdir: bzip2 -9 /usr/share/doc
ecompressdir: bzip2 -9 /usr/share/man

passes repoman checks
*goaccess-0.8.5 (07 Apr 2015)

  07 Apr 2015; Ian Delaney <idella4@gentoo.org> +goaccess-0.8.5.ebuild,
  metadata.xml:
  bump, wrt bug #530112, reset metadata.xml to substitute proxy maintainer

We have one version to bump but we also have a another issue. Displacing a maintainer is not a preferred option.  I suggest you, SpiderX, contact the initial maintainer and discuss whether he has lost interest in monitoring this or wishes to pursue maintaining. packages can have co-maintainers. Either works for us. Input is also welcome form mva and sping. This bug is still in progress
Comment 10 Vladimir Pavljuchenkov (SpiderX) 2015-04-17 16:19:36 UTC
Created attachment 401464 [details]
goaccess-0.9.ebuild

Ebuild for goaccess 0.9 is here.
Tested on x86 and amd64.
Please commit.

Also, I wrote a mail to the initial maintainer. I am waiting for his reply now.
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2015-04-18 09:20:32 UTC
(In reply to SpiderX from comment #10)
> Created attachment 401464 [details]
> goaccess-0.9.ebuild
> 
> Ebuild for goaccess 0.9 is here.
> Tested on x86 and amd64.
> Please commit.
> 

While this bug is assigned to a long standing dev in this field, I shall not here.
 This is a strange situation, a mix of 3 authorised personnel but I am the newest of all.  Perhaps after a 2 week timeout notification period.

> Also, I wrote a mail to the initial maintainer. I am waiting for his reply
> now.

Good
Comment 12 Nikoli 2015-04-18 12:11:25 UTC
Created attachment 401556 [details]
goaccess-0.9.ebuild

Vlad, checked your goaccess-0.9.ebuild, there are several bugs:

1) epatch_user is in src_configure instead of src_prepare
2) USE bzip2 and zlib should be part of USE btree. Also look at dev-db/tokyocabinet/tokyocabinet-1.4.48.ebuild: both bzip2 and zlib are not optional deps.
3) glib is used only when tokyocabinet is disabled.  Use 'objdump -p /usr/bin/goaccess|grep NEEDED|sort' for viewing what actually is linked.
4) No need to have 2 memhash and btree USE flags for one binary switch.

Did you verify that patches are not required anymore?
Comment 13 Vladimir Pavljuchenkov (SpiderX) 2015-04-26 17:45:18 UTC
Created attachment 402066 [details]
go

1) Indeed. Also epatch_user should be the last command in src_prepare section, because user should have a possibility to override everything in this section.

2)-4) Agree.

> Did you verify that patches are not required anymore?

Yes, package honors user's CFLAGS now.
Comment 14 Vladimir Pavljuchenkov (SpiderX) 2015-04-26 17:49:57 UTC
Created attachment 402068 [details]
metadata for goaccess-0.9

We have to update metadata due to use flag change.
Comment 15 Ian Delaney (RETIRED) gentoo-dev 2015-04-28 04:30:20 UTC
Final check this is ready for committing yes?
Comment 16 Nikoli 2015-04-29 14:36:26 UTC
Yes.
Comment 17 Vladimir Pavljuchenkov (SpiderX) 2015-04-29 14:41:17 UTC
It's ready.
Also we have to update 0.8.5, or we can keep it as is, and try to stabilize 0.9 in couple of weeks.
Comment 18 Ian Delaney (RETIRED) gentoo-dev 2015-04-29 22:50:27 UTC
The change in metadata re use flags is premature. As long as <=0.8.5 is present the flag memhash needs be in place. It can therefore come out on removal of those.

*goaccess-0.9 (29 Apr 2015)

  29 Apr 2015; Ian Delaney <idella4@gentoo.org> +goaccess-0.9.ebuild,
  metadata.xml:
  bump; adjust metadata.xml to accommodate changed flag, ebuild supplied by
  proxy maintainer in bug #530112

I suggest you supply a diff patch to effect the updating of goaccess-0.8.5.ebuild. Also consider which old versions can be purged.
*goaccess-0.5 (27 Jul 2012) is old.