Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 52930 - amarok-1.0-beta3 cjk patch
Summary: amarok-1.0-beta3 cjk patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Jon Hood (RETIRED)
URL: http://www.magiclinux.org
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2004-06-03 16:57 UTC by Jackey Yang ("timeout" in forum)
Modified: 2004-06-15 10:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
amarok-1.0-beta3-cjk.diff (amarok-1.0-beta3-cjk.diff,1.42 KB, patch)
2004-06-03 16:57 UTC, Jackey Yang ("timeout" in forum)
Details | Diff
amarok-1.0_beta3.ebuild (amarok-1.0_beta3.ebuild,1.10 KB, text/plain)
2004-06-03 16:58 UTC, Jackey Yang ("timeout" in forum)
Details
amarok-1.0_beta4.ebuild (amarok-1.0_beta4.ebuild,1.10 KB, text/plain)
2004-06-09 08:05 UTC, Jackey Yang ("timeout" in forum)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jackey Yang ("timeout" in forum) 2004-06-03 16:57:07 UTC
fix mp3 tag problem for cjk users

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jackey Yang ("timeout" in forum) 2004-06-03 16:57:47 UTC
Created attachment 32619 [details, diff]
amarok-1.0-beta3-cjk.diff
Comment 2 Jackey Yang ("timeout" in forum) 2004-06-03 16:58:50 UTC
Created attachment 32620 [details]
amarok-1.0_beta3.ebuild

add cjk USE flag
Comment 3 Jackey Yang ("timeout" in forum) 2004-06-03 17:00:32 UTC
5 mins work for me *^_^*
Comment 4 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-06-06 10:18:38 UTC
You should inherit eutils if you use epatch.  (You can run epatch
without eutils, but it is not recommended in current policy)

Also,

use cjk && epatch ${FILESDIR}/amarok-1.0-beta3-cjk.diff

line would be

use cjk && epatch ${FILESDIR}/${MY_P}-cjk.diff

as we don't like hardcoded version numbers.
Comment 5 Jackey Yang ("timeout" in forum) 2004-06-06 14:14:38 UTC
haha, ok man.
I am a newbie for ebuild, so i will try my best.
Thx for pointed out the problem.
Comment 6 Jeremy Huddleston (RETIRED) gentoo-dev 2004-06-07 19:25:41 UTC
Jon: see if youucan get this into the beta4 ebuild
Comment 7 Jackey Yang ("timeout" in forum) 2004-06-08 05:23:33 UTC
i will do that.
Comment 8 Jackey Yang ("timeout" in forum) 2004-06-08 05:27:37 UTC
Any Japanese, Chinese or Korean developer here?
I need some ppl test my cjk patch, such as knode, amarok and so on.
Comment 9 Jackey Yang ("timeout" in forum) 2004-06-09 08:05:21 UTC
Created attachment 32976 [details]
amarok-1.0_beta4.ebuild

my cjk patch is work for beta4 too.
Comment 10 Jon Hood (RETIRED) gentoo-dev 2004-06-15 10:08:06 UTC
updates now in portage, thanks!