Bug 528920 – sci-physics/root-5.34.18-r1 - .../work/root/core/base/src/TTimeStamp.cxx:819:13: error: ‘const tm_t’ has no member named ‘__tm_gmtoff’

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Guilherme Amadio 2014-11-11 13:44:44 UTC]

sci-physics/root-5.34.18-r1 fails to compile. See attached build log.

Reproducible: Always

[Comment 1 Guilherme Amadio 2014-11-11 13:45:06 UTC]

Created attachment 389072 [details]
build.log

[Comment 2 Guilherme Amadio 2014-11-11 13:46:21 UTC]

Relevant output is below:

x86_64-pc-linux-gnu-g++ -O2 -march=native -pipe -pipe -m64 -Wshadow -Wall -W -Woverloaded-virtual -fPIC -Iinclude -DR__HAVE_CONFIG -O2 -march=native -pipe   -pthread -o core/base/src/TObjString.o -c /var/tmp/portage/sci-physics/root-5.34.18-r1/work/root/core/base/src/TObjString.cxx
/var/tmp/portage/sci-physics/root-5.34.18-r1/work/root/core/base/src/TTimeStamp.cxx: In static member function ‘static void TTimeStamp::DumpTMStruct(const tm_t&)’:
/var/tmp/portage/sci-physics/root-5.34.18-r1/work/root/core/base/src/TTimeStamp.cxx:819:13: error: ‘const tm_t’ has no member named ‘__tm_gmtoff’
    tmstruct.__tm_gmtoff, tmstruct.__tm_zone);
             ^
/var/tmp/portage/sci-physics/root-5.34.18-r1/work/root/core/base/src/TTimeStamp.cxx:819:35: error: ‘const tm_t’ has no member named ‘__tm_zone’
    tmstruct.__tm_gmtoff, tmstruct.__tm_zone);
                                   ^
Makefile:686: recipe for target 'core/base/src/TTimeStamp.o' failed
make: *** [core/base/src/TTimeStamp.o] Error 1
make: *** Waiting for unfinished jobs....
 * ERROR: sci-physics/root-5.34.18-r1::gentoo failed (compile phase):

[Comment 3 Guilherme Amadio 2014-11-11 14:07:03 UTC]

The change below fixes the compilation error for me:

--- TTimeStamp.cxx.orig 2014-11-11 11:54:19.236116039 -0200
+++ TTimeStamp.cxx      2014-11-11 11:55:11.942118897 -0200
@@ -813,11 +813,7 @@
           tmstruct.tm_isdst);
 #if (defined(linux) && !defined(R__WINGCC)) || defined(R__MACOSX)
    printf(",\n      tm_gmtoff %6ld, tm_zone \"%s\"",
-#if defined(__USE_BSD) || defined(R__MACOSX)
    tmstruct.tm_gmtoff, tmstruct.tm_zone);
-#else
-   tmstruct.__tm_gmtoff, tmstruct.__tm_zone);
-#endif
 #endif
    printf(" }\n");
 }

[Comment 4 Chaserhkj 2014-11-25 08:15:20 UTC]

Please see https://sft.its.cern.ch/jira/browse/ROOT-6714

Upstream has fixed this issue in version 5.34.21, please consider a version bump.

[Comment 5 Guilherme Amadio 2014-11-25 14:58:39 UTC]

Yes, I confirmed that version 5.34.21 is not affected. Somebody needs to apply my patch above to version 5.34.18 and/or do a revision bump. The current package in the tree is broken.

[Comment 6 Andrew Savchenko 2014-11-25 22:40:51 UTC]

I'll bump package in a week or so. This is not as simple as it seems, because it is complicated and needs a lot of testing. Meanwhile you may try 6.x branch from science overlay (it will be bumped and added too in a while).

[Comment 7 Andrew Savchenko 2015-03-02 08:47:45 UTC]

root-5.34.26 is in tree.