Bug 528728 – net-misc/dhcpcd-ui compiled with qt4 has two desktop files

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description charles17 2014-11-09 13:34:00 UTC]

Created attachment 388936 [details]
emerge log of net-misc/dhcpcd-ui with qt4 USE flag/

>>> Completed installing dhcpcd-ui-0.7.4 into /var/tmp/portage/net-misc/dhcpcd-ui-0.7.4/image/

 * QA Notice: This package installs one or more .desktop files that do not
 * pass validation.
 * 
 *      /usr/share/applications/dhcpcd-gtk.desktop: error: value "GNOME;LXDE;MATE;XFCE;ROX;Cinnamon;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Cinnamon"; values extending the format should start with "X-"
 *      /usr/share/applications/dhcpcd-qt.desktop: error: value "KDE;LXQT;Razor;TDE;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "LXQT"; values extending the format should start with "X-"
 * 
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   usr/bin/dhcpcd-online
   usr/bin/dhcpcd-gtk
   usr/bin/dhcpcd-qt
ecompressdir: bzip2 -9 /usr/share/man

[Comment 1 Markos Chandras (RETIRED) 2014-11-09 21:18:02 UTC]

probably need to remove the gtk version when compiled with qt4

[Comment 2 Roy Marples 2014-11-10 09:22:18 UTC]

Looks like dhcpcd-gtk was installed as well.
To explicitly not install dhcpcd-gtk you need to do --without-gtk.
Ditto --without-qt when no qt use flag.

[Comment 3 tokiclover 2014-11-10 12:39:48 UTC]

This can be easily fixed with:
---
src_configure()
...
        $(use gtk || use gtk3 || echo '--without-gtk')
...
---
The issue is with the order of gtk/gtk3 (gtk3 can disable gtk and there is no way to fix it even by changing the order).

[Comment 4 tokiclover 2014-11-10 12:44:55 UTC]

Can you add that line Markos? (No need for a patch for an easy fix.)

[Comment 5 tokiclover 2014-11-10 12:46:38 UTC]

I forget to mention that, that line need to be placed after gtk/gtk3 lines of course.

[Comment 6 Markos Chandras (RETIRED) 2014-11-10 18:26:07 UTC]

(In reply to tokiclover from comment #3)
> This can be easily fixed with:
> ---
> src_configure()
> ...
>         $(use gtk || use gtk3 || echo '--without-gtk')
> ...
> ---
> The issue is with the order of gtk/gtk3 (gtk3 can disable gtk and there is
> no way to fix it even by changing the order).

I don't think that's complete. As Roy said, you need to do something similar for qt4

[Comment 7 Markos Chandras (RETIRED) 2014-11-10 18:26:44 UTC]

(In reply to tokiclover from comment #5)
> I forget to mention that, that line need to be placed after gtk/gtk3 lines
> of course.

I am not sure I get that. Does it really matter it lives?

[Comment 8 tokiclover 2014-11-10 19:57:48 UTC]

(In reply to Markos Chandras from comment #6)
> I don't think that's complete. As Roy said, you need to do something similar
> for qt4

There is no issue with qt related configuration because `$(use_with qt4 qt)' will append the necessary oposite option.

[Comment 9 tokiclover 2014-11-10 19:58:44 UTC]

(In reply to Markos Chandras from comment #7)
> I am not sure I get that. Does it really matter it lives?

Maybe not.

[Comment 10 Markos Chandras (RETIRED) 2014-11-10 20:10:12 UTC]

Ok I have applied the following patch

Index: dhcpcd-ui-0.7.4.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/dhcpcd-ui/dhcpcd-ui-0.7.4.ebuild,v
retrieving revision 1.1
diff -u -B -u -r1.1 dhcpcd-ui-0.7.4.ebuild
--- dhcpcd-ui-0.7.4.ebuild	9 Nov 2014 11:20:48 -0000	1.1
+++ dhcpcd-ui-0.7.4.ebuild	10 Nov 2014 20:08:56 -0000
@@ -46,6 +46,7 @@
 		$(usex gtk3 '--with-gtk=gtk+-3.0' '')
 		$(use_with qt4 qt)
 		$(use_enable libnotify notification)
+		$(use gtk || use gtk3 || echo '--without-gtk')
 	)
 	econf "${myeconfargs[@]}"
 }

Please next time attach the ebuild diff just to make sure we are on the same page.

+  10 Nov 2014; Markos Chandras <[e-mail]> dhcpcd-ui-0.7.4.ebuild:
+  Remove the gtk desktop file when compiled with Qt4 support. Bug #528728
+