Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 528642 - dev-libs/geoip-1.6.2 - geoipupdate.sh without -f does not update files that are not already installed
Summary: dev-libs/geoip-1.6.2 - geoipupdate.sh without -f does not update files that a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-08 12:26 UTC by Vicente Olivert Riera (RETIRED)
Modified: 2015-09-26 00:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vicente Olivert Riera (RETIRED) gentoo-dev 2014-11-08 12:26:36 UTC
Is supposed the /usr/sbin/geoipupdate.sh should install the file /usr/share/GeoIP/GeoIP.dat, but it doesn't.

localhost ~ # ls /usr/share/GeoIP/GeoIP.dat
ls: cannot access to /usr/share/GeoIP/GeoIP.dat: No such file or directory

localhost ~ # /usr/sbin/geoipupdate.sh
Updating GeoIP databases...

localhost ~ # ls /usr/share/GeoIP/GeoIP.dat
ls: cannot access to /usr/share/GeoIP/GeoIP.dat: No such file or directory
Comment 1 Cédric Krier gentoo-dev 2014-11-08 12:32:18 UTC
It needs to be run the first time with "-f" option.
Comment 2 Vicente Olivert Riera (RETIRED) gentoo-dev 2014-11-08 12:46:18 UTC
(In reply to Cédric Krier from comment #1)
> It needs to be run the first time with "-f" option.

Confirmed. That fixes the problem.

Perhaps you should modify the message at the pkg_postinst() function to add that information, or just run "/usr/sbin/geoipupdate.sh -f".
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-11-08 15:23:55 UTC
(In reply to Vicente Olivert Riera from comment #2)
> (In reply to Cédric Krier from comment #1)
> > It needs to be run the first time with "-f" option.
> 
> Confirmed. That fixes the problem.
> 
> Perhaps you should modify the message at the pkg_postinst() function to add
> that information, or just run "/usr/sbin/geoipupdate.sh -f".

Fixed. Maybe we could change the script so that if no database files are present, a full/forced update is done automatically.
Comment 4 . 2015-09-26 00:00:11 UTC
The current behaviour seems to me to be completely broken. Suppose you run it with the -f option, on successive calls what's the difference between the normal one and the forced one?

Either remove any checking and options and just do a full update, or implement checking for newer versions on server and do only partial updates on successive calls.