Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 528484 - sys-kernel/genkernel-3.4.51.* uses wrong cache path in src_install
Summary: sys-kernel/genkernel-3.4.51.* uses wrong cache path in src_install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-06 20:50 UTC by Ziga Boehm
Modified: 2017-09-07 19:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
genkernel-3.4.51.2.ebuild.patch (genkernel-3.4.51.2.ebuild.patch,495 bytes, patch)
2014-11-07 09:05 UTC, Ziga Boehm
Details | Diff
genkernel-3.4.51.2.ebuild.patch (genkernel-3.4.51.2.ebuild.patch,582 bytes, patch)
2014-11-08 22:05 UTC, Ziga Boehm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ziga Boehm 2014-11-06 20:50:33 UTC
GKDISTDIR variable inside the src_install function should be set to "/var/cache/genkernel/src" and not to "/usr/share/genkernel/distfiles/" as it is set currently (the comment before the line that sets the variable refers to the right path).

With package sources stored at the wrong location, genkernel is unable to compile any of the tools it might need (e.g. busybox) and exits with error, stating that missing package file(s) should be refetched.
Comment 1 Ziga Boehm 2014-11-07 09:05:24 UTC
Created attachment 388740 [details, diff]
genkernel-3.4.51.2.ebuild.patch

A patch to simplify this bug fix.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2014-11-07 21:13:22 UTC
You are right with the comment vs path mismatch, but it is the comment which is invalid:

$ wget http://distfiles.gentoo.org/distfiles/genkernel-3.4.51.2.tar.bz2
$ tar -xaf genkernel-3.4.51.2.tar.bz2
$ grep 'GK_SHARE' genkernel-3.4.51.2/genkernel.conf
# ${GK_SHARE}/${ARCH_OVERRIDE}/config.sh . The recommended value for -j
GK_SHARE="${GK_SHARE:-/usr/share/genkernel}"
DISTDIR="${GK_SHARE}/distfiles"
#DEFAULT_KERNEL_CONFIG="${GK_SHARE}/arch/%%ARCH%%/kernel-config"

So your patch would break the current working genkernel.

Also, the move to "/usr/share/genkernel" was a recent change, see:

commit 7a1a9d509e38219824676660f41cb4f097c470c4
Author: Robin H. Johnson <robbat2@gentoo.org>
Date:   Mon Jun 23 09:36:02 2014 -0700

    genkernel.conf: DISTDIR in /var/cache bad

    Move DISTDIR to /usr/share/genkernel/distfiles: /var/cache might be on
    tmpfs and wiped each boot.


...so this bug is probably invalid, but someone should fix the comment ;)
Comment 3 Ziga Boehm 2014-11-08 22:05:42 UTC
Created attachment 388904 [details, diff]
genkernel-3.4.51.2.ebuild.patch
Comment 4 Ziga Boehm 2014-11-08 22:06:12 UTC
Oh, you are right - I missed that DISTDIR in genkernel.conf also changed and therefore  I failed to update the latter the way I should.

Thank you for heads up regarding Robin's commit.

For convenience I attached a new patch which should fix the mentioned comment.
Comment 5 Ben Kohler gentoo-dev 2017-09-07 19:06:47 UTC
I believe this was fixed some time ago, please reopen if this still affects you with current stable version

Thanks