Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 526690 - app-text/goldendict-9999 ebuild improvements
Summary: app-text/goldendict-9999 ebuild improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nikoli
URL:
Whiteboard: [qt overlay]
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2014-10-25 00:37 UTC by wranz
Modified: 2014-11-02 06:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
goldendict 9999 ebuild (goldendict-9999.ebuild,1.28 KB, text/plain)
2014-10-25 00:38 UTC, wranz
Details
goldendict-9999.ebuild (goldendict-9999.ebuild,1.31 KB, text/plain)
2014-10-25 02:02 UTC, tman
Details
goldendict live ebuild (goldendict-9999.ebuild,1.30 KB, text/plain)
2014-10-30 11:16 UTC, wranz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description wranz 2014-10-25 00:37:51 UTC
goldendict is included in the portage tree but the current development version provides extended functionality

the ebuild is based on the qt overlay ebuild

Reproducible: Always
Comment 1 wranz 2014-10-25 00:38:33 UTC
Created attachment 387324 [details]
goldendict 9999 ebuild
Comment 2 tman 2014-10-25 01:52:34 UTC
maybe missing package depencies?

/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I/usr/include/qt4/QtHelp -I. -Iqtsingleapplication/src -I/usr/include/hunspell -Ibuild -Ibuild -o build/wordfinder.o wordfinder.cc
x86_64-pc-linux-gnu-g++ -c -march=corei7 -O2 -pipe -rdynamic -Wall -W -D_REENTRANT -DPROGRAM_DATA_DIR=\"/usr/share/goldendict/\" -DPROGRAM_VERSION=\"1.5.0+git\" -DMAKE_EXTRA_TIFF_HANDLER -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I/usr/include/qt4/QtHelp -I. -Iqtsingleapplication/src -I/usr/include/hunspell -Ibuild -Ibuild -o build/groupcombobox.o groupcombobox.cc
x86_64-pc-linux-gnu-g++ -c -march=corei7 -O2 -pipe -rdynamic -Wall -W -D_REENTRANT -DPROGRAM_DATA_DIR=\"/usr/share/goldendict/\" -DPROGRAM_VERSION=\"1.5.0+git\" -DMAKE_EXTRA_TIFF_HANDLER -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I/usr/include/qt4/QtHelp -I. -Iqtsingleapplication/src -I/usr/include/hunspell -Ibuild -Ibuild -o build/keyboardstate.o keyboardstate.cc
x86_64-pc-linux-gnu-g++ -c -march=corei7 -O2 -pipe -rdynamic -Wall -W -D_REENTRANT -DPROGRAM_DATA_DIR=\"/usr/share/goldendict/\" -DPROGRAM_VERSION=\"1.5.0+git\" -DMAKE_EXTRA_TIFF_HANDLER -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I/usr/include/qt4/QtHelp -I. -Iqtsingleapplication/src -I/usr/include/hunspell -Ibuild -Ibuild -o build/mouseover.o mouseover.cc
x86_64-pc-linux-gnu-g++ -c -march=corei7 -O2 -pipe -rdynamic -Wall -W -D_REENTRANT -DPROGRAM_DATA_DIR=\"/usr/share/goldendict/\" -DPROGRAM_VERSION=\"1.5.0+git\" -DMAKE_EXTRA_TIFF_HANDLER -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_SVG_LIB -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtWebKit -I/usr/include/qt4 -I/usr/include/qt4/QtHelp -I. -Iqtsingleapplication/src -I/usr/include/hunspell -Ibuild -Ibuild -o build/preferences.o preferences.cc
In file included from preferences.hh:6:0,
                 from preferences.cc:1:
helpwindow.hh:6:30: fatal error: QtHelp/QHelpEngine: No such file or directory
 #include <QtHelp/QHelpEngine>
                              ^
compilation terminated.
Makefile:2155: recipe for target 'build/preferences.o' failed
make: *** [build/preferences.o] Error 1
make: *** Waiting for unfinished jobs....
 * ERROR: app-text/goldendict-9999::lokal failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=app-text/goldendict-9999::lokal'`,
 * the complete build log and the output of `emerge -pqv '=app-text/goldendict-9999::lokal'`.
 * The complete build log is located at '/var/tmp/portage/app-text/goldendict-9999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/app-text/goldendict-9999/temp/environment'.
 * Working directory: '/var/tmp/portage/app-text/goldendict-9999/work/goldendict-9999'
 * S: '/var/tmp/portage/app-text/goldendict-9999/work/goldendict-9999'

>>> Failed to emerge app-text/goldendict-9999, Log file:

>>>  '/var/tmp/portage/app-text/goldendict-9999/temp/build.log'

 * Messages for package app-text/goldendict-9999:

 * ERROR: app-text/goldendict-9999::lokal failed (compile phase):
Comment 3 tman 2014-10-25 01:53:27 UTC
and make it also ~amd64 cuz is no stable version :)
Comment 4 tman 2014-10-25 02:02:54 UTC
Created attachment 387328 [details]
goldendict-9999.ebuild

modified ebuild with:

dev-qt/qthelp depencies && KEYWORDS="~amd64 ~x86"
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2014-10-27 14:36:05 UTC
It's a live ebuild, so keywords should always be KEYWORDS=""

Please provide a diff with the ebuild in qt overlay, and reasoning for your changes.
Comment 6 wranz 2014-10-30 11:15:13 UTC
--- /var/lib/layman/qt/app-text/goldendict/goldendict-9999.ebuild       2014-10-30 12:13:31.363427956 +0100
+++ goldendict-9999.ebuild      2014-10-30 12:13:01.586759892 +0100
@@ -3,7 +3,7 @@
 # $Header: $
 
 EAPI=5
-EGIT_REPO_URI="git://gitorious.org/goldendict/goldendict"
+EGIT_REPO_URI="https://github.com/goldendict/goldendict.git"
 LANGSLONG="ar_SA bg_BG cs_CZ de_DE el_GR lt_LT ru_RU zh_CN"
 
 inherit qt4-r2 git-r3
@@ -17,11 +17,13 @@
 IUSE="debug kde"
 
 RDEPEND=">=app-text/hunspell-1.2
-       dev-qt/qtsingleapplication
+       media-libs/libao
        media-libs/libogg
        media-libs/libvorbis
+       dev-libs/eb
        sys-libs/zlib
        x11-libs/libXtst
+       >=dev-qt/qthelp-4.5:4
        >=dev-qt/qtcore-4.5:4[exceptions]
        >=dev-qt/qtgui-4.5:4[exceptions]
        >=dev-qt/qtwebkit-4.5:4[exceptions]
@@ -33,11 +35,6 @@
 DEPEND="${RDEPEND}
        virtual/pkgconfig"
 
-PATCHES=(
-        "${FILESDIR}/${PN}-2602a03cd-gcc-4.7.patch"
-        "${FILESDIR}/${PN}-2602a03cd-qtsingleapplication-unbundle.patch"
-)
-
 src_prepare() {
        qt4-r2_src_prepare

It uses the correct dev repo from github as the repo the qt ebuild points to is outdated. It also updates the dependencies and removes the patches.
Comment 7 wranz 2014-10-30 11:16:31 UTC
Created attachment 387790 [details]
goldendict live ebuild
Comment 8 Michael Palimaka (kensington) gentoo-dev 2014-10-30 11:20:39 UTC
Is qtsingleapplication no longer used?
Comment 9 wranz 2014-10-30 12:54:00 UTC
no.
Comment 10 Davide Pesavento (RETIRED) gentoo-dev 2014-10-30 12:55:41 UTC
It's still there afaics.... so why did you remove the unbundling patch?
Comment 11 wranz 2014-10-30 14:43:53 UTC
it didn't apply clean and i don't get why one should link against this lib when it's already included in the sources
Comment 12 Michael Palimaka (kensington) gentoo-dev 2014-10-31 03:31:06 UTC
(In reply to wranz from comment #11)
> it didn't apply clean and i don't get why one should link against this lib
> when it's already included in the sources

See https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies for why it's a bad idea.
Comment 13 Ben de Groot (RETIRED) gentoo-dev 2014-11-02 06:48:02 UTC
Improvements committed and new patch rolled. Thanks!