Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 525908 - app-admin/lastpass should alternatively depend on www-client/firefox-bin (and probably more random web browsers)
Summary: app-admin/lastpass should alternatively depend on www-client/firefox-bin (and...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Göktürk Yüksek
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-19 21:31 UTC by Nick Brooker
Modified: 2016-06-23 04:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Brooker 2014-10-19 21:31:02 UTC
Just through laziness I use the precompiled firefox and lastpass wants to install firefox if you have the firefox use flag on.
Could it look for firefox-bin as well or make a firefox-bin use flag?

Thanks

Reproducible: Always

Steps to Reproduce:
emerge lastpass with firefox-bin installed and it will want to compile firefox.
Actual Results:  
tries to build firefox from source

Expected Results:  
see firefox-bin is installed and use that as dependency.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-19 21:39:59 UTC
Shouldn't web browser extensions be installed through the web browser in question, by the user in question?
Comment 2 Andrew Udvare 2014-10-19 22:24:42 UTC
(In reply to Jeroen Roovers from comment #1)
> Shouldn't web browser extensions be installed through the web browser in
> question, by the user in question?

That was considered by me in the original ebuild (where I did not install the Firefox extension but put the required plugin so) but the extension is perfectly disable-able in the user interface.

The extension is not useless without the native plugin but native support is not present without it of course. Copy and paste is the main feature that does not work without the native plugin.

Also, if you have multiple profiles (like me) the plugin gets added to all which is very useful IMO.
Comment 3 Andrew Udvare 2014-10-19 22:28:21 UTC
(In reply to Nick Brooker from comment #0)
> Just through laziness I use the precompiled firefox and lastpass wants to
> install firefox if you have the firefox use flag on.
> Could it look for firefox-bin as well or make a firefox-bin use flag?

I agree the ebuild should be modified to not require firefox but allow either firefox or firefox-bin (an easy change).

However, I do not know if the ebuild will not install the plugin in a recognised place for the binary version of Firefox. It installs the plugin like so:

/opt/lastpass/nplastpass64
/usr/lib64/firefox/browser/extensions/support@lastpass.com/
/usr/lib64/nsbrowser/plugins/libnplastpass64.so

Does the binary version of Firefox look at this plugin directory? I am pretty certain it installs itself in /opt/, where it might sandbox itself slightly and only look in /opt/firefox/browser/extensions instead. This is also not a hard modification to make in the ebuild but an extra detail.
Comment 4 Göktürk Yüksek archtester gentoo-dev 2016-01-11 09:44:55 UTC
(In reply to Andrew Udvare from comment #3)
> (In reply to Nick Brooker from comment #0)
> > Just through laziness I use the precompiled firefox and lastpass wants to
> > install firefox if you have the firefox use flag on.
> > Could it look for firefox-bin as well or make a firefox-bin use flag?
> 
> I agree the ebuild should be modified to not require firefox but allow
> either firefox or firefox-bin (an easy change).
> 
> However, I do not know if the ebuild will not install the plugin in a
> recognised place for the binary version of Firefox. It installs the plugin
> like so:
> 
> /opt/lastpass/nplastpass64
> /usr/lib64/firefox/browser/extensions/support@lastpass.com/
> /usr/lib64/nsbrowser/plugins/libnplastpass64.so
> 
> Does the binary version of Firefox look at this plugin directory? I am
> pretty certain it installs itself in /opt/, where it might sandbox itself
> slightly and only look in /opt/firefox/browser/extensions instead. This is
> also not a hard modification to make in the ebuild but an extra detail.

firefox-bin also uses '/usr/lib64/nsbrowser' but the extensions dir is '/opt/firefox/browser/extensions'. Looks like we will need a separate use flag for the -bin.
Comment 5 Göktürk Yüksek archtester gentoo-dev 2016-03-26 05:37:15 UTC
Starting with lastpass-4, the firefox plug-in can be directly downloaded from the website. The installation script does not install the xpi file anymore. I have proposed to drop firefox support because of this but added support for opera. See: https://github.com/gentoo/gentoo/pull/1139
Comment 6 Göktürk Yüksek archtester gentoo-dev 2016-06-23 04:03:12 UTC
app-admin/lastpass has been removed: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b65db1879b889506ad03826010e6d78117c451b1

please migrate to app-admin/lastpass-binary-component if applicable