Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 525648 - net-analyzer/nagvis should alternatively depend on net-analyzer/icinga2, fix incomplete sqlite/sqlite3 USE flag renaming
Summary: net-analyzer/nagvis should alternatively depend on net-analyzer/icinga2, fix ...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard: Pending removal: 2018-12-01
Keywords: PMASKED
Depends on: 477742
Blocks:
  Show dependency tree
 
Reported: 2014-10-17 10:15 UTC by Guido Jäkel
Modified: 2018-12-01 18:20 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Jäkel 2014-10-17 10:15:33 UTC
1.) The current ebuilds DEPEND on Nagios or Icinga1, but not on Icinga2
2.) Because the livestatus interface is build-in feature of Icinga2, the mk-livestatus should not be a dependency if Icinga2 is used.
3.) The useflag for sqlite3 was renamed to sqlite, which was the deal of #469538, but this was incomplete.



--- /usr/portage/net-analyzer/nagvis/nagvis-1.6.6.ebuild        2013-05-20 06:01:22.000000000 +0200
+++ nagvis-1.6.6-r1.ebuild      2014-10-17 09:40:18.135080000 +0200
@@ -16,17 +16,21 @@
 IUSE="apache2 automap"
 
 DEPEND=""
-RDEPEND="|| ( net-analyzer/nagios net-analyzer/icinga )
+# need either Nagios, Icinga or Icinga2
+# dont need mk-livestatus for Icinga2
+RDEPEND="|| ( net-analyzer/nagios net-analyzer/icinga net-analyzer/icinga2 )
        automap? ( >=media-gfx/graphviz-2.14 )
        apache2? ( dev-lang/php[apache2] )
-       net-analyzer/mk-livestatus
+       || ( net-analyzer/icinga2 net-analyzer/mk-livestatus )
        dev-lang/php[gd,nls,json,session,pdo,sqlite,sockets,mysql,unicode,xml]"
 
 need_php_httpd
 want_apache2
 
 pkg_setup() {
-       confutils_require_built_with_all dev-lang/php gd nls json session pdo sqlite3 sockets mysql unicode xml
+       # typo or useflag migration bug: s/sqlite/sqlite/g
+       # confutils_require_built_with_all dev-lang/php gd nls json session pdo sqlite3 sockets mysql unicode xml
+       confutils_require_built_with_all dev-lang/php gd nls json session pdo sqlite sockets mysql unicode xml
        depend.apache_pkg_setup
 }
Comment 1 Guido Jäkel 2014-10-17 11:35:21 UTC
In addition, I request a version bump to the current upstream stable 1.7.10

Beside of dealing with names of the Gentoo patches in files/, the following additional patch is needed for the ebuild (, because of a directory renaming upstream)

--- nagvis-1.6.6-r1.ebuild      2014-10-17 09:40:18.135080000 +0200
+++ nagvis-1.7.10.ebuild        2014-10-17 12:46:06.691314000 +0200
@@ -61,7 +61,8 @@
        fi
 
        insinto /etc/nagvis
-       doins -r etc/{conf.d,automaps,geomap,.htaccess,nagvis.ini.php-sample}
+       # 20141017/gj  upstream rename maps<automaps
+       doins -r etc/{conf.d,maps,geomap,.htaccess,nagvis.ini.php-sample}
        fowners apache:root /etc/nagvis
        fperms 0664 /etc/nagvis/nagvis.ini.php-sample
        dosym /etc/nagvis /usr/share/nagvis/etc


FYI: So far I got both versions of Nagvis (1.6.6 and 1.7.10) raw working using the included demo dataset. Next step will be to refer to Icinga2 data.
Comment 2 Brian Evans (RETIRED) gentoo-dev 2014-11-10 13:55:06 UTC
Actually, the confutils inherit and the whole pkg_setup function looks like it should be removed here.  No need to do things twice (RDEPEND and pkg_setup).
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-12-01 18:20:02 UTC
Removing wrt #477742.