Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524808 - sys-devel/patch-2.7.1-r3 stable request
Summary: sys-devel/patch-2.7.1-r3 stable request
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on: patch-2.7
Blocks:
  Show dependency tree
 
Reported: 2014-10-09 08:43 UTC by Spooky Ghost
Modified: 2015-02-20 16:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Spooky Ghost 2014-10-09 08:43:42 UTC
A kernel diff generated by git diff v3.16..v3.17 cannot be applied correctly as patch <2.7 does not handle symlink creation correctly.  An example part of the diff is:

diff --git a/drivers/gpu/drm/nouveau/core/include/nvif/unpack.h b/drivers/gpu/drm/nouveau/core/include/nvif/unpack.h
new file mode 120000
index 0000000..69d9929
--- /dev/null
+++ b/drivers/gpu/drm/nouveau/core/include/nvif/unpack.h
@@ -0,0 +1 @@
+../../../nvif/unpack.h
\ No newline at end of file


Reproducible: Always

Steps to Reproduce:
1. Create a kernel tree at 3.16
2. Generate a diff from git from 3.16 to 3.17 with git diff v3.16..v3.17
3. Apply patch to 3.16 tree with patch -p1 < diff_file
Actual Results:  
drivers/gpu/drm/nouveau/core/include/nvif/unpack.h is a normal file with contents ../../../nvif/unpack.h.


Expected Results:  
drivers/gpu/drm/nouveau/core/include/nvif/unpack.h is created as a symbolic link to ../../../nvif/unpack.h

The patch homepage http://savannah.gnu.org/forum/forum.php?forum_id=7361 indicates that release 2.7 should handle this correctly:

"Support for most features of the "diff --git" format, including renames and copies, permission changes, and symlink diffs. Binary diffs are not supported yet; patch will complain and skip them."

Performing the same operation with sys-devel/patch-2.7.1-r3 produces the correct result.