Created attachment 386172 [details] lxsession-0.5.0.ebuild http://git.lxde.org/gitweb/?p=lxde/lxsession.git;a=commit;h=759782371424fbe85cdc5b5e764839d7d898dc71 Release 0.5.0 -------------------------------------------------------------------- --- /usr/portage/lxde-base/lxsession/lxsession-0.4.9.2-r3.ebuild 2014-06-01 00:31:22.000000000 +0200 +++ /usr/local/portage/lxde-base/lxsession/lxsession-0.5.0.ebuild 2014-10-07 02:09:59.591104347 +0200 @@ -11,7 +11,7 @@ DESCRIPTION="LXDE session manager (lite version)" HOMEPAGE="http://lxde.sf.net/" -SRC_URI="mirror://sourceforge/lxde/${P}.tar.gz" +SRC_URI="mirror://sourceforge/lxde/${P}.tar.xz" LICENSE="GPL-2" KEYWORDS="~alpha ~amd64 ~arm ~ppc ~x86 ~arm-linux ~x86-linux" @@ -41,14 +41,6 @@ DOCS="AUTHORS ChangeLog README" src_prepare() { - # bug #488082 - epatch "${FILESDIR}"/${P}-makefile.patch - - # bug #497100 - epatch "${FILESDIR}"/${P}-configure.patch - - # bug #496880 - epatch "${FILESDIR}"/${P}-fix-logind-dbus-calls.patch eautoreconf } ------------------------------------------------------------- is eautoreconf there still needed?
Comment on attachment 386172 [details] lxsession-0.5.0.ebuild --- lxsession-0.4.9.2-r3.ebuild +++ lxsession-0.5.0.ebuild @@ -11,7 +11,7 @@ DESCRIPTION="LXDE session manager (lite version)" HOMEPAGE="http://lxde.sf.net/" -SRC_URI="mirror://sourceforge/lxde/${P}.tar.gz" +SRC_URI="mirror://sourceforge/lxde/${P}.tar.xz" LICENSE="GPL-2" KEYWORDS="~alpha ~amd64 ~arm ~ppc ~x86 ~arm-linux ~x86-linux" @@ -41,14 +41,6 @@ DOCS="AUTHORS ChangeLog README" src_prepare() { - # bug #488082 - epatch "${FILESDIR}"/${P}-makefile.patch - - # bug #497100 - epatch "${FILESDIR}"/${P}-configure.patch - - # bug #496880 - epatch "${FILESDIR}"/${P}-fix-logind-dbus-calls.patch eautoreconf }
LXSession 0.5.1 released. "The session manager for LXDE was in long development and it still is. Julien did a lot for it to make it better. It is far from perfection yet but it is usable again and we hope it is a bit better than it was before. Two releases in row – 0.5.0, then fast bugfix next one – 0.5.1."
With lxsession-0.5.1 I get: ** (lxpolkit:2057): WARNING **: Unable to register authentication agent: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent already exists for the given subject ** (polkit-gnome-authentication-agent-1:2033): WARNING **: Unable to register authentication agent: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent already exists for the given subject Cannot register authentication agent: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent already exists for the given subject
(In reply to jospezial from comment #3) > With lxsession-0.5.1 I get: > > ** (lxpolkit:2057): WARNING **: Unable to register authentication agent: > GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent > already exists for the given subject > > ** (polkit-gnome-authentication-agent-1:2033): WARNING **: Unable to > register authentication agent: > GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent > already exists for the given subject > Cannot register authentication agent: > GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: An authentication agent > already exists for the given subject I think this will fix the warning: http://git.lxde.org/gitweb/?p=lxde/lxsession.git;a=commit;h=486e8b5221d214a491ac41e8b0ee1adba8f0a8d6 Fix duplicate lxpolkit invocation by setting Hidden=true in lxpolkit.desktop. For me I simply disabled lxpolkit and policykit in lxsession autostart settings. lxpolkit is started anyways: Oct 22 16:47:12 bastellinux polkitd[1235]: Registered Authentication Agent for unix-session:/org/freedesktop/ConsoleKit/Session1 (system bus name :1.8 [lxpolkit], object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale de_DE.UTF-8) Can be that I have to enable it in lxsession autostart settings again after the patch?
http://blog.lxde.org/?p=1321 LXSession 0.5.2 released. December 3, 2014 LStranger After next round of bugfixes next version of LXDE session manager finally came to the release time. We all hope it is more stable and bugless now. New release tarball download link: lxsession-0.5.2.tar.xz – SHA1: 00d45cccbdd6fb05c46998671a7c12123a0a2179 Changes since previous release 0.5.1 (see git log for details): Corrected connect and emit signals for lxsession-db to fix hanging in some cases. Fixed duplicate lxpolkit invocation. Updated few translations. Added some environment variables for LXQt and Qt support. Fixed D-Bus string comparison in lxsession-logout. Added ESCAPE key to close the lxsession-logout menu. Created lock file to prevent more than one logout dialog. Using libunique for lxpolkit and lxclipboard, to avoid launching it twice. Fixed gtk3 compilation. Few small corrections in the Makefile. -------------------------------------------------- checking for DBUS... yes checking for UNIQUE... no configure: error: Package requirements (unique-1.0) were not met: No package 'unique-1.0' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables UNIQUE_CFLAGS and UNIQUE_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. configure:5545: checking for UNIQUE configure:5552: $PKG_CONFIG --exists --print-errors "unique-1.0" Package unique-1.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `unique-1.0.pc' to the PKG_CONFIG_PATH environment variable No package 'unique-1.0' found configure:5555: $? = 1 configure:5569: $PKG_CONFIG --exists --print-errors "unique-1.0" Package unique-1.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `unique-1.0.pc' to the PKG_CONFIG_PATH environment variable No package 'unique-1.0' found configure:5572: $? = 1 configure:5586: result: no No package 'unique-1.0' found configure:5602: error: Package requirements (unique-1.0) were not met: No package 'unique-1.0' found I tried with dev-libs/libunique-3.0.2:3 with /usr/lib64/pkgconfig/unique-3.0.pc but configure looks for unique-1.0.pc . With dev-libs/libunique-1.1.6-r1:1 all compiles fine. So we have a new dependency here. Calculating dependencies... done! [ebuild U ] lxde-base/lxsession-0.5.2::overlay_jl [0.5.1::overlay_jl] USE="nls upower" 0 KiB LXSession.................................... : Version 0.5.2 Prefix....................................... : /usr Sysconfdir................................... : /etc GTK support.................................. : yes GTK Cliboard build-in suport................. : no GTK Polkit-agent build-in suport............. : no Enable GTK3 support.......................... : no Enable debug................................. : no Man pages generation support................. : yes The binary will be installed in /usr/bin http://lxde.org/ Have fun! I think we need a gtk3 USE flag in the ebuild. Manipulating the other options would be nice too.
--- lxsession-0.5.1.ebuild +++ lxsession-0.5.2.ebuild @@ -26,7 +26,8 @@ sys-auth/polkit x11-libs/gtk+:2 x11-libs/libX11 - sys-apps/dbus" + sys-apps/dbus + dev-libs/libunique:1" RDEPEND="${COMMON_DEPEND} !lxde-base/lxsession-edit sys-apps/lsb-release
I can't see any problems in combination with dev-lang/vala-0.26.1:0.26 so I commented "VALA_MAX_API_VERSION to 0.22" out in my lxsession-0.5.2.ebuild
Works with dev-lang/vala-0.26.2 too.
Created attachment 395448 [details, diff] combined patch for a few issues There are a few more gotchas that need to be addressed upstream. This patch is a combination of https://sourceforge.net/p/lxde/patches/502/ (can confirm, though given some warnings, more fixes in the code might be necessary), https://sourceforge.net/p/lxde/patches/491/ (I don't think it ever happened to me yet, so someone should check if that really happens) and https://sourceforge.net/p/lxde/patches/504/ (well, this one is a bit of a WIP, as, for example, openbox blocks are a really bad hack, but the dbus-glib cleanup, while needing polish, is a welcome thing).
To clarify, the patch from comment 9 isn't really meant to be used - not without major cleanup - but it shows some of the problems/solutions of 0.5.2.
ping
(In reply to jospezial from comment #11) > ping Based on what Rafał said (and btw thanks for the investigation) I see no reason to bump to 0.5.2 just yet.
(In reply to Markos Chandras from comment #12) > (In reply to jospezial from comment #11) > > ping > > Based on what Rafał said (and btw thanks for the investigation) I see no > reason to bump to 0.5.2 just yet. We need a newer version (either 0.5.0... or 0.5.2) to let us drop oldest vala versions
lxsession-0.5.2 is now 8 month old and works great for me all the time without patches.
Any news on this? :/
(In reply to Pacho Ramos from comment #15) > Any news on this? :/ Given what happens, - or rather doesn't - in the repo, it seems lxsesion is facing death by lack of interest. Even in the repo, there aren't any commits fixing the mentioned problems. It seems lxde has pretty much exclusively moved towards the Qt branch.
Well, if you have a working local ebuild for this, I could commit it of course :/ I am seeing that most distributions are supplying 0.5.2 version, and in Fedora they are also applying this patches to that: http://pkgs.fedoraproject.org/cgit/rpms/lxsession.git/tree/
(In reply to Pacho Ramos from comment #17) > Well, if you have a working local ebuild for this, I could commit it of > course :/ > > I am seeing that most distributions are supplying 0.5.2 version, and in > Fedora they are also applying this patches to that: > http://pkgs.fedoraproject.org/cgit/rpms/lxsession.git/tree/ Depends on your definition of a working ebuild... Still, going by the bugzilla entry, http://pkgs.fedoraproject.org/cgit/rpms/lxsession.git/tree/lxsession-0.5.2-key2-null.patch might be the proper solution of at least the openbox problem. Also, would be nice if some one who actually knows vala would look at my dbus fix, cause if that dbus-lib dep is effectively bogus (as all hints toward), pruning it would be somewhat worthwhile.
...to clarify: that Fedora patch would supersede the two lxsession-0.5.2/lxsession/ entries in my patch.
[master ede6813] lxde-base/lxsession: Version bump (#524660) 6 files changed, 170 insertions(+) create mode 100644 lxde-base/lxsession/files/lxsession-0.5.2-fix-invalid-memcpy.patch create mode 100644 lxde-base/lxsession/files/lxsession-0.5.2-key2-null.patch create mode 100644 lxde-base/lxsession/files/lxsession-0.5.2-notify-daemon-default.patch create mode 100644 lxde-base/lxsession/files/lxsession-0.5.2-reload.patch create mode 100644 lxde-base/lxsession/lxsession-0.5.2.ebuild
There is a release 0.5.3 for lxsession which I needed for being able to suspend from the Logout screen. It seems that lxsession-0.5.2 still relies on sys-power/upower-pm-utils for that, which is now masked for removal from portage, with long-deprecated suspend and hibernate methods[1] that are not available in sys-power/upower. lxsession-0.5.3 uses Consolekit for power-related functions [2] and as I said, I can now suspend from the Logout screen again, so that seems to do help.. I'm using a local ebuild which is a copy of the 0.5.2 one except (1) the key2-null patch is now in upstream so I removed it and (2) I added 1004-Never-free-buffer-returned-by-gtk_entry_get_text.patch from Fedora[3]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1005234#c19 [2] https://github.com/lxde/lxsession/commit/3cdba6bbd47199232fd530f76474ee0b0d94a55a [3] https://src.fedoraproject.org/cgit/rpms/lxsession.git/tree/ --- lxsession-0.5.2.ebuild 2018-08-31 01:39:56.000000000 +0200 +++ lxsession-0.5.3.ebuild 2018-11-24 00:00:43.176575491 +0100 @@ -42,9 +42,9 @@ PATCHES=( # Fedora patches "${FILESDIR}"/${P}-reload.patch - "${FILESDIR}"/${P}-key2-null.patch "${FILESDIR}"/${P}-notify-daemon-default.patch "${FILESDIR}"/${P}-fix-invalid-memcpy.patch + "${FILESDIR}"/1004-Never-free-buffer-returned-by-gtk_entry_get_text.patch ) src_prepare() {
(In reply to Michael from comment #21) > There is a release 0.5.3 for lxsession which I needed for being able to > suspend from the Logout screen. It seems that lxsession-0.5.2 still relies > on sys-power/upower-pm-utils for that, which is now masked for removal from > portage, with long-deprecated suspend and hibernate methods[1] that are not > available in sys-power/upower. > > lxsession-0.5.3 uses Consolekit for power-related functions [2] and as I > said, I can now suspend from the Logout screen again, so that seems to do > help.. > > I'm using a local ebuild which is a copy of the 0.5.2 one except (1) the > key2-null patch is now in upstream so I removed it and (2) I added > 1004-Never-free-buffer-returned-by-gtk_entry_get_text.patch from Fedora[3]. > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1005234#c19 > [2] > https://github.com/lxde/lxsession/commit/ > 3cdba6bbd47199232fd530f76474ee0b0d94a55a > [3] https://src.fedoraproject.org/cgit/rpms/lxsession.git/tree/ > > > --- lxsession-0.5.2.ebuild 2018-08-31 01:39:56.000000000 +0200 > > +++ lxsession-0.5.3.ebuild 2018-11-24 00:00:43.176575491 +0100 > > @@ -42,9 +42,9 @@ > PATCHES=( > # Fedora patches > "${FILESDIR}"/${P}-reload.patch > - "${FILESDIR}"/${P}-key2-null.patch > "${FILESDIR}"/${P}-notify-daemon-default.patch > "${FILESDIR}"/${P}-fix-invalid-memcpy.patch > + > "${FILESDIR}"/1004-Never-free-buffer-returned-by-gtk_entry_get_text.patch > ) > > src_prepare() { I found a fork with a related patch in lxsession-logout.c https://github.com/saoded/lxsession/commit/df5fe409101c84285227ac329f97e16a09b76a31
