Bug 524636 – sci-mathematics/soplex-2.0.0 - a Linear Programming (LP) solver based on the revised simplex algorithm

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description unlord 2014-10-06 17:38:47 UTC]

An ebuild for the linear program (LP) solver SoPlex.

Reproducible: Always

[Comment 1 unlord 2014-10-06 17:39:38 UTC]

Created attachment 386140 [details]
soplex-2.0.0.ebuild

[Comment 2 unlord 2014-10-06 17:40:15 UTC]

Created attachment 386142 [details, diff]
files/2.0.0-sharedlib.patch

[Comment 3 Jeroen Roovers (RETIRED) 2014-10-06 17:52:39 UTC]

Comment on attachment 386140 [details]
soplex-2.0.0.ebuild

>EAPI=4

Why not 5?

>DESCRIPTION="SoPlex is a Linear Programming (LP) solver based on the revised
>simplex algorithm."

That should be a single line.

>HOMEPAGE="http://soplex.zib.de/"
>SRC_URI="http://soplex.zib.de/download/release/soplex-2.0.0.tgz"

http://soplex.zib.de/download/release/${P}.tgz or indeed
${HOMEPAGE}/download/release/${P}.tgz

>LICENSE="ZIB-ACADEMIC-LICENSE"

That's a new license. It should be attached to this bug report, and possibly reviewed on the gentoo-dev@ mailing list.

>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>IUSE="gmp static test zlib"

If you have to have USE=static, then:

>RDEPEND="gmp? ( dev-libs/gmp )
>	zlib? ( sys-libs/zlib )"

these should be dev-libs/gmp[static-libs] and sys-libs/zlib[static-libs].

>DEPEND="${RDEPEND}
>	test? ( <dev-lang/python-3 )"

You should use python-r1.eclass for that and make sure the test suite uses the correct executable. At the very least dev-lang/python:2.7 - use a SLOT instead of specifying the version.

>src_prepare() {
>	epatch ${FILESDIR}/2.0.0-sharedlib.patch

${FILESDIR} should be quoted.

>src_compile() {
>	local myopts
>	if ! use gmp; then
>		myopts="${myopts} GMP=false"
>	fi
>	if ! use zlib; then
>		myopts="${myopts} ZLIB=false"
>	fi
>	make ${myopts}
>
>	if use static; then
>		myopts="${myopts} SHARED=false"
>		make ${myopts}
>	fi

make -> emake, and also

emake \
    $(usex gmp '' GMP=false) \
    $(usex zlib '' ZLIB=false) \
    $(usex static '' SHARED=false)

is a lot neater and saves you from defining a variable.

>src_install()  {
>	newbin bin/soplex-${PV} soplex
>
>	make INSTALLDIR="${D}/usr" installheader

make -> emake

>	dolib.so lib/libsoplex-${PV}.so
>	dolib.so lib/libsoplex.so
>
>	if use static; then
>		dolib.a lib/libsoplex-${PV}.a
>		dolib.a lib/libsoplex.a

Oh, so now USE=static turns out to be equal to USE=static-libs? It shouldn't be called USE=static, then.

[Comment 4 Justin Lecher (RETIRED) 2014-10-06 18:32:09 UTC]

Would you like to send us a pull request for the science overlay via github?

[Comment 5 unlord 2014-10-06 18:53:51 UTC]

Created attachment 386148 [details]
ZIB-ACADEMIC-LICENSE

The ZIB ACADEMIC LICENSE from http://scip.zib.de/academic.txt

[Comment 6 unlord 2014-10-06 20:12:43 UTC]

Created attachment 386158 [details]
soplex-2.0.0.ebuild

Updated ebuild that addresses all of the comments above.

[Comment 7 unlord 2014-10-06 21:58:38 UTC]

Created attachment 386168 [details, diff]
files/2.0.0-sharedlib.patch