Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524616 - Stabilize =app-portage/cfg-update-1.8.9
Summary: Stabilize =app-portage/cfg-update-1.8.9
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Richard Freeman
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2014-10-06 11:18 UTC by Richard Freeman
Modified: 2015-03-02 09:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Freeman gentoo-dev 2014-10-06 11:18:35 UTC
This is new, but it is identical to 1.8.8 which has been ~arch for ages, except for adding a fix to a bash call which breaks with the shellshock fixes.  The current stable version is broken and needs to be removed.
Comment 1 kuzetsa CatSwarm (kuza for short) 2014-10-12 20:47:19 UTC
With cfg-update 1.8.7 I'm getting:

> * invalid key... try again: bash: readkey: command not found

repeatedly, like over and over...

1.8.9 or newer is needed to fix this bug I believe.

https://github.com/rich0/cfg-update/commit/b87b46465a291be8f4508826a5610d68decb4a9a#diff-e3d611238f15ce823a8ad932c7172765

^ The comment says it all:

> After security-updates to bash it's no longer possible to store
> functions in envirinment.  This patch replaces use of bash to read a
> single key from tty with the perl-module Term::ReadKey

---

(In reply to Richard Freeman from comment #0)
> This is new, but it is identical to 1.8.8 which has been ~arch for ages,
> except for adding a fix to a bash call which breaks with the shellshock
> fixes.  The current stable version is broken and needs to be removed.


Makes sense / Yes, I agree.

This is probably related to the fixes for shellshock.

In the meantime I'm adding:

<app-portage/cfg-update-1.8.9

to my

/etc/portage/package.mask
Comment 2 kuzetsa CatSwarm (kuza for short) 2014-10-12 23:50:28 UTC
(In reply to Sarah White from comment #1)
> With cfg-update 1.8.7 I'm getting:
> 
> > * invalid key... try again: bash: readkey: command not found
> 
> repeatedly, like over and over...
> 
> 1.8.9 or newer is needed to fix this bug I believe.
((...snip...))

Tested in the past couple hours:

Confirmed working.

The 1.8.9 version fixes this issue, and appears to be just as stable as the older versions which used the older shellshock-vulnerable routine.
Comment 3 Richard Freeman gentoo-dev 2014-11-02 02:14:36 UTC
Marked x86 as stable - current stable was broken anyway and I did get a test report.
Comment 4 Agostino Sarubbo gentoo-dev 2015-03-02 09:42:05 UTC
ppc stable. Closing.