Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 524374 - sys-fs/xfsprogs-3.2.1: stabilize
Summary: sys-fs/xfsprogs-3.2.1: stabilize
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2014-10-03 11:46 UTC by kfm
Modified: 2014-12-16 22:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kfm 2014-10-03 11:46:16 UTC
I think that xfsprogs-3.2 should be seriously considered for a round of stable keywording. Two reasons spring to mind.

The first reason is that it is needed in order to support the v5 filesystem format. As observed by Phoronix:

"The xfsprogs 3.2.0 supports creating the version 5 on-disk format for the XFS file-system. This new XFS format has "significant reliability enhancements" with meta-data CRCs, object back owner references, and better crash recovery reliability. With the upcoming Linux 3.15 kernel this XFS v5 on-disk format is now considered stable / ready for production workloads and lost its experimental marking just with 3.15-rc5."

Currently, it is not possible to take advantage of these features when creating a filesystem with Gentoo live media. Note that, by default, mkfs.xfs will not enable these features unless the user specifically requests it. For example:

  # mkfs.xfs -m crc=1,

These new features are very useful and most were introduced in Linux 3.10.

The second reason is that the tools are much more reliable. Recently, I had to recover a very large XFS filesystem which had experienced corruption. While the corruption was not especially serious, it was enough to prevent the filesystem from being mountable. In particular, the log could not be replayed.

What I discovered was that there was no way to use xfsrepair from xfsprogs-3.1 without running out of memory. In my case, it would always bail out after reaching the 11th allocation group:

  - agno = 11
  xfs_repair: libxfs_initbuf can't memalign 8192 bytes: Cannot allocate memory

Ultimately, I compiled a xfsprogs-3.2 statically and ran it from SystemRescueCd. With that, I recovered the filsystem without any issue and was subsequently able to mount it.
Comment 1 kfm 2014-10-03 11:47:26 UTC
Correction: "mkfs.xfs -m crc=1," should read "mkfs.xfs -m crc=1,finobt=1".
Comment 2 Markus Meier gentoo-dev 2014-10-22 19:21:42 UTC
arm stable
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-10-23 09:28:39 UTC
Stable for HPPA.
Comment 4 Agostino Sarubbo gentoo-dev 2014-10-30 14:07:04 UTC
amd64 stable
Comment 5 Agostino Sarubbo gentoo-dev 2014-10-31 15:59:02 UTC
ppc64 stable
Comment 6 Agostino Sarubbo gentoo-dev 2014-11-01 17:43:30 UTC
ppc stable
Comment 7 René Rhéaume 2014-11-02 00:43:29 UTC
Please note that bug 477758 still affects xfsprogs 3.2.1 . Where should I put the updated patches?
Comment 8 Agostino Sarubbo gentoo-dev 2014-11-02 08:54:29 UTC
alpha stable
Comment 9 Agostino Sarubbo gentoo-dev 2014-11-03 09:35:33 UTC
x86 stable
Comment 10 Agostino Sarubbo gentoo-dev 2014-11-04 09:20:43 UTC
sparc stable
Comment 11 Agostino Sarubbo gentoo-dev 2014-11-11 10:46:32 UTC
ia64 stable. Closing.
Comment 12 Anthony Ryan 2014-12-16 22:01:17 UTC
This stabilization was handled poorly, and it's largely the upstreams fault.

3.1.10 was the last stable version in the tree before this. 3.1.11 introduced deprecation warnings people should have seen for functionality to be removed in 3.2.1 and higher (note: they removed deprecated funcitonality in the 3.2.1 point release and not 3.2.0 release). People running stable versions skipped all versions with deprecation warnings and found functionality disappearing without explaination or notice.

After a discussion with some of the upstream developers, they have no intention of changing this approach and reserve the right to deprecate a feature in a point release and remove it in the next one (as long as there's approximately 12 months between those releases).

I can't think of a way this can be improved short of ensuring every release of this gets the full QA testing run and stabilization before the next point release (barring problems).