Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 523754 - net-dns/djbdns-1.05-r29 - allow epatch_user to patch man pages
Summary: net-dns/djbdns-1.05-r29 - allow epatch_user to patch man pages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-09-26 01:25 UTC by Alex Efros
Modified: 2014-10-02 22:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
djbdns-1.05-r29.ebuild.patch (djbdns-1.05-r29.ebuild.patch,344 bytes, patch)
2014-09-26 01:25 UTC, Alex Efros 		Details | Diff
djbdns-1.05-r30.ebuild (djbdns-1.05-r30.ebuild,4.27 KB, text/plain)
2014-09-27 21:05 UTC, Michael Orlitzky 		Details
srv_record_support.patch (srv_record_support.patch,5.30 KB, patch)
2014-09-27 21:06 UTC, Michael Orlitzky 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Efros 2014-09-26 01:25:34 UTC 
Created attachment 385478 [details, diff]
djbdns-1.05-r29.ebuild.patch

In djbdns $WORKDIR there are two subdirectories: djbdns-1.05 and djbdns-man.
$S by default set to $WORKDIR/djbdns-1.05, and epatch_user also run in that directory. Because of this it's impossible to apply user patches to man pages.
I think epatch_user should be run in $WORKDIR (patch for ebuild attached).
Comment 1 Michael Orlitzky gentoo-dev 2014-09-26 23:55:29 UTC 
I'm reluctant to move the epatch_user to $WORKDIR because it will break the bazillion patches floating around for djbdns. And in EAPI6, the default call to epatch_user will take place in src_prepare (i.e. in $S).

Would it be acceptable to unpack the man pages under djbdns-1.05/man instead?
Comment 2 Alex Efros 2014-09-27 00:35:43 UTC 
(In reply to Michael Orlitzky from comment #1)
> Would it be acceptable to unpack the man pages under djbdns-1.05/man instead?

Yeah, why not?
Comment 3 Michael Orlitzky gentoo-dev 2014-09-27 21:05:52 UTC 
Created attachment 385628 [details]
djbdns-1.05-r30.ebuild

How's this look?
Comment 4 Michael Orlitzky gentoo-dev 2014-09-27 21:06:11 UTC 
Created attachment 385630 [details, diff]
srv_record_support.patch
Comment 5 Alex Efros 2014-09-28 11:20:38 UTC 
Looks good and works for me, thanks.
Comment 6 Michael Orlitzky gentoo-dev 2014-10-02 22:23:38 UTC 
02 Oct 2014; Michael Orlitzky <mjo@gentoo.org> +djbdns-1.05-r30.ebuild,
+files/srv_record_support.patch:
Revbump to fix bugs #523754 and #523756.