Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 523662 - ~sys-apps/util-linux-2.24.1 with sys-libs/uclibc - define MS_PRIVATE and MS_REC
Summary: ~sys-apps/util-linux-2.24.1 with sys-libs/uclibc - define MS_PRIVATE and MS_REC
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-09-25 01:59 UTC by René Rhéaume
Modified: 2015-02-07 21:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
util-linux-2.24.1-uclibc.patch (util-linux-2.24.1-uclibc.patch,288 bytes, patch)
2014-09-25 02:00 UTC, René Rhéaume
Details | Diff
ebuild patch (util-linux-2.24.1-r3.ebuild.patch,445 bytes, patch)
2014-09-25 02:03 UTC, René Rhéaume
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René Rhéaume 2014-09-25 01:59:53 UTC
util-linux 2.24.1 cannot be compiled as is on uclibc, because the relatively recent mount flags MS_PRIVATE and MS_REC ar not defined in its headers. However a copy of the flag defifition is defined inside the source distribution, so we can use it.

Reproducible: Always

Steps to Reproduce:
1. Install lilblue
2. emerge -1 util-linux
3.
Actual Results:  
emake failed

Expected Results:  
util-linux updated on system
Comment 1 René Rhéaume 2014-09-25 02:00:43 UTC
Created attachment 385418 [details, diff]
util-linux-2.24.1-uclibc.patch
Comment 2 René Rhéaume 2014-09-25 02:03:07 UTC
Created attachment 385420 [details, diff]
ebuild patch
Comment 3 SpanKY gentoo-dev 2014-09-26 21:41:37 UTC
Comment on attachment 385418 [details, diff]
util-linux-2.24.1-uclibc.patch

there's no need to make it depend on __UCLIBC__

we should also look at updating uClibc
Comment 4 René Rhéaume 2014-09-28 22:49:53 UTC
(In reply to SpanKY from comment #3)
> there's no need to make it depend on __UCLIBC__
Which means, removing the #ifdef from the patch?
Comment 5 Anthony Basile gentoo-dev 2014-09-29 00:36:14 UTC
It should be sufficient to backport http://git.uclibc.org/uClibc/commit/include/sys/mount.h?id=76ff037059f6d387bde9d540f7e27a2b376d7cd7 to the 0.9.33 branch and include it in the next patchset with a bump.
Comment 6 Anthony Basile gentoo-dev 2014-09-29 00:39:38 UTC
(In reply to Anthony Basile from comment #5)
> It should be sufficient to backport
> http://git.uclibc.org/uClibc/commit/include/sys/mount.
> h?id=76ff037059f6d387bde9d540f7e27a2b376d7cd7 to the 0.9.33 branch and
> include it in the next patchset with a bump.

Actually it is in the 0.9.33 branch already.  We just need it in the patchset pulled down by the ebuild.
Comment 7 Anthony Basile gentoo-dev 2015-02-07 21:24:13 UTC
I checked and this is fixed.