Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 52347 - app-arch/advancecomp-1.10 works on amd64
Summary: app-arch/advancecomp-1.10 works on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 All
: Lowest enhancement
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-29 06:43 UTC by Ralf Schmelter
Modified: 2004-05-29 17:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Schmelter 2004-05-29 06:43:25 UTC
Please add "~amd64" to the KEYWORDS for app-arch/advancecomp-1.10.

There is a remaining not critical problem with handling filenames on probably all 64bit platforms, which can be fixed with the patch below.
diff -ruNd advancecomp-1.10.orig/utility.cc advancecomp-1.10/utility.cc
--- advancecomp-1.10.orig/utility.cc	2004-04-06 20:02:25.000000000 +0200
+++ advancecomp-1.10/utility.cc	2004-05-29 17:33:00.098153880 +0200
@@ -416,7 +416,7 @@
 {
 	ostringstream os;
 
-	unsigned pos = path.rfind('.');
+	string::size_type pos = path.rfind('.');
 
 	if (pos == string::npos) 
 		os << path << ".";
@@ -433,7 +433,7 @@
  */
 string file_dir(const string& path) throw ()
 {
-	unsigned pos = path.rfind('/');
+	string::size_type pos = path.rfind('/');
 	if (pos == string::npos) {
 		return "";
 	} else {
@@ -446,7 +446,7 @@
  */
 string file_name(const string& path) throw ()
 {
-	unsigned pos = path.rfind('/');
+	string::size_type pos = path.rfind('/');
 	if (pos == string::npos) {
 		return path;
 	} else {
@@ -459,7 +459,7 @@
  */
 string file_basepath(const string& path) throw ()
 {
-	unsigned dot = path.rfind('.');
+	string::size_type dot = path.rfind('.');
 	if (dot == string::npos)
 		return path;
 	else
@@ -472,7 +472,7 @@
 string file_basename(const string& path) throw ()
 { 
 	string name = file_name(path);
-	unsigned dot = name.rfind('.');
+	string::size_type dot = name.rfind('.');
 	if (dot == string::npos)
 		return name;
 	else
@@ -485,7 +485,7 @@
 string file_ext(const string& path) throw ()
 { 
 	string name = file_name(path);
-	unsigned dot = name.rfind('.');
+	string::size_type dot = name.rfind('.');
 	if (dot == string::npos)
 		return "";
 	else
Comment 1 Danny van Dyk (RETIRED) gentoo-dev 2004-05-29 17:57:12 UTC
In CVS now, thanks!