dev-python/discogs-client 2.0.2 has been released and is required for the latest version of media-sound/beets. Renaming the ebuild and removing the README.patch works fine. Reproducible: Always
Created attachment 385130 [details, diff] discogs-client-2.0.2.patch Patch for the 2.0.2 ebuild. I removed the python_test() function as the test_discogs_client.py file was removed in this version.
(In reply to int.teo from comment #1) > Created attachment 385130 [details, diff] [details, diff] > discogs-client-2.0.2.patch > > Patch for the 2.0.2 ebuild. I removed the python_test() function as the > test_discogs_client.py file was removed in this version. This is NOT good. Sadly the upstream maintainers do this by mistake due, to my surprise, to their own limited mastery over making tarballs. Prompt him / them to put it back and I shall consider the bump. I note SRC_URI="https://github.com/discogs/${PN/-/_}/archive/v${PV}.tar.gz -> ${P}.tar.gz" which is even worse. Normally the tarball in pypi is incomplete but the tarball he put in the home repo is seemingly incomplete. It happens. Unless he states clearly he really didn't want it in, I presume he missed it, though I may be wrong.
Created attachment 385762 [details, diff] discogs-client-2.0.2.patch Hi Ian, in https://github.com/discogs/discogs_client/pull/19 it is stated that the doctest is dropped and replaced by a proper test suite though I wasn't able to understand how to use the tests subdir. After doing some reading about unittest I managed to create a new patch with a python_test. I cannot test pypy as I no longer have a gentoo box and testing use flags in a sabayon box isn't fun.
In the end; PYTHON_COMPAT had cruft needing removing addition of dev-python/oauth2 killed off adding py3 support The patch is now both superfluous with dropping of test_discogs_client.py While your version of the test phase works, it can be reduced to the 1 line "${PYTHON}" -m unittest discover || die "Tests failed under ${EPYTHON}" and achieve the same functionality *discogs-client-2.0.2 (30 Sep 2014) 30 Sep 2014; Ian Delaney <idella4@gentoo.org> +discogs-client-2.0.2.ebuild: bump; clean old python impls, update deps, upgrade test phase, based on patch by F. Henze from, and closes, Bug #523226 This is 'basic' bump however the source has discogs_client docs examples LICENSE README.mkd requirements.txt setup.py There's a doc build AND examples. These warrant 2 extra additions to the ebuild, each with a use flag. Do we want them?
Both doc and examples folders are empty, I don't see the point in having USE flags for those. Also dev-python/oauth2 is now needed for discogs-client why should it be removed?
dev-python/discogs-client-2.2.1 is in tree and tests pass. I'll close this.
