Created attachment 384920 [details, diff] include_unistd.patch Following bug #522180 I've wanted to check previous stable version, 2.2.1. And find it uncompillable. First error: [ 75%] Building CXX object src/CMakeFiles/tora.dir/toeventquery.o cd /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build/src && /usr/bin/x86_64-pc-linux-gnu-g++ -DCMAKE_BUILD -DDBLINK -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_UNISTD_H -DOTL_ORA11G -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_SQL_LIB -DQT_THREAD_LIB -DQT_XML_LIB -DTOMONOLITHIC -DNDEBUG -march=native -O2 -pipe -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build/src -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem /usr/include/qt4/QtXml -isystem /usr/include/qt4/QtSql -isystem /usr/include/qt4/QtNetwork -isystem /usr/include/qt4/QtCore -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1 -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/Qt3Support -I/usr/share/qt4/mkspecs/default -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/loki/include -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/otl -I/usr/lib64/oracle/11.2.0.4/client/rdbms/public -I/usr/include/qt4/Qsci -DTOVERSION=\"2.1.1\" -DDEFAULT_PLUGIN_DIR=\"/usr/share/tora/\" -DQT -DSCI_LEXER -o CMakeFiles/tora.dir/toeventquery.o -c /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/toeventquery.cpp /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/toextract.cpp: In member function ‘QString toExtract::generateHeading(const QString&, std::list<QString, std::allocator<QString> >&)’: /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/toextract.cpp:685:27: error: ‘gethostname’ was not declared in this scope make[2]: *** [src/CMakeFiles/tora.dir/toextract.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build' make[1]: *** [src/CMakeFiles/tora.dir/all] Error 2 make[1]: Leaving directory `/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build' make: *** [all] Error 2 emake failed For details see upstream bug: http://sourceforge.net/p/tora/bugs/853/ Was fixed by provided patch (see attached include_unistd.patch). The second error: [ 81%] Building CXX object src/CMakeFiles/tora.dir/tooracleextract.o cd /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build/src && /usr/bin/x86_64-pc-linux-gnu-g++ -DCMAKE_BUILD -DDBLINK -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_UNISTD_H -DOTL_ORA11G -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_SQL_LIB -DQT_THREAD_LIB -DQT_XML_LIB -DTOMONOLITHIC -DNDEBUG -march=native -O2 -pipe -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build/src -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src -isystem /usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem /usr/include/qt4/QtXml -isystem /usr/include/qt4/QtSql -isystem /usr/include/qt4/QtNetwork -isystem /usr/include/qt4/QtCore -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1 -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/Qt3Support -I/usr/share/qt4/mkspecs/default -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/loki/include -I/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/otl -I/usr/lib64/oracle/11.2.0.4/client/rdbms/public -I/usr/include/qt4/Qsci -DTOVERSION=\"2.1.1\" -DDEFAULT_PLUGIN_DIR=\"/usr/share/tora/\" -DQT -DSCI_LEXER -o CMakeFiles/tora.dir/tooracleextract.o -c /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/tooracleextract.cpp /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/tooracleconnection.cpp: In member function ‘virtual QString toOracleProvider::oracleConnection::version(toConnectionSub*)’: /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/tooracleconnection.cpp:873:37: error: cannot call constructor ‘QString::QString’ directly [-fpermissive] /var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1/src/tooracleconnection.cpp:873:37: error: for a function-style cast, remove the redundant ‘::QString’ [-fpermissive] make[2]: *** [src/CMakeFiles/tora.dir/tooracleconnection.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build' make[1]: *** [src/CMakeFiles/tora.dir/all] Error 2 make[1]: Leaving directory `/var/tmp/portage/dev-db/tora-2.1.1/work/tora-2.1.1_build' make: *** [all] Error 2 emake failed For details see upstream bug: http://sourceforge.net/p/tora/bugs/802/ Was fixed by tora-qt.patch. After building tora-2.2.1 with these patches (applied similiarly to user_patch feature): 1. Create bashrc file for tora-2.2.1 $ cat /etc/portage/env/dev-db/tora-2.1.1 pre_src_prepare () { EPATCH_SOURCE="/etc/portage/patches.rc/$CATEGORY/$PN/" \ EPATCH_SUFFIX="patch" \ EPATCH_FORCE="yes" epatch } 2. Create special directory for patches: # mkdir -p /etc/portage/patches.rc/dev-db/tora 3. Place these two patches into created on step 2 directory. I've find, that this version misses desktop integration files, present in 2.2.3: /usr/share/pixmaps/tora.xpm /usr/share/applications/tora.desktop But it don't crashes on closing tab like last stable version. I use: [I] dev-qt/qtcore Available versions: (4) 4.8.5-r1 4.8.5-r2 (5) [M]~5.3.1-r3^t {aqua debug +exceptions +glib iconv icu pch qt3support ssl test} Installed versions: 4.8.5-r2(4)(10:21:12 22.07.2014)(exceptions glib iconv qt3support ssl -aqua -debug -icu -pch) Homepage: https://qt-project.org/ Description: Cross-platform application development framework $ einfo Portage 2.2.8-r1 (default/linux/amd64/13.0, gcc-4.7.3, glibc-2.19-r1, 3.12.21-aufs-r1 x86_64) ================================================================= System uname: Linux-3.12.21-aufs-r1-x86_64-AMD_Athlon-tm-_II_X2_250_Processor-with-gentoo-2.2 KiB Mem: 1794620 total, 25180 free KiB Swap: 8000364 total, 7848304 free Timestamp of tree: Tue, 16 Sep 2014 05:15:01 +0000 ld GNU ld (GNU Binutils) 2.23.2 app-shells/bash: 4.2_p45 dev-java/java-config: 2.2.0 dev-lang/python: 2.7.7, 3.3.5-r1 dev-util/cmake: 2.8.12.2-r1 dev-util/pkgconfig: 0.28-r1 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.12.4 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6, 1.12.6, 1.13.4 sys-devel/binutils: 2.23.2 sys-devel/gcc: 4.7.3-r1 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4.2-r1 sys-devel/make: 3.82-r4 sys-kernel/linux-headers: 3.13 (virtual/os-headers) sys-libs/glibc: 2.19-r1 Repositories: gentoo local_hdd ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /etc/env.d /usr/share/gnupg/qualified.txt /var/bind" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--ask --verbose --autounmask=n" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs buildsyspkg config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles merge-sync metadata-transfer news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/ ftp://mirror.yandex.ru/gentoo-distfiles/ http://ftp.corbina.net/pub/Linux/gentoo/ ftp://ftp.corbina.net/pub/Linux/gentoo/" LANG="ru_RU.utf8" LC_ALL="" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage/gentoo" PORTDIR_OVERLAY="/usr/portage/local" USE="X a52 ac3 acl alsa amd64 avi berkdb bold bzip2 cdr cli consolekit cracklib crypt cups cxx dbus djvu dri dvd flac fortran gdbm gif gtk iconv inotify jpeg jpeg2k lock mmx modules mp3 multilib ncurses nls nptl ogg openmp pam pcre pdf png policykit qt3support readline session sse sse2 ssl tcpd thunar tiff udev udisks unicode utf8 vorbis xcb xulrunner zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="ru ru_RU" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-4" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby20" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON
Created attachment 384922 [details, diff] tora-qt.patch
Wouldn't both those have been fixed in newer versions already?
(In reply to Jeroen Roovers from comment #2) > Wouldn't both those have been fixed in newer versions already? Newer versions of TOra (=dev-db/tora-2.1.3-r{1,2,3}) builds OK without applying these patches.
One more improvement: =dev-db/tora-2.1.1 doesn't install *.desktop file (and icon). But for integration with DE it's… very useful thing. The ones could be get from current SVN-trunk (for example tora-3.0.0_pre20140928) and copied into ${FILESDIR}. For current revision I use custom bashrc function to install them: post_src_install() { doicon /etc/portage/files/$CATEGORY/${PN}/${PN}.xpm || die domenu /etc/portage/files/$CATEGORY/${PN}/${PN}.desktop || die }
Created attachment 385800 [details, diff] tora-2.1.1-ext-loki.patch Ops. Bug #383109 fits 2.1.1 together with 2.1.3. So, dev-db/tora-2.1.1-r1 must be built with dev-libs/ferrisloki. Attaching proper patch file.
Following https://bugs.gentoo.org/show_bug.cgi?id=523262#c7 first revision of dev-db/tora-2.1.1 also needs in some correction of dependencies: 1. Change dev-db/postgresql-server to dev-db/postgresql-base. 2. Remove Oracle's text client dev-db/oracle-instantclient-sqlplus.
Tora 2.1.1 was dropped from tree some time ago
