Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 522934 - eutils.eclass: EPATCH_USER_EXCLUDE ignored when EPATCH_EXCLUDE not set
Summary: eutils.eclass: EPATCH_USER_EXCLUDE ignored when EPATCH_EXCLUDE not set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-16 09:57 UTC by Pavel Šimerda
Modified: 2014-09-19 17:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Šimerda 2014-09-16 09:57:58 UTC 
I wanted to use EPATCH_USER_EXCLUDE="*" to disable user patching but it wouldn't work.

There are bugs in eutils.eclass which result in rendering EPATCH_EXCLUDE and especially EPATCH_USER_EXCLUDE not usable from the command line at all.

The first bug is equivalent to old bug #439402, where EPATCH_EXCLUDE given from the command line is overriden by:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/eutils.eclass?revision=1.436&view=markup#l333

The second bug was introduced with EPATCH_USER_EXCLUDE (also see bug #439402) and it is the fact that EPATCH_USER_EXCLUDE is not being used when EPATCH_EXCLUDE is not set, see:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/eutils.eclass?revision=1.436&view=markup#l492

Both should be easy to fix (I can provide a patch if requested). For the first one, there's no workaround except changing the respective line in portage wich gets overwritten with the next sync, for the second one, it's possible to use EPATCH_EXCLUDE="xxx" to provide bogus data.
Comment 1 Pavel Šimerda 2014-09-16 10:04:04 UTC 
I seem to have misread the explanation in bug #439402 so for me it's good enough to fix the second bug. Two separate conditions must be used (if any) to solve the second issue.