Bug 522368 – dev-util/cppcheck-1.65 builds/links against externals/tinyxml/ despite cppcheck-1.65-tinyxml2.patch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeroen Roovers (RETIRED) 2014-09-08 10:00:18 UTC]

Created attachment 384386 [details]
dev-util:cppcheck-1.65:20140908-095448.log

If you add an rm -r externals in src_prepare(), you'll see the shipped tinyxml2 still gets built through lib/Makefile and gui/Makefile.

[Comment 1 Jeroen Roovers (RETIRED) 2014-09-08 10:00:59 UTC]

Comment on attachment 384386 [details]
dev-util:cppcheck-1.65:20140908-095448.log

--- cppcheck-1.65.ebuild        19 May 2014 15:50:29 -0000      1.1
+++ cppcheck-1.65.ebuild        8 Sep 2014 10:00:43 -0000
@@ -24,6 +24,7 @@ RDEPEND="${DEPEND}"

 src_prepare() {
        # Do not use bundled tinyxml2
+       rm -r externals || die
        epatch \
                "${FILESDIR}"/${P}-tinyxml2.patch \
                "${FILESDIR}"/${P}-c++0x.patch

[Comment 2 Michael Weber (RETIRED) 2014-10-09 23:17:00 UTC]

+*cppcheck-1.65-r1 (09 Oct 2014)
+
+  09 Oct 2014; Michael Weber <[e-mail]> +cppcheck-1.65-r1.ebuild,
+  +files/cppcheck-1.65-r1-tinyxml2.patch:
+  Remove bundled tinyxml2 by adjusting Makefile generator (bug 522368).
+