522248 – dev-perl/DBD-mysql-4.20.0 - ?

Bug 522248 - dev-perl/DBD-mysql-4.20.0 - ?

Summary: dev-perl/DBD-mysql-4.20.0 - ?

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Perl team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2014-09-06 09:12 UTC by Daniel Kovacs
Modified:	2014-09-06 14:47 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Kovacs 2014-09-06 09:12:35 UTC

In the original code, there is a missing if-endif part, and under several conditions the compile fails.

Patch:

diff -rupN DBD-mysql-4.020/dbdimp.c DBD-mysql-4.020-new/dbdimp.c
--- DBD-mysql-4.020/dbdimp.c    2011-08-20 20:35:59.000000000 +0200
+++ DBD-mysql-4.020-new/dbdimp.c        2014-09-05 17:49:24.621195143 +0200
@@ -3473,7 +3473,9 @@ int dbd_st_execute(SV* sth, imp_sth_t* i
         return 0;
     }
 #endif
+#if MYSQL_VERSION_ID >= SERVER_PREPARE_VERSION
   }
+#endif

   if (imp_sth->row_num+1 != (my_ulonglong)-1)
   {

Comment 1 Mikle Kolyada (RETIRED) archtester

2014-09-06 14:47:41 UTC

why should we implement this one into gentoo instead upstream? We should not.