Created attachment 384066 [details] dvd-audio-extractor-7.2.0.ebuild DVD Audio Extractor is commercial software used to rip audio tracks from Blu-ray, DVD-Audio, and DVD-Video discs. This ebuild installs a trial version, which can be converted to a full version by buying/registering a license. The ebuild is tested on amd64 and works fine, though there are three things worth pointing out: * The built-in help system does not work for me. Don't know why. Everything else works. though. * The list of dependencies came from running ldd on the prebuilt binaries. I'd expect some of them are optional; eg., if libflac isn't present it should probably still run, you just wouldn't be able to output to flac. However, I've not tested this. * It requires capabilities to be set on the binaries. I did this using fcaps and it seems to work fine for me, but this is the first time I've done anything like that in an ebuild. It'd be a good idea for someone more familiar with this process to review this and ensure I did it right.
Comment on attachment 384066 [details] dvd-audio-extractor-7.2.0.ebuild >[ "$ARCH" == "amd64" ] && MY_ARCH=amd64 || MY_ARCH=i386 That's wrong. I'm pretty sure I told you elsewhere that this can never be resolved in SRC_URI. >MY_REV=5186 >MY_PN="DVD Audio Extractor" > >DESCRIPTION="Commercial software used to rip audio tracks from Blu-ray, DVD-Audio, and DVD-Video discs" >HOMEPAGE="http://www.dvdae.com/" >SRC_URI="http://www.dvdae.com/dvdae/dvdae_${PV}_${MY_ARCH}.deb" > >LICENSE="GPL-2" If the license is GPL-2, then why are we treated to a "commercial" "trial" version? >KEYWORDS="amd64 ~x86 -*" Straight to stable? >IUSE=" gtk" What does the whitespace do? >RESTRICT="strip" QA_PREBUILT='*' >DEPEND="" No need to set an empty DEPEND. >S=${WORKDIR} > >src_unpack() { > unpack "${A}" > tar xf data.tar.gz inherit unpacker ... unpack_deb ${A} >src_prepare() { > # Fix QA issue That isn't descriptive. "Should end with a semicolon" would be. > ewarn "When ripping discs to WAV or other transcoded formats, ${MY_PN}" > ewarn "forcibly enables dynamic range compression, which introduces audio" > ewarn "artifacts. For best quality, it is recommended that you perform a direct" > ewarn "stream demux and manually transcode the resulting AC3/MLP/etc. afterward.\n" > ewarn "Please note: In order to rip uncompressed audio (LPCM) from DVD-Audio discs," > ewarn "you must first mount the disc. Otherwise, only the compressed (AC3/DTS)" > ewarn "DVD-Video audio will be extracted." You should probably stick that in a readme. At install time it's of no use.
