Bug 521650 – sci-mathematics/maxima-5.34.0: suspicious use of einstall

• Status: RESOLVED OBSOLETE
• Product: Gentoo Linux

[Description Michał Górny 2014-08-29 22:05:16 UTC]

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

[Comment 1 Michał Górny 2014-08-31 10:41:55 UTC]

And I can confirm that 'emake DESTDIR=${D} install' installs maxima just fine. 

However, emacs lisp files move from /usr/share/emacs/site-lisp to /usr/share/maxima/5.34.0/emacs. I don't know if that's a problem, i.e. if we're always supposed to use the canonical path or if there's some kind of lisppath that maxima updates for its non-standard location.

If it is necessary, 'emake DESTDIR=${D} emacsdir=... install' can be used instead of einstall.

[Comment 2 Ulrich Müller 2014-08-31 11:26:09 UTC]

(In reply to Michał Górny from comment #1)
> However, emacs lisp files move from /usr/share/emacs/site-lisp to
> /usr/share/maxima/5.34.0/emacs. I don't know if that's a problem, i.e. if
> we're always supposed to use the canonical path or if there's some kind of
> lisppath that maxima updates for its non-standard location.

Yes, it is a problem. Our policy is that elisp files are always installed in ${SITELISP}/${PN} because Emacs will find them there, even without any additional configuration for its load-path.

> If it is necessary, 'emake DESTDIR=${D} emacsdir=... install' can be used
> instead of einstall.

Please do.

[Comment 3 Andrey Grozin 2014-09-14 09:23:04 UTC]

I've replaced the einstall line by
emake DESTDIR="${D}" emacsdir="${SITELISP}/${PN}" install
Everything's installed correctly on amd64 and x86. Will tthis break something in prefix arches? The old einstall line contained emacsdir="${ED}${SITELISP}/${PN}", and ${ED} is something prefix-specific. I have no access to such arches, and cannot test myself. maxima is keyworded, in particular, ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos.

[Comment 4 Andrey Grozin 2014-09-14 10:07:31 UTC]

*maxima-5.34.1 (14 Sep 2014)

  14 Sep 2014; Andrey Grozin <[e-mail]> +maxima-5.34.1.ebuild:
  Version bump, no einstall (#521650), docompress (#176411)

Leaving the bug open in case something goes wrong for prefix

[Comment 5 jcdx 2015-01-13 09:25:18 UTC]

(In reply to Andrey Grozin from comment #3)
> I've replaced the einstall line by
> emake DESTDIR="${D}" emacsdir="${SITELISP}/${PN}" install
> Everything's installed correctly on amd64 and x86. Will tthis break
> something in prefix arches? The old einstall line contained
> emacsdir="${ED}${SITELISP}/${PN}", and ${ED} is something prefix-specific. I
> have no access to such arches, and cannot test myself. maxima is keyworded,
> in particular, ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos.

As suggested here 
http://forums.gentoo.org/posting.php?mode=reply&t=1006910&sid=37a0cb36a9e9f272a6bb72a8a4fe3155

I tested the following on Mac OS 10.10 prefix=/gentoo for maxima-5.35.1-r1.ebuild using a local overlay. (~x64-macos)

Replacing (line 156): 
emake DESTDIR="${D}" emacsdir="${SITELISP}/${PN}" install

With:
emake DESTDIR="${D}" emacsdir="${EPREFIX}/${SITELISP}/${PN}" install

Doing this the compiling and installation works fine.

Best regards.

[Comment 6 Andrey Grozin 2015-11-27 12:35:13 UTC]

5.34.0 is no longer in the tree, newer versions are fixed.