Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520914 - media-video/handbrake-9999 - remove some patches
Summary: media-video/handbrake-9999 - remove some patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Whyman (thev00d00) (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-08-26 01:47 UTC by Jared B.
Modified: 2014-11-24 17:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared B. 2014-08-26 01:47:36 UTC
The live ebuild for handbrake does not currently compile on my amd64 system.  There's a bug in version 0.9.9 that causes it to crash when transcoding certain content (ripped blurays), so I needed the live version to get it to work for me.  Looks like they modified their build system a bit and changed some of the options.  Here's what got it working for me:

--- /usr/portage/media-video/handbrake/handbrake-9999.ebuild    2014-08-10 16:01:13.000000000 -0500
+++ handbrake-9999.ebuild       2014-08-25 20:38:38.999294728 -0500
@@ -95,10 +95,10 @@
                || die "Contrib removal failed."
 
        # Instead of adding a #define to libmkv, we expand it in place. 
-       epatch "${FILESDIR}"/${PN}-9999-expand-MK_SUBTITLE_PGS.patch
+       #epatch "${FILESDIR}"/${PN}-9999-expand-MK_SUBTITLE_PGS.patch
 
        # Fix compilation against the released 1.9.1 version of mp4v2.
-       epatch "${FILESDIR}"/${PN}-9999-fix-compilation-with-mp4v2-v1.9.1.patch
+       #epatch "${FILESDIR}"/${PN}-9999-fix-compilation-with-mp4v2-v1.9.1.patch
 
        # Remove libdvdnav duplication and call it on the original instead.
        # It may work this way; if not, we should try to mimic the duplication.
@@ -108,7 +108,7 @@
        epatch "${FILESDIR}"/${PN}-9999-remove-faac-dependency.patch
 
        # Make use of an older version of libmkv.
-       epatch "${FILESDIR}"/${PN}-9999-use-older-libmkv.patch
+       #epatch "${FILESDIR}"/${PN}-9999-use-older-libmkv.patch
 
        # Fixup configure.ac with newer automake.
        # TODO: Would like to see this shorten towards the future;
@@ -138,10 +138,8 @@
                --force \
                --prefix="${EPREFIX}/usr" \
                --disable-gtk-update-checks \
-               --enable-avformat \
                --disable-libav-aac \
-               --enable-libmkv \
-               --enable-mp4v2 \
+               --disable-x265 \
                $(use_enable fdk fdk-aac) \
                $(use_enable gtk) \
                $(usex !gstreamer --disable-gst) || die "Configure failed."


The files affected by those three disabled patches no longer seem to exist, and the three disabled options likewise no longer seem to exist.  They did an option for x265 (enabled by default), which should probably implemented via a USE flag, but since I haven't done any testing at all with it I just hard disabled it.  With these changes the live version (as of 8/25/14) builds and runs great for me, including letting me transcode my bluray rips.

Just passing on in the hope it'll be helpful for others.
Comment 1 Ian Whyman (thev00d00) (RETIRED) gentoo-dev 2014-11-24 12:37:01 UTC
Is this still an issue, I did a 9999 build the other day without issue.