Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520686 - sys-boot/raspberrypi-firmware should check for "${ROOT}"/boot/cmdline.txt
Summary: sys-boot/raspberrypi-firmware should check for "${ROOT}"/boot/cmdline.txt
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-08-23 11:18 UTC by Maxim Mikityanskiy
Modified: 2015-04-01 15:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Mikityanskiy 2014-08-23 11:18:26 UTC
In sys-boot/raspberrypi-firmware ebuilds there are two checks:

if [ -e "${D}"/boot/cmdline.txt -a -e /boot/cmdline.txt ] ; then

if [ -e "${D}"/boot/config.txt -a -e /boot/config.txt ] ; then

These checks affect files /boot/cmdline.txt and /boot/config.txt, but instead ebuild should check ${ROOT}/boot/cmdline.txt and ${ROOT}/boot/config.txt. For example, when I do cross-compiling in prefix /usr/armv6j-hardfloat-linux-gnueabi, it should check /usr/armv6j-hardfloat-linux-gnueabi/boot/{cmdline,config}.txt instead of hosts' /boot/{cmdline,config}.txt. It leads to build failure because there is /boot/cmdline.txt on my host system that is not relevant to this check really.

So I suggest changing that two lines in all raspberrypi-firmware ebuilds to the following:

if [ -e "${D}"/boot/cmdline.txt -a -e "${ROOT}"/boot/cmdline.txt ] ; then

if [ -e "${D}"/boot/config.txt -a -e "${ROOT}"/boot/config.txt ] ; then
Comment 1 Michael Weber (RETIRED) gentoo-dev 2015-04-01 15:11:26 UTC
In my overlay, in tree soon.

+  01 Apr 2015; Michael Weber <xmw@gentoo.org>
+  raspberrypi-firmware-1_pre20150327.ebuild:
+  Fix bug 520686 by Maxim Mikityanskiy.
+