Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520254 - media-plugins/mythplugins-0.27.1_p20140817 should not depend on media-libs/libiec61883
Summary: media-plugins/mythplugins-0.27.1_p20140817 should not depend on media-libs/li...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: MythTV Maintainers
URL:
Whiteboard:
Keywords:
: 520658 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-08-19 15:34 UTC by Paul Sands
Modified: 2014-09-08 16:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Sands 2014-08-19 15:34:57 UTC
version bump from 0.27.1_p20140713 to 0.27.1_p20140817 now includes a large number of new dependencies which are not tied to use flags. For example, mythplugins pulls in dependency on media-libs/libiec61883, even if media-tv/mythtv is built with USE="-ieee1394".

Would having use flags in mythplugins (or polling enabled use flags from the mythtv build) be a better way to manage?

I am not sure if there was some major change upstream which now requires these for mythplugins specifically (independent of mythtv use flags) but thought I would file the bug to clarify.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-plugins/mythtv-0.27.1_p20140817
Actual Results:  
media-libs/libiec61883 is pulled in automatically due to ebuild dependencies

Expected Results:  
have use flag for ieee1394 which then enables or disables dependency on media-libs/libiec61883
Comment 1 Richard Freeman gentoo-dev 2014-08-19 22:00:57 UTC
I discovered a number of missing dependencies - these have been missing for a while now so the only change in the ebuild is capturing them.  Most seem to be "automagic" and I agree that they should be USE-based where possible.  I need to take more time to go through the build system and enable this, so I'll leave this open to track.

If you were using mythplugins without some of these deps without issue it will probably continue to work fine in the new version.  However, if you do have some of these deps installed and they are upgraded, mythplugins could break due to linking errors.  The new dependencies use slot operators so where the libraries declare subslots we should get automatic rebuilds.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-23 09:04:52 UTC
*** Bug 520658 has been marked as a duplicate of this bug. ***
Comment 3 Richard Freeman gentoo-dev 2014-08-23 12:56:57 UTC
Ok, I see what is going on here.  Mythplugins inherits configuration from mythtv, so if mythtv is built with ieee1394, then mythplugins will be as well, with no  way to enabled/disable this (aside from patching).  

So, I think the cleanest option is to remove any deps inherited from mythtv which are optional.  That means that things like firewire will be optional and triggered by the mythtv settings.  On the other hand, if you upgrade firewire it will break linking on mythplugins and there won't be any automatic rebuilds, which was one of the goals of declaring the dependency.
Comment 4 Paul Sands 2014-08-23 15:18:02 UTC
I am not sure if any of the plugins actually need those dependencies but could you instead make mythplugins with USE flag ieee1394 that depends both on the actual libraries (which would trigger the automatic rebuild as needed) but also depend on mythtv with USE flag ieee1394 enabled? Same logic could be applied to other optional use flags with the mythtv package (theora, vorbis, fftw as other examples).

The thought here is that I don't think we want myth and mythplugins built with different USE flags with common dependencies (can see issue where plugins are built with one but mythtv package is not) but need mythplugins to auto rebuild when the libraries are updated.
Comment 5 Richard Freeman gentoo-dev 2014-08-23 15:31:14 UTC
(In reply to Paul Sands from comment #4)
> I am not sure if any of the plugins actually need those dependencies but
> could you instead make mythplugins with USE flag ieee1394 that depends both
> on the actual libraries (which would trigger the automatic rebuild as
> needed) but also depend on mythtv with USE flag ieee1394 enabled? Same logic
> could be applied to other optional use flags with the mythtv package
> (theora, vorbis, fftw as other examples).
> 

That's actually a great idea.  Normally using USE flags ONLY to pull in deps is frowned upon.  However, in this particular case it actually makes a lot of sense.  While it is a bit indirect, the USE flag would be coupled to the on-disk image.
Comment 6 Richard Freeman gentoo-dev 2014-09-07 15:23:34 UTC
This has been fixed in the rich0 overlay.  I'll leave this open until I push this into the tree in a few days, but feel free to test it in the meantime.
Comment 7 Richard Freeman gentoo-dev 2014-09-08 16:30:53 UTC
in portage now