Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 520232 - sys-fs/dosfstools - dosfsck: incomplete and unexpected behaviour in interactive repair (-r) mode
Summary: sys-fs/dosfstools - dosfsck: incomplete and unexpected behaviour in interacti...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/dosfstools/dosfsto...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-19 06:57 UTC by Sergey S. Starikoff
Modified: 2015-05-18 02:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey S. Starikoff 2014-08-19 06:57:32 UTC
Just today, working under another issue in dmesg's output I've fine the following pointer:
[ 6238.730551] FAT-fs (sdb1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.

First check showed iisue list:
localhost ~ # dosfsck /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
1) Remove dirty bit
2) No action
? 2
There are differences between boot sector and its backup.
This is mostly harmless. Differences: (offset:original/backup)
  65:01/00
1) Copy original to backup
2) Copy backup to original
3) No action
? 1
/
  Bad short file name ().
1) Drop file
2) Rename file
3) Auto-rename
4) Keep it
? 1
Leaving filesystem unchanged.
/dev/sdb1: 1070 files, 231464/236329 clusters

After that I've gone to repair mode:
localhost ~ # dosfsck -r /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
1) Remove dirty bit
2) No action
? 1
/
  Bad short file name ().
1) Drop file
2) Rename file
3) Auto-rename
4) Keep it
? 1
Perform changes ? (y/n) y
/dev/sdb1: 1070 files, 231464/236329 clusters

First run showed different, incomplete issue list.
First (!) re-run check showed, that second of find (in interactive rapair mode) issues wasn't fixed:
localhost ~ # dosfsck /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
/
  Bad short file name ().
1) Drop file
2) Rename file
3) Auto-rename
4) Keep it
? 1
/dev/sdb1: 1070 files, 231464/236329 clusters

But second re-run check showe no issue (!):
localhost ~ # dosfsck /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
/dev/sdb1: 1071 files, 231464/236329 clusters

And third re-run showed it again:
localhost ~ # dosfsck /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
/
  Bad short file name ().
1) Drop file
2) Rename file
3) Auto-rename
4) Keep it
? 1
/dev/sdb1: 1070 files, 231464/236329 clusters

Re-run dosfsck in -r mode (loop, together with -a mode) don't fixed this issue:
localhost ~ # dosfsck -r /dev/sdb1
fsck.fat 3.0.26 (2014-03-07)
/
  Bad short file name ().
1) Drop file
2) Rename file
3) Auto-rename
4) Keep it
? 1
/dev/sdb1: 1070 files, 231464/236329 clusters

And it's not very clear what happened with second issue from first report (differences between boot sector and its backup): it was either silently fixed or incorrectly reported.

My test USB flash drive is:
Bus 002 Device 004: ID 13fe:3e00 Kingston Technology Company Inc. Flash Drive
(4 Gb).

My system $ einfo 
Portage 2.2.8-r1 (default/linux/amd64/13.0, gcc-4.7.3, glibc-2.19-r1, 3.12.21-aufs-r1 x86_64)
=================================================================
System uname: Linux-3.12.21-aufs-r1-x86_64-AMD_Athlon-tm-_II_X2_250_Processor-with-gentoo-2.2
KiB Mem:     1794620 total,     57248 free
KiB Swap:    8000364 total,   8000000 free
Timestamp of tree: Mon, 18 Aug 2014 04:45:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.7.7, 3.3.5-r1
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.13 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo local_hdd
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/env.d /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--ask --verbose --autounmask=n"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildsyspkg config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles merge-sync metadata-transfer news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/                 ftp://mirror.yandex.ru/gentoo-distfiles/                 http://ftp.corbina.net/pub/Linux/gentoo/                 ftp://ftp.corbina.net/pub/Linux/gentoo/"
LANG="ru_RU.utf8"
LC_ALL=""
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/rsync_excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage/gentoo"
PORTDIR_OVERLAY="/usr/portage/local"
USE="X a52 ac3 acl alsa amd64 avi berkdb bold bzip2 cdr cli consolekit cracklib crypt cups cxx dbus djvu dri dvd flac fortran gdbm gif gtk iconv inotify jpeg jpeg2k lock mmx modules mp3 multilib ncurses nls nptl ogg openmp pam pcre pdf png policykit qt3support readline session sse sse2 ssl tcpd thunar tiff udev udisks unicode utf8 vorbis xcb xulrunner zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="ru ru_RU" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-4" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby20" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON
Comment 1 Alex Efros 2014-09-24 00:38:31 UTC
Looks like a regression from 3.0.25: https://bugzilla.redhat.com/show_bug.cgi?id=1078057
Comment 2 Sergey S. Starikoff 2014-09-24 05:44:42 UTC
(In reply to Alex Efros from comment #1)
> Looks like a regression from 3.0.25:
> https://bugzilla.redhat.com/show_bug.cgi?id=1078057

Probably at least not only.

On another workstation I've tried to fix a flash drive.
Downgrade to previous stable version of dosfsck (=sys-fs/dosfstools-3.0.22) took no effect.
Neither in interactive, nor in automatic mode:

Interactive:
# dosfsck -r /dev/sdb1
fsck.fat 3.0.22 (2013-07-19)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
1) Remove dirty bit
2) No action
? 1
Filesystem has 1973762 clusters but only space for 1973758 FAT entries.

Fixed? Check result:
# dosfsck /dev/sdb1
fsck.fat 3.0.22 (2013-07-19)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
1) Remove dirty bit
2) No action
? ^C

No!
Now trying auto mode:
# dosfsck -a /dev/sdb1
fsck.fat 3.0.22 (2013-07-19)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
 Automatically removing dirty bit.
Filesystem has 1973762 clusters but only space for 1973758 FAT entries.

And repeat:
# dosfsck -a /dev/sdb1
fsck.fat 3.0.22 (2013-07-19)
0x41: Dirty bit is set. Fs was not properly unmounted and some data may be corrupt.
 Automatically removing dirty bit.
Filesystem has 1973762 clusters but only space for 1973758 FAT entries.

Result is the same. No effect.
Comment 3 Sergey S. Starikoff 2014-09-28 06:36:36 UTC
Ops.
Upstream seems to be dead:

Note: dosfstools is orphaned
There will be no further updates
-- Daniel Baumann <mail@daniel-baumann.ch> Fri, 25 Jul 2014 21:34:17 +0200
http://daniel-baumann.ch/software/dosfstools/
Comment 4 Sergey S. Starikoff 2014-11-04 13:42:27 UTC
Bug relates not only amd64.
Issue was reproduced on built with gcc-4.6.4 x86 box.
Comment 5 Sergey S. Starikoff 2015-01-24 17:33:09 UTC
Issue looks like to be hardware-selective.
With sandisk's SD card (connected via portable USB adapter) it works ok.
With basic Transcend flash — ­fails.
dmesg report about issued device:
[ 2494.495338] usb 9-3: new high-speed USB device number 5 using ehci-pci
[ 2494.611362] usb 9-3: New USB device found, idVendor=8564, idProduct=1000
[ 2494.611365] usb 9-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 2494.611367] usb 9-3: Product: Mass Storage Device
[ 2494.611369] usb 9-3: Manufacturer: JetFlash
[ 2494.611370] usb 9-3: SerialNumber: 99OFH1N0Y0VAI53U
[ 2494.611650] usb-storage 9-3:1.0: USB Mass Storage device detected
[ 2494.611738] scsi13 : usb-storage 9-3:1.0
[ 2495.804986] scsi 13:0:0:0: Direct-Access     JetFlash Transcend 8GB    1100 PQ: 0 ANSI: 4
[ 2495.805210] sd 13:0:0:0: Attached scsi generic sg7 type 0
[ 2495.806231] sd 13:0:0:0: [sdg] 15826944 512-byte logical blocks: (8.10 GB/7.54 GiB)
[ 2495.806938] sd 13:0:0:0: [sdg] Write Protect is off
[ 2495.806941] sd 13:0:0:0: [sdg] Mode Sense: 43 00 00 00
[ 2495.807666] sd 13:0:0:0: [sdg] No Caching mode page found
[ 2495.807672] sd 13:0:0:0: [sdg] Assuming drive cache: write through
[ 2495.811722]  sdg: sdg1
[ 2495.814668] sd 13:0:0:0: [sdg] Attached SCSI removable disk
Comment 6 SpanKY gentoo-dev 2015-04-03 07:05:32 UTC
Commit message: Version bump
http://sources.gentoo.org/sys-fs/dosfstools/dosfstools-3.0.27.ebuild?rev=1.1
Comment 7 SpanKY gentoo-dev 2015-04-03 07:06:02 UTC
if it's still failing for you, please post the issue here instead:
  https://github.com/dosfstools/dosfstools/issues
Comment 8 Sergey S. Starikoff 2015-05-17 18:32:56 UTC
=sys-fs/dosfstools-3.0.28
Issue still present.
Reported upstream.
https://github.com/dosfstools/dosfstools/issues/8