Bug 519914 – app-portage/deltup-0.4.6 version bump

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Ameretat.Reith 2014-08-14 12:28:48 UTC]

Upstream made a new release and merged Gentoo proposed patches. Also, I failed to make ebuild myself since hosted archive name seems to not be recognizable by Portage.  What would you do in this situation (e.g. zip file hosted for Github with v%version%.zip pattern) before copying tarball into distfile servers?

[Comment 1 Yixun Lan 2015-03-12 07:18:16 UTC]

Hi Ameretat, re your email.. adjust package name like this [1]

please submit ebuild here for review, we will accept it into portage tree while it reach good state (no major flaw, etc.)
also, what's your detail info would you like us to put into metadata.xml? [2]


[1] SRC_URI="https://github.com/jjwhitney/Deltup/archive/v${PV}.tar.gz -> ${P}.tar.bz"

[2] example of personal info, put your irc nick on if you have
  <maintainer>
    <email>[e-mail]</email>
    <name>Ameretat 'irc_nick' Reith</name>
    <description>Primary Maintainer, Assign Bugs</description>
  </maintainer>


thanks for your contribution!

[Comment 2 Ameretat.Reith 2015-03-12 10:17:05 UTC]

Created attachment 398730 [details]
new ebuild (v1)

[Comment 3 Ameretat.Reith 2015-03-12 10:17:59 UTC]

Created attachment 398732 [details, diff]
remove mysterious %%PREFIX%% in makefile

[Comment 4 Ameretat.Reith 2015-03-12 10:22:12 UTC]

(In reply to Yixun Lan from comment #1)
> Hi Ameretat, re your email.. adjust package name like this [1]
> 
> please submit ebuild here for review, we will accept it into portage tree
> while it reach good state (no major flaw, etc.)

Thanks.  Previous patches are now merged into upstream.  I failed to understand upstream's intention by "PREFIX=%%PREFIX%%" in Makefile, so removed it for now to succeed installation.

> also, what's your detail info would you like us to put into metadata.xml? [2]

I'm `reith' on freenode.

[Comment 5 Yixun Lan 2015-03-12 23:03:30 UTC]

+*deltup-0.4.6 (12 Mar 2015)
+
+  12 Mar 2015; Yixun Lan <[e-mail]> -deltup-0.4.5.ebuild,
+  deltup-0.4.5-r1.ebuild, +deltup-0.4.6.ebuild,
+  -files/deltup-0.4.4-asneeded.patch, -files/deltup-0.4.4-gcc44.patch,
+  +files/deltup-0.4.6-fix-prefix.patch,
+  -files/bzip2-1.0.2-makefile-CFLAGS.patch,
+  -files/bzip2-1.0.3-makefile-CFLAGS.patch, -files/gcc-4.3-compile.fix,
+  metadata.xml:
+  version bump, drop old, add new proxy maintainer, thanks Ameretat Reith


I take the liberty to adjust the ebuild, please check with diff
btw, I found the “remove PREFIX" change still necessary, I could find that upstream accepted this patch?

also please always run "repoman full" in your ebuild's directory before submit here

[Comment 6 Ameretat.Reith 2015-03-12 23:20:43 UTC]

> btw, I found the “remove PREFIX" change still necessary, I could find that
> upstream accepted this patch?

This came from this commit [1], don't know why.  I may ask him about this.

> also please always run "repoman full" in your ebuild's directory before
> submit here

Sure.  Thanks for fixing this.

1: https://github.com/jjwhitney/Deltup/commit/e1d768b138f4c364238931758feb8202be174609

[Comment 7 Yixun Lan 2015-03-13 01:59:46 UTC]

oh, think I got this, he'd like to make PREFIX configurable
following code should fix this, can also drop that patch

 src_install () {
-       default
+       emake DESTDIR="${D}" PREFIX=/usr install
        dodoc "${S}"/../{README,ChangeLog}
        doman "${S}"/../deltup.1
 }

[Comment 8 Yixun Lan 2015-03-13 02:02:10 UTC]

+  13 Mar 2015; Yixun Lan <[e-mail]> deltup-0.4.6.ebuild,
+  -files/deltup-0.4.4-CFLAGS.patch, -files/deltup-0.4.6-fix-prefix.patch:
+  explicitly set PREFIX variable

fixed without revision bump