Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 519214 - sys-apps/cv-0.4.1 should use a SRC_URI arrow
Summary: sys-apps/cv-0.4.1 should use a SRC_URI arrow
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-06 13:57 UTC by Casper Ti. Vector
Modified: 2014-08-06 20:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Casper Ti. Vector 2014-08-06 13:57:10 UTC 
As the title suggests, cv-0.4.1.ebuild writes
> SRC_URI="https://github.com/Xfennec/${PN}/archive/v${PV}.tar.gz"
which downloads `v0.4.1.tar.gz'.

Such filenames are confusing (without package names), and may collide with other source archives (many source tarballs from GitHub are named similarly).  Therefore, it should be better to use
> SRC_URI="https://github.com/Xfennec/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"

(Finally, please forgive me if I am always stretching my nose too far...)
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-06 20:08:44 UTC 
It also fails to build against sys-libs/ncurses[tinfo].
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-06 20:17:27 UTC 
It also didn't install README.md and failed to respect CC and LDFLAGS.