Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 519138 - app-misc/libomron-0.9.0 - Libraries for accessing data from Omron medical devices
Summary: app-misc/libomron-0.9.0 - Libraries for accessing data from Omron medical dev...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL: https://github.com/qdot/libomron
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2014-08-05 14:47 UTC by Patryk Rzadzinski
Modified: 2014-08-05 15:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
libomron-0.9.0.ebuild (libomron-0.9.0.ebuild,536 bytes, text/plain)
2014-08-05 14:47 UTC, Patryk Rzadzinski
Details
patch addressing the suggestions (libomron-0.9.0.ebuild.patch,865 bytes, patch)
2014-08-05 15:28 UTC, Patryk Rzadzinski
Details | Diff
improved ebuild (libomron-0.9.0.ebuild,496 bytes, text/plain)
2014-08-05 15:43 UTC, Patryk Rzadzinski
Details
improved patch (libomron-0.9.0.ebuild.patch,886 bytes, patch)
2014-08-05 15:45 UTC, Patryk Rzadzinski
Details | Diff
improved patch (libomron-0.9.0.ebuild.patch,886 bytes, patch)
2014-08-05 15:46 UTC, Patryk Rzadzinski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patryk Rzadzinski 2014-08-05 14:47:15 UTC
Created attachment 382322 [details]
libomron-0.9.0.ebuild

This is an extremely simple but working ebuild for extracting data from medical devices such as blood pressure measurement kit by the Japanese company Omron. The original software has been written by qDot, I have only prepared this ebuild.

I am not sure about the app-misc placement, but it doesn't seem there is a more appropriate category right now. Perhaps worth creating something for *medical* software?
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-05 14:55:34 UTC
Comment on attachment 382322 [details]
libomron-0.9.0.ebuild

>EAPI=4

Why not jump straight to the latest, EAPI=5?

>DESCRIPTION="Library and tool set for extracting data from Omron medical devices via USB."

Shouldn't end in a dot.

>HOMEPAGE="http://sourceforge.net/projects/nplabs/files/libomron/0.9.0/"

This should probably reflect that development has moved to github. Although over there it says it forked from https://github.com/openyou/libomron

>SRC_URI="mirror://sourceforge/nplabs/libomron/${P}.tar.gz"

Same.

>LICENSE="GPL-2"
>SLOT="0"
>KEYWORDS="~amd64"
>IUSE="swig"
>
>RDEPEND="
>	dev-util/cmake
>	dev-lang/python
>	dev-libs/libusb
>	swig? ( dev-lang/swig )"

That looks fishy. What happens differently when dev-lang/swig isn't around? Why is the RDEPEND on swig needed? I guess the metadata.xml entry would explain?
Comment 2 Patryk Rzadzinski 2014-08-05 14:59:02 UTC
Thanks for the prompt response.

Nothing wrong with EAPI=5, I can change that, I was following the dev guide as it's been a while since the last time I did an ebuild.

Minor fixes - ok.

As for swig - I've no idea. The README says it is optional, cmake makes a check for it but it works for me without it in the same way. If you want I can remove this IUSE...
Comment 3 Patryk Rzadzinski 2014-08-05 15:28:04 UTC
Created attachment 382326 [details, diff]
patch addressing the suggestions
Comment 4 Patryk Rzadzinski 2014-08-05 15:43:36 UTC
Created attachment 382330 [details]
improved ebuild
Comment 5 Patryk Rzadzinski 2014-08-05 15:45:26 UTC
Created attachment 382332 [details, diff]
improved patch
Comment 6 Patryk Rzadzinski 2014-08-05 15:46:07 UTC
Created attachment 382334 [details, diff]
improved patch