Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 519076 - net-misc/openssh-6.6.1_p1 patch is incorrect
Summary: net-misc/openssh-6.6.1_p1 patch is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-08-04 19:24 UTC by Mira Ressel
Modified: 2014-08-12 07:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mira Ressel 2014-08-04 19:24:56 UTC
The patch between OpenSSH 6.6_p1 and 6.6.1_p1 was pasted from Damien's announcement mail at https://lists.mindrot.org/pipermail/openssh-unix-dev/2014-April/032494.html. The Pipermail application from which the patch was pasted does replace "@" signs with " at ". One of these replaced @'s was located inside the code (as "curve25519-sha256@libssh.org").

OpenSSH 6.6.1 is supposed to disable the curve25519 key exchange algorithm when connecting to older, buggy ssh instances, but this fails on Gentoo because our mis-patched version looks for "curve25519-sha256 at libssh.org" instead of "curve25519-sha256@libssh.org".

Please do a
    $ sed -i -e 's/ at /@/' files/openssh-6.6.1_p1.patch
.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2014-08-04 19:35:44 UTC
+*openssh-6.6.1_p1-r1 (04 Aug 2014)
+
+  04 Aug 2014; Lars Wendler <polynomial-c@gentoo.org> -openssh-6.6.1_p1.ebuild,
+  +openssh-6.6.1_p1-r1.ebuild, files/openssh-6.6.1_p1.patch:
+  Fixed mistakenly replaced @ char. Thanks to Luis Ressel for reporting this in
+  bug #519076.
+
Comment 2 Navid Zamani 2014-08-09 22:08:27 UTC
The -r2 update to this broke things *completely* FYI. Logging in to a server that forces curve22519, chacha20-poly1395 and umac-128 isn’t possible anymore. So whatever you did… please fix your fix. :)
Comment 3 Navid Zamani 2014-08-09 22:14:10 UTC
P.S.: Even worse: SSH flooded my RAM and was killed by the kernel’s OOM handler. So it could even be a kind of buffer overflow with security implications.

All is in flames…
Comment 4 SpanKY gentoo-dev 2014-08-12 07:55:25 UTC
(In reply to Navid Zamani from comment #2)

new problem -> new bug