Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 517210 - dev-python/geoip-python-1.3.1 version bump
Summary: dev-python/geoip-python-1.3.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2014-07-16 01:44 UTC by Anthony Ryan
Modified: 2014-07-18 05:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
geoip-python-1.3.1.ebuild (geoip-python-1.3.1.ebuild,801 bytes, text/plain)
2014-07-16 01:45 UTC, Anthony Ryan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ryan 2014-07-16 01:44:19 UTC
python-geoip has been updated, while doing the version bump I noticed several problems with the ebuild.

LICENSE has been incorrect since 2007.
FEATURES="test" did not seem to be working.
The existing HOMEPAGE doesn't exist (I have substituted it with the github page the official source seems to indicate is the primary source of information regarding this project).

I have attached the 1.3.1 ebuild with the appropriate patches.

Reproducible: Always
Comment 1 Anthony Ryan 2014-07-16 01:45:05 UTC
Created attachment 380788 [details]
geoip-python-1.3.1.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-16 02:25:44 UTC
Comment on attachment 380788 [details]
geoip-python-1.3.1.ebuild

--- geoip-python-1.2.8-r1.ebuild        2014-03-05 16:38:30.635213575 +0100
+++ -   2014-07-16 04:25:21.971306692 +0200
@@ -3,33 +3,30 @@
 # $Header: /var/cvsroot/gentoo-x86/dev-python/geoip-python/geoip-python-1.2.8-r1.ebuild,v 1.5 2014/03/05 15:36:32 ago Exp $
 
 EAPI=5
-PYTHON_COMPAT=( python{2_6,2_7} )
+PYTHON_COMPAT=( python{2_7,3_3,3_4} )
 
 inherit distutils-r1

-MY_PN="GeoIP-Python"
+MY_PN="geoip-api-python"
 MY_P="${MY_PN}-${PV}"
 
 DESCRIPTION="Python bindings for GeoIP"
-HOMEPAGE="http://www.maxmind.com/app/python"
-SRC_URI="http://www.maxmind.com/download/geoip/api/python/${MY_P}.tar.gz"
+HOMEPAGE="https://github.com/maxmind/geoip-api-python"
+SRC_URI="https://github.com/maxmind/geoip-api-python/archive/v${PV}.tar.gz"

-LICENSE="LGPL-2.1"
+LICENSE="GPL-2+"
 SLOT="0"
-KEYWORDS="amd64 ~ia64 ppc ~sparc x86 ~x86-fbsd"
-IUSE=""
+KEYWORDS="~amd64 ~ia64 ~ppc ~sparc ~x86 ~x86-fbsd"
+IUSE="test"

-DEPEND=">=dev-libs/geoip-1.4.8"
-RDEPEND="${DEPEND}"
+RDEPEND=">=dev-libs/geoip-1.4.8"
+DEPEND="${RDEPEND}
+       test? ( dev-python/nose[${PYTHON_USEDEP}] )"
 
 S="${WORKDIR}/${MY_P}"

-DOCS=( README ChangeLog test.py test_city.py test_org.py )
+DOCS=( README.rst ChangeLog.md )
 
 python_test() {
-       if "${PYTHON}" -m test; then
-               einfo "tests passed unde ${EPYTHON}"
-       else
-               die "tests failed under ${EPYTHON}"
-       fi
+       esetup.py test
 }
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2014-07-18 05:01:43 UTC
nice rej;

*geoip-python-1.3.1 (18 Jul 2014)

  18 Jul 2014; Ian Delaney <idella4@gentoo.org> +geoip-python-1.3.1.ebuild:
  bump; virtual rewrite, add py3 pypy support, patch by A. Ryan submitted in Bug
  #517210, fixes said bug