Created attachment 380684 [details, diff] rc-update-fixes.patch This file rc-update.sh contains some calls to rc-update like "rc-update del netmount" which do not work properly within catalyst/chroot. Since rc-update cannot determine the current runlevel, the command fails. Furthermore, rc-update.sh tries to remove iptables & serial which would never be in a runlevel anyway unless they were explicitly added there. I've attached a patch fixing both issues, and removing some confusing/incorrect comments.
Created attachment 381974 [details, diff] rc-update-fixes-r1.patch Actually by FIXING these commands to actually do soemthing, "rc-update del keymaps default" now makes the official installcd-stage2-minimal build error out when the keymaps removal is handled again with "livecd/rcdel: keymaps|boot" in the spec file. All this chunk of code should really be doing is removing netmount from default, and adding autoconfig to default. The rest is no-op cruft that's just been ignored for years. Adjusted patch attached.
this should definately be done in the specs not in the catalyst code. anyone object to accepting Ben's patches?
Rick, please make a feature request bug to move this to the spec. The code here can just be generic to process anything from the spec.
Please don't let a major feature change or overhaul prevent the fixing of an obvious and easy to fix bug. If you want to move the rc-update calls somewhere else one day, great... but the existing calls here are wrong and can be fixed quickly
Created attachment 498444 [details, diff] rc-update-fixes-r2.patch This patch instead adds --all to the relevant rc-update calls so that they actually work regardless of the (detected) current runlevel.
Merged to 2.X & master.
