Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 516998 - net-libs/nodejs ignores CC CXX
Summary: net-libs/nodejs ignores CC CXX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Johan Bergström
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-07-12 20:10 UTC by Jeroen Roovers (RETIRED)
Modified: 2014-07-23 03:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2014-07-12 20:10:05 UTC
CXX(target) /var/tmp/portage/net-libs/nodejs-0.10.29/work/node-v0.10.29/out/Release/obj.target/v8_base/deps/v8/src/gdb-jit.o
!!! JeR-QA: g++ -> x86_64-pc-linux-gnu-g++
  CXX(target) /var/tmp/portage/net-libs/nodejs-0.10.29/work/node-v0.10.29/out/Release/obj.target/v8_base/deps/v8/src/global-handles.o
!!! JeR-QA: g++ -> x86_64-pc-linux-gnu-g++

and so on.
Comment 1 Mike Gilbert gentoo-dev 2014-07-12 20:38:10 UTC
Do you actually have CXX set in the environment? I seem to recall this working fine in the v8 ebuild.

It probably does not ignore CXX, but it doesn't guess it based on CHOST either.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-12 22:15:03 UTC
(In reply to Mike Gilbert from comment #1)
> Do you actually have CXX set in the environment?

No. I just run `emerge nodejs'. I do have a bit of a script in the portage bashrc that checks for precisely this issue, and then emits a warning and fixes the call (g++ in this case).

> It probably does not ignore CXX, but it doesn't guess it based on CHOST
> either.

You would know for sure if the build system didn't actually hide the calls.
Comment 3 Mike Gilbert gentoo-dev 2014-07-12 22:28:01 UTC
Ah. tc-export will probably resolve it then.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-07-13 01:52:24 UTC
Yes, something like this should do:

--- nodejs-0.10.29.ebuild       12 Jun 2014 09:36:25 -0000      1.1
+++ nodejs-0.10.29.ebuild       13 Jul 2014 01:51:05 -0000
@@ -9,7 +9,7 @@

 PYTHON_COMPAT=( python2_{6,7} )

-inherit python-any-r1 pax-utils
+inherit python-any-r1 pax-utils toolchain-funcs

 DESCRIPTION="Evented IO for V8 Javascript"
 HOMEPAGE="http://nodejs.org/"
@@ -35,6 +35,8 @@

        # less verbose install output (stating the same as portage, basically)
        sed -i -e "/print/d" tools/install.py || die
+
+       tc-export CC CXX
 }

 src_configure() {

As for the verbosity issue, this /is/ the verbose build according to the Makefile. The build system apparently goes even more quiet when you unset V.
Comment 5 Johan Bergström 2014-07-13 04:44:37 UTC
Thanks for the triage and patch! I'll review in a few days, currently with limited connectivity.
Comment 6 Patrick Lauer gentoo-dev 2014-07-23 03:51:50 UTC
Fixed in last bumps.Thanks :)