516508 – git-r3.eclass should not set directory mode 0755 on ${EGIT3_STORE_DIR}

Bug 516508 - git-r3.eclass should not set directory mode 0755 on ${EGIT3_STORE_DIR}

Summary: git-r3.eclass should not set directory mode 0755 on ${EGIT3_STORE_DIR}

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Michał Górny

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2014-07-06 13:02 UTC by Jeroen Roovers (RETIRED)
Modified:	2014-07-07 14:43 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeroen Roovers (RETIRED) gentoo-dev

2014-07-06 13:02:33 UTC

Setting the directory mode 0755 on EGIT3_STORE_DIR clashes with local user/group settings for the parent directory (like sticky group ownership by the portage group). Is there any way to get rid of this and let the default do its thing?

Comment 1 Michał Górny archtester

2014-07-06 13:26:17 UTC

Well, the problem is that if you have an ebuild with RESTRICT=userpriv, it may create store dir readable only by root. Not sure if we have any legit way of avoiding this.

Maybe we could check for $EUID == 0, and apply the wider permissions only then.

Comment 2 Michał Górny archtester

2014-07-07 14:43:16 UTC

+  07 Jul 2014; Michał Górny <mgorny@gentoo.org> git-r3.eclass:
+  Stop forcing -m0755 on EGIT3_STORE_DIR and parents, bug #516508.

Well, after some discussion on #gentoo-dev I've found out that this makes no sense and doesn't serve any purpose therefore. I'm afraid that there's no sane way to fixup the permissions automatically now.