Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515856 - x11-misc/dmenu - add support for savedconfig
Summary: x11-misc/dmenu - add support for savedconfig
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-06-30 13:02 UTC by Ari Malinen
Modified: 2014-06-30 13:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dmenu-4.5-savedconfig.patch (dmenu-4.5-savedconfig.patch,430 bytes, patch)
2014-06-30 13:02 UTC, Ari Malinen
Details | Diff
dmenu-9999.ebuild (dmenu-9999.ebuild,1.38 KB, text/plain)
2014-06-30 13:03 UTC, Ari Malinen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ari Malinen 2014-06-30 13:02:52 UTC
Created attachment 379988 [details, diff]
dmenu-4.5-savedconfig.patch

I added savedconfig to dmenu so it's possible to configure behavior outside of dwm. This allows you to have unified font and colors if you need to launch dmenu from www-client/surf or terminal.
Comment 1 Ari Malinen 2014-06-30 13:03:57 UTC
Created attachment 379992 [details]
dmenu-9999.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-30 13:06:20 UTC
I wonder why I removed it now.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-30 13:09:36 UTC
(In reply to Ari Malinen from comment #1)
> Created attachment 379992 [details]
> dmenu-9999.ebuild

Nothing much changed since last year[1]. Also, using savedconfig in a live ebuild usually doesn't work that well, especially when you use it for a suckless-based config.h.


[1] http://git.suckless.org/dmenu/log/
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-30 13:17:15 UTC
Comment on attachment 379988 [details, diff]
dmenu-4.5-savedconfig.patch

>+	restore_config config.h

[...]

>+	save_config config.h

Now I remember. Newer versions of dmenu do not use config.h at all. Have you tested this patch at all?
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-30 13:18:20 UTC
I guess it would make sense for a -9999 version since upstream has a config.def.h.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-30 13:31:46 UTC
I have added dmenu-9999 to the tree with USE=savedconfig. I don't see anything else to do here.
Comment 7 Ari Malinen 2014-06-30 13:37:15 UTC
(In reply to Jeroen Roovers from comment #6)
> I have added dmenu-9999 to the tree with USE=savedconfig. I don't see
> anything else to do here.
Great thank you.

Sorry i didn't notice the lack of config.h in dmenu-4.5.