The two patches will switch the devmanual layout to the one from infra-status[1]. The navigation is as-is with the previous, parent and next. Maybe we should re-think about that and show the (sub-)tree for navigation. I guess this would require to touch the "contentsTree" template... What do you think about this? [1] https://infra-status.gentoo.org/
Created attachment 379944 [details, diff] 0001-use-bootstrap-layout-from-infra-status.g.o.patch
Created attachment 379946 [details, diff] 0002-Add-jquery-and-bootstrap-.js-files.patch
It has a name. ;)
A screenshot of the new layout would be helpful.
Created attachment 379968 [details] devmanual.g.o-Tyrian.png (In reply to Ulrich Müller from comment #4) > A screenshot of the new layout would be helpful. Here we go.
Created attachment 381376 [details, diff] 0003-Show-current-page-location-under-the-menu.patch Show current page location under the menu - Use the breadcrump component of bootstrap - Add printParentDocs template to generate the entries recursively
Created attachment 381378 [details, diff] 0004-Improve-navigation-a-bit.patch Improve navigation a bit - Add dropdown with available child pages - Use glyphs from bootstrap instead of pure html arrows - Drop parent page menu entry since it's available via breadcrumb
Created attachment 381380 [details] src_unpack.png
Created attachment 381382 [details] src_unpack_dropdown.png
Updated the whole thing a bit. The navigation is a bit better now, but probably not perfect... What do you guys think about it?
(In reply to Markus Meier from comment #10) > Updated the whole thing a bit. The navigation is a bit better now, but > probably not perfect... > > What do you guys think about it? From a quick glance: - The headings seem to include some sort of <a>, rendering them in purple instead of black. (Maybe to set an id? that can be set on the heading as well) - The source code hilighting is unreadable - For notes, use http://getbootstrap.com/components/#alerts - Tables need styling, see http://getbootstrap.com/css/#tables - Navigation: The arrows need at least a space before or after them and the text - Navigation 2: The first link should be a "Home" link
Created attachment 381450 [details, diff] 0005-use-bootstrap-alerts-for-important-note-todo-and-war.patch use bootstrap alerts for important, note, todo and warning tags - drop replaced css parts
Created attachment 381452 [details, diff] 0006-Use-bootstrap-tables.patch Use bootstrap tables - Use css table class for <table>s - Drop custom <th> magic and use bootstrap native one
Created attachment 381454 [details, diff] 0007-Add-explicit-space-between-arrow-and-text-in-navigat.patch Add explicit space between arrow and text in navigation
Created attachment 381456 [details] src_unpack_20140723.png Thanks for your feedback! Tables and notes should be fixed. The arrows should also be fixed. I'll need more time for the rest...
Created attachment 381594 [details, diff] 0008-add-Home-button-to-navigation-bar.patch
Created attachment 381596 [details, diff] 0009-make-pre-s-span.Constant-darker-to-be-more-readable.patch
Created attachment 381598 [details, diff] 0010-drop-a-in-headings.patch
Created attachment 381600 [details] src_unpack_20140726.png (In reply to Alex Legler from comment #11) > From a quick glance: > - The headings seem to include some sort of <a>, rendering them in purple > instead of black. (Maybe to set an id? that can be set on the heading as > well) > - The source code hilighting is unreadable > - For notes, use http://getbootstrap.com/components/#alerts > - Tables need styling, see http://getbootstrap.com/css/#tables > - Navigation: The arrows need at least a space before or after them and the > text > - Navigation 2: The first link should be a "Home" link Should all be fixed with patches 8-10.
(In reply to Markus Meier from comment #19) Okay, we're getting there. :) - The first <h1> has a lot of top margin to the breadcrumb. Use <h1 class="first-header"> to fix that. - The footer height looks extremely weird with znurt and the saucer thing touching eachother. I'd at least put back the "questions..." paragraph (https://github.com/gentoo/tyrian/blob/master/index.html#L228)
Created attachment 383528 [details, diff] 0011-use-first-header-class-for-h1-headings.patch
Created attachment 383530 [details, diff] 0012-Add-Questions-or-comments-to-the-footer.patch
Created attachment 383532 [details, diff] 0013-fix-logo-usage-link.patch
Created attachment 383534 [details] src_unpack_20140824.png (In reply to Alex Legler from comment #20) > (In reply to Markus Meier from comment #19) > > Okay, we're getting there. :) > - The first <h1> has a lot of top margin to the breadcrumb. Use <h1 > class="first-header"> to fix that. > - The footer height looks extremely weird with znurt and the saucer thing > touching eachother. I'd at least put back the "questions..." paragraph > (https://github.com/gentoo/tyrian/blob/master/index.html#L228) Cool! The patches 11-12 address your two points and 13 fixes the logo usage link in the footer.
I will have a look but I need an ACK from Alex before we merge these.
(In reply to Markus Meier from comment #22) > Created attachment 383530 [details, diff] [details, diff] > 0012-Add-Questions-or-comments-to-the-footer.patch This one isn't right. There should be two columns, one width 8 segments, and that one with 4. As we don't have contents for the 8 segment wide column, put nothing or if it doesn't render right. Other than that, I think the changes can go in, I might have other comments or changes when the site is updated though.
(In reply to Alex Legler from comment #26) > (In reply to Markus Meier from comment #22) > > Created attachment 383530 [details, diff] [details, diff] [details, diff] > > 0012-Add-Questions-or-comments-to-the-footer.patch > > This one isn't right. There should be two columns, one width 8 segments, and > that one with 4. As we don't have contents for the 8 segment wide column, > put nothing or if it doesn't render right. > > Other than that, I think the changes can go in, I might have other comments > or changes when the site is updated though. Markus do you think you can sort this out? As a side note, since there are quite a few patches here, would it be easier for you to do a github pull request, or send me a tree to pull, or even commit them yourself.
(In reply to Markos Chandras from comment #27) > (In reply to Alex Legler from comment #26) > > (In reply to Markus Meier from comment #22) > > > Created attachment 383530 [details, diff] [details, diff] [details, diff] [details, diff] > > > 0012-Add-Questions-or-comments-to-the-footer.patch > > > > This one isn't right. There should be two columns, one width 8 segments, and > > that one with 4. As we don't have contents for the 8 segment wide column, > > put nothing or if it doesn't render right. > > > > Other than that, I think the changes can go in, I might have other comments > > or changes when the site is updated though. > > Markus do you think you can sort this out? > > As a side note, since there are quite a few patches here, would it be easier > for you to do a github pull request, or send me a tree to pull, or even > commit them yourself. Hi I'll have a look at this next week (currently on devaway). I guess this should be trivial to fix. I'll create a github pull request to make it easier to merge.
(In reply to Alex Legler from comment #26) > This one isn't right. There should be two columns, one width 8 segments, and > that one with 4. As we don't have contents for the 8 segment wide column, > put nothing or if it doesn't render right. This should fix it: https://github.com/maekke/devmanual.gentoo.org/commit/bf9953a15f8c918551a4b935c41969328c8184e7 (In reply to Markos Chandras from comment #27) > Markus do you think you can sort this out? > > As a side note, since there are quite a few patches here, would it be easier > for you to do a github pull request, or send me a tree to pull, or even > commit them yourself. See pull request at github: https://github.com/gentoo/devmanual.gentoo.org/pull/22
(In reply to Markus Meier from comment #29) > (In reply to Alex Legler from comment #26) > > This one isn't right. There should be two columns, one width 8 segments, and > > that one with 4. As we don't have contents for the 8 segment wide column, > > put nothing or if it doesn't render right. > > This should fix it: > https://github.com/maekke/devmanual.gentoo.org/commit/ > bf9953a15f8c918551a4b935c41969328c8184e7 > No. The columns are the other way around: |--------|----| \__ 8 __/\_ 4_/ ^ ^ Empty column | | Questions/comments
Thanks! Merged!
(In reply to Markos Chandras from comment #31) > Thanks! Merged! ah ok reopening them. Haven't pushed yet...
(In reply to Alex Legler from comment #30) > (In reply to Markus Meier from comment #29) > > (In reply to Alex Legler from comment #26) > > > This one isn't right. There should be two columns, one width 8 segments, and > > > that one with 4. As we don't have contents for the 8 segment wide column, > > > put nothing or if it doesn't render right. > > > > This should fix it: > > https://github.com/maekke/devmanual.gentoo.org/commit/ > > bf9953a15f8c918551a4b935c41969328c8184e7 > > > > No. The columns are the other way around: > > |--------|----| > \__ 8 __/\_ 4_/ > > ^ ^ > Empty column | > | > Questions/comments Whoops, thanks for pointing this out. Should be fixed now, see https://github.com/maekke/devmanual.gentoo.org/commit/d8165eaf1bbe5472fc258df9412606d1075226bb
Hi Once Alex is happy, please update the pull request. Thanks!
Ping?
(In reply to Markos Chandras from comment #35) > Ping? ping again
(In reply to Markos Chandras from comment #36) > (In reply to Markos Chandras from comment #35) > > Ping? > > ping again @dastergon: you seem to be involved in website/tyrian too - maybe you can have a look at this too?!
(In reply to Markus Meier from comment #37) > (In reply to Markos Chandras from comment #36) > > (In reply to Markos Chandras from comment #35) > > > Ping? > > > > ping again > > @dastergon: you seem to be involved in website/tyrian too - maybe you can > have a look at this too?! Can we just apply what we have and fix what's needs fixing later on? If so, please update your pull request and I will pull ASAP
(In reply to Markos Chandras from comment #38) > (In reply to Markus Meier from comment #37) > > (In reply to Markos Chandras from comment #36) > > > (In reply to Markos Chandras from comment #35) > > > > Ping? > > > > > > ping again > > > > @dastergon: you seem to be involved in website/tyrian too - maybe you can > > have a look at this too?! > > Can we just apply what we have and fix what's needs fixing later on? > > If so, please update your pull request and I will pull ASAP Oh, you seem to have been waiting for me. I already ack'ed in c#26. What I said there still stands. So by all means, go.
Great thanks. Markus, give me something to pull please or commit it yourself. Thanks!
(In reply to Markos Chandras from comment #40) > Great thanks. Markus, give me something to pull please or commit it > yourself. Thanks! The pull request should be up-to-date since it points to the boostrap branch.
Ok pulled. Lets see what happens
Created attachment 389002 [details] screenshot of http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html This is how things look here. IMHO it is very hard to read, especially in the code examples (yellow and light blue on grey) and in the "Note" and "Important" boxes (green on light green, blue on light blue). Could the colour scheme be changed to something with higher contrast, please?
Created attachment 389120 [details] src_install_2014-11-11.png (In reply to Ulrich Müller from comment #43) > Created attachment 389002 [details] > screenshot of > http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html > > This is how things look here. IMHO it is very hard to read, especially in > the code examples (yellow and light blue on grey) and in the "Note" and > "Important" boxes (green on light green, blue on light blue). > > Could the colour scheme be changed to something with higher contrast, please? See attached screenshot and pull request @ https://github.com/gentoo/devmanual.gentoo.org/pull/24
(In reply to Markus Meier from comment #44) > Created attachment 389120 [details] > src_install_2014-11-11.png > > (In reply to Ulrich Müller from comment #43) > > Created attachment 389002 [details] > > screenshot of > > http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html > > > > This is how things look here. IMHO it is very hard to read, especially in > > the code examples (yellow and light blue on grey) and in the "Note" and > > "Important" boxes (green on light green, blue on light blue). > > > > Could the colour scheme be changed to something with higher contrast, please? > > See attached screenshot and pull request @ > https://github.com/gentoo/devmanual.gentoo.org/pull/24 I think the background on the coding sections, should be a little bit darker if possible. Ulrich what do you think?
(In reply to Markos Chandras from comment #45) > (In reply to Markus Meier from comment #44) > > Created attachment 389120 [details] > > src_install_2014-11-11.png Better, but still too little contrast in the source code highlighting. (Especially the pink font used for e.g. DESTDIR="${D}" in the second box is hard to read here.) > I think the background on the coding sections, should be a little bit darker > if possible. Ulrich what do you think? No complaints about the background here, but the _foreground_ colours of the fonts could be darker.
Created attachment 389264 [details] src_install_2014-11-13.png (In reply to Ulrich Müller from comment #46) > (In reply to Markos Chandras from comment #45) > > (In reply to Markus Meier from comment #44) > > > Created attachment 389120 [details] > > > src_install_2014-11-11.png > > Better, but still too little contrast in the source code highlighting. > (Especially the pink font used for e.g. DESTDIR="${D}" in the second box is > hard to read here.) Alright, the coloring should now be improved (IMHO), see attached screenshot. The colors are based on zellner.vim scheme. Pull request should be up-to-date.
(In reply to Markus Meier from comment #47) > Alright, the coloring should now be improved (IMHO), see attached > screenshot. The colors are based on zellner.vim scheme. Much better now.
Ulrich ok for me to pull then? Any objections regarding the green Notes sections?
(In reply to Markos Chandras from comment #49) > Ulrich ok for me to pull then? Any objections regarding the green Notes > sections? Although I'd have preferred a somewhat darker foreground colour there too, it's a minor problem compared to the source code highlighting. So I think it's o.k. to pull.
merged thanks
New color scheme is not comfortable for eyes, to be honest. Code blocks are not readable for a long time. You'll be tired after for about 15' of reading. Can we make background darker, at least?
Patches are welcomed :)
@zlogene This major project is otherwise complete, so I see the bug title as misleading. If there are some minor display issues, could you open another bug for them? I'm certain that a bug for fixing the color scheme is more likely to attract a drive-by fix than a bug that looks like it's for overhauling the entire layout.
(In reply to Michael Orlitzky from comment #54) Closing this again. (In reply to Mikle Kolyada from comment #52) > New color scheme is not comfortable for eyes, to be honest. Code blocks are > not readable for a long time. You'll be tired after for about 15' of > reading. Can we make background darker, at least? Please open a new bug for this (including a patch if possible).
